coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/amd/stoneyridge/acpi.c: Create GPIO acpigen procedures
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26335 ) Change subject: soc/amd/stoneyridge/acpi.c: Create GPIO acpigen procedures ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/28103/ : ABORTED -- To view, visit https://review.coreboot.org/26335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9062d889f828a3175b89e6f4a3659ebbf90eac68 Gerrit-Change-Number: 26335 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 21:05:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mtrr.h: Clean up some guards
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26761 ) Change subject: cpu/x86/mtrr.h: Clean up some guards ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73988/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28101/ : SUCCESS -- To view, visit https://review.coreboot.org/26761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4571c46a0c05a080b2b1cfec64b4eda07d793bb Gerrit-Change-Number: 26761 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:45:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel: Use postcar_frame_add_romcache()
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26579 ) Change subject: nb/intel: Use postcar_frame_add_romcache() ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73984/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28097/ : SUCCESS -- To view, visit https://review.coreboot.org/26579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0729ca4cdad7d2218c1e1feae5cd38dda6d4e11e Gerrit-Change-Number: 26579 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:42:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: pcengines/apu1: align with apu{2, 3, 4, 5} lowercase naming
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26757 ) Change subject: pcengines/apu1: align with apu{2,3,4,5} lowercase naming ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73987/ : SUCCESS -- To view, visit https://review.coreboot.org/26757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6942bc36df1a02db61b035ddc892585688aa27b Gerrit-Change-Number: 26757 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Assignee: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:40:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/x86: Introduce postcar_frame_add_romcache()
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26577 ) Change subject: arch/x86: Introduce postcar_frame_add_romcache() ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73986/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28100/ : SUCCESS -- To view, visit https://review.coreboot.org/26577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fabc6b87fb36dc3d970805eb804cd950b8849d4 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:36:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mtrr.h: Clean up some guards
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26761 ) Change subject: cpu/x86/mtrr.h: Clean up some guards ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73985/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28099/ : SUCCESS -- To view, visit https://review.coreboot.org/26761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4571c46a0c05a080b2b1cfec64b4eda07d793bb Gerrit-Change-Number: 26761 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:32:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/{amd, intel}: Use postcar_frame_add_romcache()
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26580 ) Change subject: soc/{amd,intel}: Use postcar_frame_add_romcache() ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73983/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28096/ : SUCCESS -- To view, visit https://review.coreboot.org/26580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee816628ac3c33633f5f45798562a4ce49493a65 Gerrit-Change-Number: 26580 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:28:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86: Introduce postcar_frame_add_romcache()
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26577 ) Change subject: arch/x86: Introduce postcar_frame_add_romcache() ...................................................................... Patch Set 4: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/28098/ : SUCCESS -- To view, visit https://review.coreboot.org/26577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fabc6b87fb36dc3d970805eb804cd950b8849d4 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:08:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mtrr.h: Clean up some guards
by Nico Huber (Code Review) 01 Jun '18

01 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26761 Change subject: cpu/x86/mtrr.h: Clean up some guards ...................................................................... cpu/x86/mtrr.h: Clean up some guards Move #includes to the top and remove unnecessary guards. Hopefully this prevents future surprises. Change-Id: Id4571c46a0c05a080b2b1cfec64b4eda07d793bb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/include/cpu/x86/mtrr.h 1 file changed, 9 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/26761/1 diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index dde9a28..789edc7 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -2,6 +2,8 @@ #define CPU_X86_MTRR_H #include <commonlib/helpers.h> +#include <cpu/x86/msr.h> +#include <arch/cpu.h> /* These are the region types */ #define MTRR_TYPE_UNCACHEABLE 0 @@ -95,6 +97,13 @@ unsigned int type); int get_free_var_mtrr(void); +/* + * Set the MTRRs using the data on the stack from setup_stack_and_mtrrs. + * Return a new top_of_stack value which removes the setup_stack_and_mtrrs data. + */ +asmlinkage void *soc_set_mtrrs(void *top_of_stack); +asmlinkage void soc_enable_mtrrs(void); + /* fms: find most significant bit set, stolen from Linux Kernel Source. */ static inline unsigned int fms(unsigned int x) { @@ -172,17 +181,4 @@ #define CACHE_ROM_BASE _FROM_4G_TOP(CACHE_ROM_SIZE) -#if (IS_ENABLED(CONFIG_SOC_SETS_MSRS) && !defined(__ASSEMBLER__) \ - && !defined(__ROMCC__)) -#include <cpu/x86/msr.h> -#include <arch/cpu.h> - -/* - * Set the MTRRs using the data on the stack from setup_stack_and_mtrrs. - * Return a new top_of_stack value which removes the setup_stack_and_mtrrs data. - */ -asmlinkage void *soc_set_mtrrs(void *top_of_stack); -asmlinkage void soc_enable_mtrrs(void); -#endif /* CONFIG_SOC_SETS_MSRS ... */ - #endif /* CPU_X86_MTRR_H */ -- To view, visit https://review.coreboot.org/26761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id4571c46a0c05a080b2b1cfec64b4eda07d793bb Gerrit-Change-Number: 26761 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel/apollolake: Add Page table mapping for System Memory
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26745 ) Change subject: soc/intel/apollolake: Add Page table mapping for System Memory ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73961/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28074/ : SUCCESS -- To view, visit https://review.coreboot.org/26745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce2d489240e6e3686ceb7f6e824e5a94398d47e Gerrit-Change-Number: 26745 Gerrit-PatchSet: 3 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 18:12:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018