coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 39: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73960/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28073/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 39 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 16:30:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/cpu: Remove unneeded includes
by Martin Roth (Code Review) 01 Jun '18

01 Jun '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/26732 ) Change subject: src/cpu: Remove unneeded includes ...................................................................... src/cpu: Remove unneeded includes Change-Id: I8fb03ada29b37f96fb02122462dfb8ec7faa9d31 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26732 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/cpu/intel/fsp_model_206ax/bootblock.c M src/cpu/intel/model_65x/model_65x_init.c M src/cpu/intel/model_67x/model_67x_init.c M src/cpu/intel/model_68x/model_68x_init.c M src/cpu/intel/model_69x/model_69x_init.c M src/cpu/intel/model_6bx/model_6bx_init.c M src/cpu/intel/model_6dx/model_6dx_init.c M src/cpu/intel/slot_1/l2_cache.c M src/cpu/x86/lapic/lapic.c M src/cpu/x86/tsc/delay_tsc.c 10 files changed, 0 insertions(+), 28 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/src/cpu/intel/fsp_model_206ax/bootblock.c b/src/cpu/intel/fsp_model_206ax/bootblock.c index ed68883..297edd2 100644 --- a/src/cpu/intel/fsp_model_206ax/bootblock.c +++ b/src/cpu/intel/fsp_model_206ax/bootblock.c @@ -13,15 +13,7 @@ * GNU General Public License for more details. */ -#include <stdint.h> -#include <arch/cpu.h> -#include <cpu/x86/cache.h> -#include <cpu/x86/msr.h> -#include <cpu/x86/mtrr.h> -#include <arch/io.h> - #include <cpu/intel/microcode/microcode.c> -#include "model_206ax.h" static void bootblock_cpu_init(void) { diff --git a/src/cpu/intel/model_65x/model_65x_init.c b/src/cpu/intel/model_65x/model_65x_init.c index 9eab9c7..dde3427 100644 --- a/src/cpu/intel/model_65x/model_65x_init.c +++ b/src/cpu/intel/model_65x/model_65x_init.c @@ -14,11 +14,9 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/device.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> diff --git a/src/cpu/intel/model_67x/model_67x_init.c b/src/cpu/intel/model_67x/model_67x_init.c index 4fd51d3..130105ee 100644 --- a/src/cpu/intel/model_67x/model_67x_init.c +++ b/src/cpu/intel/model_67x/model_67x_init.c @@ -14,15 +14,12 @@ * GNU General Public License for more details. */ -#include <console/console.h> -#include <string.h> #include <device/device.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> -#include <cpu/x86/msr.h> #include <cpu/intel/l2_cache.h> static void model_67x_init(struct device *cpu) diff --git a/src/cpu/intel/model_68x/model_68x_init.c b/src/cpu/intel/model_68x/model_68x_init.c index 17c9eb7..4c549bc 100644 --- a/src/cpu/intel/model_68x/model_68x_init.c +++ b/src/cpu/intel/model_68x/model_68x_init.c @@ -17,10 +17,8 @@ #include <console/console.h> #include <device/device.h> -#include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> diff --git a/src/cpu/intel/model_69x/model_69x_init.c b/src/cpu/intel/model_69x/model_69x_init.c index 785c480..fe7d2ca 100644 --- a/src/cpu/intel/model_69x/model_69x_init.c +++ b/src/cpu/intel/model_69x/model_69x_init.c @@ -11,12 +11,9 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include <device/device.h> -#include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> diff --git a/src/cpu/intel/model_6bx/model_6bx_init.c b/src/cpu/intel/model_6bx/model_6bx_init.c index ce70539..617c8aa 100644 --- a/src/cpu/intel/model_6bx/model_6bx_init.c +++ b/src/cpu/intel/model_6bx/model_6bx_init.c @@ -17,10 +17,8 @@ #include <console/console.h> #include <device/device.h> -#include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> diff --git a/src/cpu/intel/model_6dx/model_6dx_init.c b/src/cpu/intel/model_6dx/model_6dx_init.c index 6097c33..337b613 100644 --- a/src/cpu/intel/model_6dx/model_6dx_init.c +++ b/src/cpu/intel/model_6dx/model_6dx_init.c @@ -11,12 +11,9 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include <device/device.h> -#include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> diff --git a/src/cpu/intel/slot_1/l2_cache.c b/src/cpu/intel/slot_1/l2_cache.c index 05eaeb3..617a4e6 100644 --- a/src/cpu/intel/slot_1/l2_cache.c +++ b/src/cpu/intel/slot_1/l2_cache.c @@ -40,9 +40,7 @@ #include <stdint.h> #include <console/console.h> -#include <string.h> #include <cpu/cpu.h> -#include <cpu/x86/mtrr.h> #include <cpu/intel/l2_cache.h> #include <cpu/x86/cache.h> #include <cpu/x86/msr.h> diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c index ca0ff94..8cd3092 100644 --- a/src/cpu/x86/lapic/lapic.c +++ b/src/cpu/x86/lapic/lapic.c @@ -13,8 +13,6 @@ #include <cpu/x86/lapic.h> #include <console/console.h> -#include <cpu/x86/msr.h> -#include <cpu/x86/mtrr.h> void do_lapic_init(void) { diff --git a/src/cpu/x86/tsc/delay_tsc.c b/src/cpu/x86/tsc/delay_tsc.c index ec2f1d7..04f709f 100644 --- a/src/cpu/x86/tsc/delay_tsc.c +++ b/src/cpu/x86/tsc/delay_tsc.c @@ -14,7 +14,6 @@ #include <arch/early_variables.h> #include <console/console.h> #include <arch/io.h> -#include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <smp/spinlock.h> #include <delay.h> -- To view, visit https://review.coreboot.org/26732 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8fb03ada29b37f96fb02122462dfb8ec7faa9d31 Gerrit-Change-Number: 26732 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 38: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73959/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28072/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 38 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 16:05:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 37: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73958/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28071/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 37 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 15:48:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: pcengines/apu1: align with apu{2, 3, 4, 5} lowe case naming
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26757 ) Change subject: pcengines/apu1: align with apu{2,3,4,5} lowe case naming ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73957/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28070/ : SUCCESS -- To view, visit https://review.coreboot.org/26757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6942bc36df1a02db61b035ddc892585688aa27b Gerrit-Change-Number: 26757 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Assignee: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 15:26:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: pcengines/apu1: align with apu{2, 3, 4, 5} lowe case naming
by Piotr Król (Code Review) 01 Jun '18

01 Jun '18

Piotr Król has uploaded this change for review. ( https://review.coreboot.org/26757 Change subject: pcengines/apu1: align with apu{2,3,4,5} lowe case naming ...................................................................... pcengines/apu1: align with apu{2,3,4,5} lowe case naming Change-Id: Ic6942bc36df1a02db61b035ddc892585688aa27b Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> --- M src/mainboard/pcengines/apu1/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/26757/1 diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index 5e927cc..8361d8d 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_PART_NUMBER string - default "APU1" + default "apu1" config HW_MEM_HOLE_SIZEK hex -- To view, visit https://review.coreboot.org/26757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6942bc36df1a02db61b035ddc892585688aa27b Gerrit-Change-Number: 26757 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by Philipp Deppenwiese (Code Review) 01 Jun '18

01 Jun '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 36: (11 comments) https://review.coreboot.org/#/c/24903/33/src/cpu/intel/haswell/romstage.c File src/cpu/intel/haswell/romstage.c: https://review.coreboot.org/#/c/24903/33/src/cpu/intel/haswell/romstage.c@2… PS33, Line 248: if (IS_ENABLED(CONFIG_TPM1) || IS_ENABLED(CONFIG_TPM2)) > Follow up: add helper tpm_enabled_in_build() which encapsulates this? I wrote a generic driver which runs in ramstage. So it's already done in a follow up. :) https://review.coreboot.org/#/c/24903/33/src/mainboard/google/auron/Kconfig File src/mainboard/google/auron/Kconfig: https://review.coreboot.org/#/c/24903/33/src/mainboard/google/auron/Kconfig… PS33, Line 13: select MAINBOARD_HAS_TPM1 > I'm a little confused by this. […] Yeah that's normal. If you don't select it you will get a menu in kconfig for selecting the tpm version. This is needed for desktop and server boards having a TPM header https://review.coreboot.org/#/c/24903/33/src/mainboard/google/cheza/Kconfig File src/mainboard/google/cheza/Kconfig: https://review.coreboot.org/#/c/24903/33/src/mainboard/google/cheza/Kconfig… PS33, Line 15: select MAINBOARD_HAS_TPM1 > Where'd you come up with this one? It's actually using cr50 over spi. […] Okay will fix it. https://review.coreboot.org/#/c/24903/33/src/mainboard/google/eve/Kconfig File src/mainboard/google/eve/Kconfig: https://review.coreboot.org/#/c/24903/33/src/mainboard/google/eve/Kconfig@19 PS33, Line 19: select MAINBOARD_HAS_I2C_TPM_CR50 > I think TPM_CR50 should auto select HAS_TPM2... […] CR50 is just an addition and get in through MAINBOARD_HAS_I2C_TPM_CR50. We could also a MAINBOARD_HAS_CR50 https://review.coreboot.org/#/c/24903/33/src/security/tpm/tspi.h File src/security/tpm/tspi.h: https://review.coreboot.org/#/c/24903/33/src/security/tpm/tspi.h@20 PS33, Line 20: #include <security/tpm/tss.h> > We should document the return values here so it's understood what the meaning of the values are. Okay got it. Will also add the function parms as well https://review.coreboot.org/#/c/24903/33/src/security/tpm/tss.h File src/security/tpm/tss.h: https://review.coreboot.org/#/c/24903/33/src/security/tpm/tss.h@57 PS33, Line 57: > Not necessarily true any longer as one can specify the policy? Or is the nv_policy different than th […] Yep good catch will fix it https://review.coreboot.org/#/c/24903/33/src/security/tpm/tss.h@172 PS33, Line 172: */ > Still need to get through the rest of the patch, but why does this declaration need to be here if it […] It's used if you have a tpm variant based on TPM2 by googles CR50 So let's just rename the comment https://review.coreboot.org/#/c/24903/33/src/security/tpm/tss/tcg-2.0/tss_m… File src/security/tpm/tss/tcg-2.0/tss_marshaling.h: https://review.coreboot.org/#/c/24903/33/src/security/tpm/tss/tcg-2.0/tss_m… PS33, Line 11: #include <security/tpm/tss/vendor/cr50/cr50.h> > why is this header needed in here? Okay I will fix it https://review.coreboot.org/#/c/24903/33/src/security/vboot/Kconfig File src/security/vboot/Kconfig: https://review.coreboot.org/#/c/24903/33/src/security/vboot/Kconfig@20 PS33, Line 20: select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2 > I was hoping we could get away with having this override everything. But it is what it is. […] I did that in order to support verified boot without TPM support even if it is more insecure. There is no other solution https://review.coreboot.org/#/c/24903/33/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c: https://review.coreboot.org/#/c/24903/33/src/security/vboot/secdata_tpm.c@1… PS33, Line 166: const TPMA_NV ro_space_attributes = { > Were these extern'd in a header somewhere? If no one is using these outside of this compilation unit […] gotcha https://review.coreboot.org/#/c/24903/33/src/soc/intel/apollolake/Kconfig File src/soc/intel/apollolake/Kconfig: https://review.coreboot.org/#/c/24903/33/src/soc/intel/apollolake/Kconfig@1… PS33, Line 126: default n > why get rid of the auto-selection here? maybe depends on MAINBOARD_HAS_LPC_TPM makes more sense. Will fix it -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 36 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:56:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/amd/pi/00670F00: Remove IdsLib.h ref
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26755 ) Change subject: vendorcode/amd/pi/00670F00: Remove IdsLib.h ref ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73954/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28067/ : SUCCESS -- To view, visit https://review.coreboot.org/26755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03134b37ac4ed30c425b6af727da74bc8d480670 Gerrit-Change-Number: 26755 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:55:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86: Remove unneeded includes
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26751 ) Change subject: arch/x86: Remove unneeded includes ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73956/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28069/ : SUCCESS -- To view, visit https://review.coreboot.org/26751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Gerrit-Change-Number: 26751 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:49:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/fsp_broadwell_de: Drop unused files
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26756 ) Change subject: soc/intel/fsp_broadwell_de: Drop unused files ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73955/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28068/ : SUCCESS -- To view, visit https://review.coreboot.org/26756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I629cdeb337fce381c69bd1ba0520e524ccdd90dd Gerrit-Change-Number: 26756 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 14:44:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018