coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: util/inteltool: Add Pentium 4 model f6x
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23521 ) Change subject: util/inteltool: Add Pentium 4 model f6x ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/23521/6/util/inteltool/cpu.c File util/inteltool/cpu.c: https://review.coreboot.org/#/c/23521/6/util/inteltool/cpu.c@1547 PS6, Line 1547: { 0x00f60, modelf6x_global_msrs, ARRAY_SIZE(modelf6x_global_msrs), modelf6x_per_core_msrs, ARRAY_SIZE(modelf6x_per_core_msrs) }, line over 80 characters -- To view, visit https://review.coreboot.org/23521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27c4bb0aed3259aa332581384077e000c9fb4b4c Gerrit-Change-Number: 23521 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:43:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/inteltool: Add Pentium 4 model f6x
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23521 ) Change subject: util/inteltool: Add Pentium 4 model f6x ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/74010/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/28122/ : SUCCESS -- To view, visit https://review.coreboot.org/23521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27c4bb0aed3259aa332581384077e000c9fb4b4c Gerrit-Change-Number: 23521 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:43:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/inteltool: Add Pentium 4 model f6x
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23521 ) Change subject: util/inteltool: Add Pentium 4 model f6x ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/23521/5/util/inteltool/cpu.c File util/inteltool/cpu.c: https://review.coreboot.org/#/c/23521/5/util/inteltool/cpu.c@1548 PS5, Line 1548: { 0x00f60, modelf6x_global_msrs, ARRAY_SIZE(modelf6x_global_msrs), modelf6x_per_core_msrs, ARRAY_SIZE(modelf6x_per_core_msrs) }, line over 80 characters -- To view, visit https://review.coreboot.org/23521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27c4bb0aed3259aa332581384077e000c9fb4b4c Gerrit-Change-Number: 23521 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:41:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/lint: Update lint-000-license-headers linter
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26572 ) Change subject: util/lint: Update lint-000-license-headers linter ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74007/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28119/ : SUCCESS -- To view, visit https://review.coreboot.org/26572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53423205f1cbf142a294ee5d24e885741a44dfcd Gerrit-Change-Number: 26572 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:24:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint: Update lint-stable-000-license-headers linter
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26573 ) Change subject: util/lint: Update lint-stable-000-license-headers linter ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/74008/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/28120/ : SUCCESS -- To view, visit https://review.coreboot.org/26573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40046a2fb7359262b130f6813eda1f2c30916b46 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:23:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/mainboard: Add and update license headers
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26568 ) Change subject: src/mainboard: Add and update license headers ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74006/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28118/ : SUCCESS -- To view, visit https://review.coreboot.org/26568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe038a8f7468253b21fd2ac90c045d0c9cc89dfc Gerrit-Change-Number: 26568 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 18:22:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/cpu/intel: Remove unneeded includes
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26769 ) Change subject: include/cpu/intel: Remove unneeded includes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74000/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28112/ : SUCCESS -- To view, visit https://review.coreboot.org/26769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Gerrit-Change-Number: 26769 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 16:29:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/cpu/intel: Remove unneeded includes
by Elyes HAOUAS (Code Review) 02 Jun '18

02 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26769 to look at the new patch set (#2). Change subject: include/cpu/intel: Remove unneeded includes ...................................................................... include/cpu/intel: Remove unneeded includes Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/cpu/intel/microcode.h M src/include/cpu/intel/speedstep.h 2 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26769/2 -- To view, visit https://review.coreboot.org/26769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Gerrit-Change-Number: 26769 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: include/cpu/intel: Remove unneeded includes
by build bot (Jenkins) (Code Review) 02 Jun '18

02 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26769 ) Change subject: include/cpu/intel: Remove unneeded includes ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73999/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28111/ : SUCCESS -- To view, visit https://review.coreboot.org/26769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Gerrit-Change-Number: 26769 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 16:16:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/cpu/intel: Remove unneeded includes
by Elyes HAOUAS (Code Review) 02 Jun '18

02 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26769 Change subject: include/cpu/intel: Remove unneeded includes ...................................................................... include/cpu/intel: Remove unneeded includes Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/cpu/intel/microcode.h M src/include/cpu/intel/romstage.h M src/include/cpu/intel/speedstep.h 3 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26769/1 diff --git a/src/include/cpu/intel/microcode.h b/src/include/cpu/intel/microcode.h index 0783ace..f94bee4 100644 --- a/src/include/cpu/intel/microcode.h +++ b/src/include/cpu/intel/microcode.h @@ -16,8 +16,6 @@ #ifndef __CPU__INTEL__MICROCODE__ #define __CPU__INTEL__MICROCODE__ -#include <stdint.h> - void intel_update_microcode_from_cbfs(void); /* Find a microcode that matches the revision and platform family returning * NULL if none found. */ diff --git a/src/include/cpu/intel/romstage.h b/src/include/cpu/intel/romstage.h index 3a9e989..394132d 100644 --- a/src/include/cpu/intel/romstage.h +++ b/src/include/cpu/intel/romstage.h @@ -1,8 +1,6 @@ #ifndef _CPU_INTEL_ROMSTAGE_H #define _CPU_INTEL_ROMSTAGE_H -#include <arch/cpu.h> - void mainboard_romstage_entry(unsigned long bist); /* romstage_main is called from the cache-as-ram assembly file. The return diff --git a/src/include/cpu/intel/speedstep.h b/src/include/cpu/intel/speedstep.h index 4b556b7..7189c52 100644 --- a/src/include/cpu/intel/speedstep.h +++ b/src/include/cpu/intel/speedstep.h @@ -18,8 +18,6 @@ #ifndef CPU_INTEL_SPEEDSTEP_H #define CPU_INTEL_SPEEDSTEP_H -#include <stdint.h> - /* Magic value used to locate speedstep configuration in the device tree */ #define SPEEDSTEP_APIC_MAGIC 0xACAC -- To view, visit https://review.coreboot.org/26769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba1347a2b9ef99f9751b2a4e375ad9503bd53a56 Gerrit-Change-Number: 26769 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018