coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 35: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73936/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28049/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 35 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:52:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/console/vtxprintf.c: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26753 ) Change subject: src/console/vtxprintf.c: Remove unneeded 'console.h' include ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73935/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28048/ : SUCCESS -- To view, visit https://review.coreboot.org/26753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d7caaf58b3119a9fff339df1159a6e3277fc2dc Gerrit-Change-Number: 26753 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:45:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/console/vtxprintf.c: Remove unneeded 'console.h' include
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26753 Change subject: src/console/vtxprintf.c: Remove unneeded 'console.h' include ...................................................................... src/console/vtxprintf.c: Remove unneeded 'console.h' include Change-Id: I1d7caaf58b3119a9fff339df1159a6e3277fc2dc Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/console/vtxprintf.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/26753/1 diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index 63e6703..50bd470 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -15,7 +15,6 @@ * vtxprintf.c, originally from linux/lib/vsprintf.c */ -#include <console/console.h> #include <console/vtxprintf.h> #include <string.h> -- To view, visit https://review.coreboot.org/26753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d7caaf58b3119a9fff339df1159a6e3277fc2dc Gerrit-Change-Number: 26753 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by Nico Huber (Code Review) 01 Jun '18

01 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:38:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73934/ : SUCCESS -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:26:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26752 to look at the new patch set (#4). Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... src/commonlib/storage: Move include <console.h> to sd_mmc.h Non of the .c files is using a function from console.h directly. Include console.h is moved to sd_mmc.h, where sdhc_error("msg..") is defined. Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/mmc.c M src/commonlib/storage/pci_sdhci.c M src/commonlib/storage/sd_mmc.h M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_display.c M src/commonlib/storage/storage_erase.c M src/commonlib/storage/storage_write.c 8 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/26752/4 -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73933/ : SUCCESS -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:15:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by Nico Huber (Code Review) 01 Jun '18

01 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/26752/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/26752/3//COMMIT_MSG@8 PS3, Line 8: Please mention why. -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:14:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/commonlib/storage: Move include <console.h> to sd_mmc.h
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26752 to look at the new patch set (#3). Change subject: src/commonlib/storage: Move include <console.h> to sd_mmc.h ...................................................................... src/commonlib/storage: Move include <console.h> to sd_mmc.h Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/mmc.c M src/commonlib/storage/pci_sdhci.c M src/commonlib/storage/sd_mmc.h M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_display.c M src/commonlib/storage/storage_erase.c M src/commonlib/storage/storage_write.c 8 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/26752/3 -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/commonlib: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib: Remove unneeded 'console.h' include ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73932/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28047/ : SUCCESS -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:07:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018