coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: arch/x86: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26751 ) Change subject: arch/x86: Remove unneeded 'console.h' include ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73931/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28046/ : SUCCESS -- To view, visit https://review.coreboot.org/26751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Gerrit-Change-Number: 26751 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:03:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/commonlib: Remove unneeded 'console.h' include
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26752 to look at the new patch set (#2). Change subject: src/commonlib: Remove unneeded 'console.h' include ...................................................................... src/commonlib: Remove unneeded 'console.h' include Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/mmc.c M src/commonlib/storage/pci_sdhci.c M src/commonlib/storage/sd_mmc.h M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_display.c M src/commonlib/storage/storage_erase.c M src/commonlib/storage/storage_write.c 8 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/26752/2 -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/commonlib: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26752 ) Change subject: src/commonlib: Remove unneeded 'console.h' include ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73930/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28045/ : SUCCESS -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 12:59:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86: Remove unneeded 'console.h' include
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26751 to look at the new patch set (#2). Change subject: arch/x86: Remove unneeded 'console.h' include ...................................................................... arch/x86: Remove unneeded 'console.h' include Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/cbmem.c M src/arch/x86/cpu_common.c M src/arch/x86/pci_ops_conf1.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/26751/2 -- To view, visit https://review.coreboot.org/26751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Gerrit-Change-Number: 26751 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/commonlib: Remove unneeded 'console.h' include
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26752 Change subject: src/commonlib: Remove unneeded 'console.h' include ...................................................................... src/commonlib: Remove unneeded 'console.h' include Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/mmc.c M src/commonlib/storage/pci_sdhci.c M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_display.c M src/commonlib/storage/storage_erase.c M src/commonlib/storage/storage_write.c 7 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/26752/1 diff --git a/src/commonlib/storage/bouncebuf.c b/src/commonlib/storage/bouncebuf.c index c8125aa..6ddfb70 100644 --- a/src/commonlib/storage/bouncebuf.c +++ b/src/commonlib/storage/bouncebuf.c @@ -16,7 +16,6 @@ */ #include <arch/cache.h> -#include <console/console.h> #include "bouncebuf.h" #include <halt.h> #include "storage.h" diff --git a/src/commonlib/storage/mmc.c b/src/commonlib/storage/mmc.c index ca06705..d88e469 100644 --- a/src/commonlib/storage/mmc.c +++ b/src/commonlib/storage/mmc.c @@ -20,7 +20,6 @@ */ #include <commonlib/storage.h> -#include <console/console.h> #include <delay.h> #include "sd_mmc.h" #include "mmc.h" diff --git a/src/commonlib/storage/pci_sdhci.c b/src/commonlib/storage/pci_sdhci.c index c53ab00..329b652 100644 --- a/src/commonlib/storage/pci_sdhci.c +++ b/src/commonlib/storage/pci_sdhci.c @@ -20,7 +20,6 @@ #include <assert.h> #include <commonlib/sdhci.h> -#include <console/console.h> #include <device/pci.h> #include "sd_mmc.h" #include "storage.h" diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c index a5508ee..158e28b 100644 --- a/src/commonlib/storage/sdhci.c +++ b/src/commonlib/storage/sdhci.c @@ -19,7 +19,6 @@ #include <assert.h> #include "bouncebuf.h" -#include <console/console.h> #include <commonlib/sd_mmc_ctrlr.h> #include <commonlib/sdhci.h> #include <commonlib/storage.h> diff --git a/src/commonlib/storage/sdhci_display.c b/src/commonlib/storage/sdhci_display.c index d05e35a..68747f4 100644 --- a/src/commonlib/storage/sdhci_display.c +++ b/src/commonlib/storage/sdhci_display.c @@ -20,7 +20,6 @@ #include <commonlib/sd_mmc_ctrlr.h> #include <commonlib/sdhci.h> #include <commonlib/storage.h> -#include <console/console.h> #include "sdhci.h" #include "sd_mmc.h" #include "storage.h" diff --git a/src/commonlib/storage/storage_erase.c b/src/commonlib/storage/storage_erase.c index 004a200..8e97755 100644 --- a/src/commonlib/storage/storage_erase.c +++ b/src/commonlib/storage/storage_erase.c @@ -19,7 +19,6 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include "sd_mmc.h" #include "storage.h" diff --git a/src/commonlib/storage/storage_write.c b/src/commonlib/storage/storage_write.c index ae9fbc2..ba60b41 100644 --- a/src/commonlib/storage/storage_write.c +++ b/src/commonlib/storage/storage_write.c @@ -19,7 +19,6 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include "sd_mmc.h" #include "storage.h" #include <string.h> -- To view, visit https://review.coreboot.org/26752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9283f227a37785056b9fac216fabcac054066a0 Gerrit-Change-Number: 26752 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: arch/x86: Remove unneeded 'console.h' include
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26751 ) Change subject: arch/x86: Remove unneeded 'console.h' include ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73929/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28044/ : SUCCESS -- To view, visit https://review.coreboot.org/26751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Gerrit-Change-Number: 26751 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 12:50:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86: Remove unneeded 'console.h' include
by Elyes HAOUAS (Code Review) 01 Jun '18

01 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26751 Change subject: arch/x86: Remove unneeded 'console.h' include ...................................................................... arch/x86: Remove unneeded 'console.h' include Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/cbmem.c M src/arch/x86/cpu_common.c M src/arch/x86/ebda.c M src/arch/x86/pci_ops_conf1.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/26751/1 diff --git a/src/arch/x86/cbmem.c b/src/arch/x86/cbmem.c index ef53553..52f8f8a 100644 --- a/src/arch/x86/cbmem.c +++ b/src/arch/x86/cbmem.c @@ -12,7 +12,6 @@ */ #include <stdlib.h> -#include <console/console.h> #include <cbmem.h> #include <compiler.h> #include <arch/acpi.h> diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index 26cf69f..8963f8d 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include <cpu/cpu.h> #include <arch/io.h> #include <string.h> diff --git a/src/arch/x86/ebda.c b/src/arch/x86/ebda.c index f6726cf..b6255fa 100644 --- a/src/arch/x86/ebda.c +++ b/src/arch/x86/ebda.c @@ -19,7 +19,6 @@ #include <arch/io.h> #include <arch/ebda.h> #include <commonlib/endian.h> -#include <console/console.h> static void *get_ebda_start(void) { diff --git a/src/arch/x86/pci_ops_conf1.c b/src/arch/x86/pci_ops_conf1.c index a92fd31..af05906 100644 --- a/src/arch/x86/pci_ops_conf1.c +++ b/src/arch/x86/pci_ops_conf1.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include <arch/io.h> #include <device/pci.h> #include <device/pci_ids.h> -- To view, visit https://review.coreboot.org/26751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0b87e2b36a282c773e5f2f4a96c23aeadecb1300 Gerrit-Change-Number: 26751 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73928/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28043/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 34 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 11:21:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: hp/compaq_8200_elite: Fix TPM not visible in OS
by build bot (Jenkins) (Code Review) 01 Jun '18

01 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26750 ) Change subject: hp/compaq_8200_elite: Fix TPM not visible in OS ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73927/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28042/ : SUCCESS -- To view, visit https://review.coreboot.org/26750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0ecd2f2f3e303f2228743369a8025b327bee61d Gerrit-Change-Number: 26750 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Jun 2018 10:02:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: hp/compaq_8200_elite: Fix TPM not visible in OS
by Patrick Rudolph (Code Review) 01 Jun '18

01 Jun '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/26750 Change subject: hp/compaq_8200_elite: Fix TPM not visible in OS ...................................................................... hp/compaq_8200_elite: Fix TPM not visible in OS Chip sections must be covered by a PCI device. Fixes chip_ops not being executed and TPM shows up in OS. Change-Id: Id0ecd2f2f3e303f2228743369a8025b327bee61d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/26750/1 diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index fab4cca..e7aecdb 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -198,9 +198,9 @@ #drq 0xfe = 0x03 end end - end - chip drivers/pc80/tpm - device pnp 4e.0 on end # TPM module + chip drivers/pc80/tpm + device pnp 4e.0 on end # TPM module + end end device pci 1f.2 on # SATA Controller 1 subsystemid 0x103c 0x1495 -- To view, visit https://review.coreboot.org/26750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id0ecd2f2f3e303f2228743369a8025b327bee61d Gerrit-Change-Number: 26750 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018