Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24903 )
Change subject: security/tpm: Unify the coreboot TPM software stack
......................................................................
Patch Set 39:
(1 comment)
https://review.coreboot.org/#/c/24903/33/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/24903/33/src/security/vboot/Kconfig@20
PS33, Line 20: select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2
> For cheza we have MOCK_SECDATA selected as well as CR50 options: […]
Yes it works because even if you have a TPM you can select to use the vboot mock and disable the antirollback protection :)
--
To view, visit https://review.coreboot.org/24903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f
Gerrit-Change-Number: 24903
Gerrit-PatchSet: 39
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 11:40:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26634 )
Change subject: mb/roda: Get rid of whitespace before tab
......................................................................
Patch Set 2: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74148/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28256/ : SUCCESS
--
To view, visit https://review.coreboot.org/26634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9a6ba85e63c5758e83ee319f5fcfedbcd787553
Gerrit-Change-Number: 26634
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Mon, 04 Jun 2018 11:03:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26823
to look at the new patch set (#3).
Change subject: 3rdparty/libgfxinit: Update submodule pointer
......................................................................
3rdparty/libgfxinit: Update submodule pointer
Update to current master.
This includes:
- G45 support
- fixes scaling on eDP (needed for working textmode on eDP)
- gfx_test drawing and moving cursors
- Adding support for Tiling on <= Haswell
- Allow changes to the framebuffer configurarion without resetting the
pipe.
Change-Id: I4ff3c17ec7308115de7bf2f2bb9276c2fad41253
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M 3rdparty/libgfxinit
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/26823/3
--
To view, visit https://review.coreboot.org/26823
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ff3c17ec7308115de7bf2f2bb9276c2fad41253
Gerrit-Change-Number: 26823
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/26823 )
Change subject: 3rdparty/libgfxinit: Update submodule pointer
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/26823/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/26823/1//COMMIT_MSG@13
PS1, Line 13: EDP
eDP (and the fix is about scaling for eDP in general)
https://review.coreboot.org/#/c/26823/1//COMMIT_MSG@15
PS1, Line 15: and enab
It's not really new (only for <= Haswell) and not enabled by default.
https://review.coreboot.org/#/c/26823/1//COMMIT_MSG@16
PS1, Line 16:
Another point (that doesn't affect coreboot) is that we allow nearly arbitrary changes to the framebuffer config without
resetting the whole pipe.
--
To view, visit https://review.coreboot.org/26823
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ff3c17ec7308115de7bf2f2bb9276c2fad41253
Gerrit-Change-Number: 26823
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 10:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No