Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26833 )
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
Patch Set 2: Verified+1
> I wonder if PCH.HDMI doesn't know the bit or if it's just
> implicitly
> DVI (0).
It is implicitly DVI(0). The 2011 PCH datasheet has it at the same offset.
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 04 Jun 2018 14:46:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Nico Huber has posted comments on this change. ( https://review.coreboot.org/26833 )
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/26833/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/26833/2//COMMIT_MSG@7
PS2, Line 7: g45/hw-gfx-gma-gmch-hdmi.adb
"g45 hdmi:" should be enough
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 04 Jun 2018 14:41:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Nico Huber has posted comments on this change. ( https://review.coreboot.org/26833 )
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
Patch Set 2: Code-Review+2
I wonder if PCH.HDMI doesn't know the bit or if it's just implicitly
DVI (0).
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 04 Jun 2018 14:40:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26833
to look at the new patch set (#2).
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
With GMCH_HDMI_MODE_SELECT_HDMI set the controller will be sending
null packets during Vsync. This only works on displays supporting HDMI
operation, while GMCH_HDMI_MODE_SELECT_DVI ought to work on all
HDMI/DVI displays.
Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M common/g45/hw-gfx-gma-gmch-hdmi.adb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/33/26833/2
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/26833
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
GMCH_HDMI_MODE_SELECT_HDMI does not seem to work on all displays.
Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M common/g45/hw-gfx-gma-gmch-hdmi.adb
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/33/26833/1
diff --git a/common/g45/hw-gfx-gma-gmch-hdmi.adb b/common/g45/hw-gfx-gma-gmch-hdmi.adb
index 4c84f36..20df5b2 100644
--- a/common/g45/hw-gfx-gma-gmch-hdmi.adb
+++ b/common/g45/hw-gfx-gma-gmch-hdmi.adb
@@ -59,14 +59,16 @@
GMCH_HDMI_VSYNC_ACTIVE_HIGH else 0);
begin
pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
-
+ -- TODO: GMCH_HDMI_MODE_SELECT_HDMI does not seem to work on all panels.
+ -- Should this be detected or is GMCH_HMDI_MODE_SELECT_DVI fine in all
+ -- case?
Registers.Unset_And_Set_Mask
(Register => GMCH_HDMI (Port_Cfg.Port),
Mask_Unset => GMCH_HDMI_MASK,
Mask_Set => GMCH_HDMI_ENABLE or
GMCH_PORT_PIPE_SELECT (Pipe) or
GMCH_HDMI_SDVO_ENCODING_HDMI or
- GMCH_HDMI_MODE_SELECT_HDMI or
+ GMCH_HDMI_MODE_SELECT_DVI or
Polarity);
end On;
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26832
Change subject: console/hw-debug_sink: Do not cache state of log level
......................................................................
console/hw-debug_sink: Do not cache state of log level
As we suppress output now before console_init() is done, the log level
read at start of ramstage is always -1.
Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/console/hw-debug_sink.adb
1 file changed, 8 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26832/1
diff --git a/src/console/hw-debug_sink.adb b/src/console/hw-debug_sink.adb
index 5a16556..4331b87 100644
--- a/src/console/hw-debug_sink.adb
+++ b/src/console/hw-debug_sink.adb
@@ -19,14 +19,19 @@
package body HW.Debug_Sink is
- Sink_Enabled : Boolean;
+ function console_log_level
+ (msg_level : Interfaces.C.int)
+ return Interfaces.C.int;
+ pragma Import (C, console_log_level, "console_log_level");
+
+ Msg_Level_BIOS_DEBUG : constant := 7;
procedure console_tx_byte (chr : Interfaces.C.char);
pragma Import (C, console_tx_byte, "console_tx_byte");
procedure Put (Item : String) is
begin
- if Sink_Enabled then
+ if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then
for Idx in Item'Range loop
console_tx_byte (Interfaces.C.To_C (Item (Idx)));
end loop;
@@ -35,7 +40,7 @@
procedure Put_Char (Item : Character) is
begin
- if Sink_Enabled then
+ if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then
console_tx_byte (Interfaces.C.To_C (Item));
end if;
end Put_Char;
@@ -45,15 +50,4 @@
Put_Char (Character'Val (16#0a#));
end New_Line;
- ----------------------------------------------------------------------------
-
- function console_log_level
- (msg_level : Interfaces.C.int)
- return Interfaces.C.int;
- pragma Import (C, console_log_level, "console_log_level");
-
- Msg_Level_BIOS_DEBUG : constant := 7;
-
-begin
- Sink_Enabled := console_log_level (Msg_Level_BIOS_DEBUG) /= 0;
end HW.Debug_Sink;
--
To view, visit https://review.coreboot.org/26832
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538
Gerrit-Change-Number: 26832
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>