coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: opencellular/rotundu: Introduce variants for OC
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22924 ) Change subject: opencellular/rotundu: Introduce variants for OC ...................................................................... Patch Set 21: (146 comments) https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… File src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c: https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 60: GPIO_NC, /* GPIO_S0_SC[000] SATA_GP[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 61: GPIO_NC, /* GPIO_S0_SC[001] SATA_GP[1] SATA_DEVSLP[0] - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 62: GPIO_FUNC1, /* GPIO_S0_SC[002] SATA_LED# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 63: GPIO_FUNC1, /* GPIO_S0_SC[003] PCIE_CLKREQ[0]# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 64: GPIO_FUNC1, /* GPIO_S0_SC[004] PCIE_CLKREQ[1]# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 65: GPIO_FUNC1, /* GPIO_S0_SC[005] PCIE_CLKREQ[2]# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 66: GPIO_FUNC1, /* GPIO_S0_SC[006] PCIE_CLKREQ[3]# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 67: GPIO_FUNC2, /* GPIO_S0_SC[007] RESERVED SD3_WP - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 68: GPIO_NC, /* GPIO_S0_SC[008] I2S0_CLK HDA_RST# - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 69: GPIO_NC, /* GPIO_S0_SC[009] I2S0_FRM HDA_SYNC - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 70: GPIO_NC, /* GPIO_S0_SC[010] I2S0_DATAOUT HDA_CLK - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 71: GPIO_NC, /* GPIO_S0_SC[011] I2S0_DATAIN HDA_SDO - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 72: GPIO_NC, /* GPIO_S0_SC[012] I2S1_CLK HDA_SDI[0] - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 73: GPIO_NC, /* GPIO_S0_SC[013] I2S1_FRM HDA_SDI[1] - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 74: GPIO_NC, /* GPIO_S0_SC[014] I2S1_DATAOUT RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 75: GPIO_DEFAULT, /* GPIO_S0_SC[015] I2S1_DATAIN RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 76: GPIO_FUNC3_PULL_DOWN_20K, /* GPIO_S0_SC[016] MMC1_CLK - MMC1_45_CLK - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 77: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[017] MMC1_D[0] - MMC1_45_D[0] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 78: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[018] MMC1_D[1] - MMC1_45_D[1] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 79: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[019] MMC1_D[2] - MMC1_45_D[2] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 80: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[020] MMC1_D[3] - MMC1_45_D[3] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 81: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[021] MMC1_D[4] - MMC1_45_D[4] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 82: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[022] MMC1_D[5] - MMC1_45_D[5] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 83: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[023] MMC1_D[6] - MMC1_45_D[6] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 84: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[024] MMC1_D[7] - MMC1_45_D[7] - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 85: GPIO_FUNC3_PULL_UP_20K, /* GPIO_S0_SC[025] MMC1_CMD - MMC1_45_CMD - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 86: GPIO_FUNC3_PULL_DOWN_20K, /* GPIO_S0_SC[026] MMC1_RST# SATA_DEVSLP[0] MMC1_45_RST# - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 87: GPIO_NC, /* GPIO_S0_SC[027] SD2_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 88: GPIO_NC, /* GPIO_S0_SC[028] SD2_D[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 89: GPIO_NC, /* GPIO_S0_SC[029] SD2_D[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 90: GPIO_NC, /* GPIO_S0_SC[030] SD2_D[2] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 91: GPIO_NC, /* GPIO_S0_SC[031] SD2_D[3]_CD# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 92: GPIO_NC, /* GPIO_S0_SC[032] SD2_CMD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 93: GPIO_NC, /* GPIO_S0_SC[033] SD3_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 94: GPIO_NC, /* GPIO_S0_SC[034] SD3_D[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 95: GPIO_NC, /* GPIO_S0_SC[035] SD3_D[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 96: GPIO_NC, /* GPIO_S0_SC[036] SD3_D[2] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 97: GPIO_NC, /* GPIO_S0_SC[037] SD3_D[3] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 98: GPIO_NC, /* GPIO_S0_SC[038] SD3_CD# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 99: GPIO_NC, /* GPIO_S0_SC[039] SD3_CMD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 100: GPIO_FUNC1, /* GPIO_S0_SC[040] SD3_1P8EN - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 101: GPIO_FUNC1, /* GPIO_S0_SC[041] SD3_PWREN# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 102: GPIO_FUNC1, /* GPIO_S0_SC[042] ILB_LPC_AD[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 103: GPIO_FUNC1, /* GPIO_S0_SC[043] ILB_LPC_AD[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 104: GPIO_FUNC1, /* GPIO_S0_SC[044] ILB_LPC_AD[2] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 105: GPIO_FUNC1, /* GPIO_S0_SC[045] ILB_LPC_AD[3] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 106: GPIO_FUNC1, /* GPIO_S0_SC[046] ILB_LPC_FRAME# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 107: GPIO_FUNC1, /* GPIO_S0_SC[047] ILB_LPC_CLK[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 108: GPIO_NC, /* GPIO_S0_SC[048] ILB_LPC_CLK[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 109: GPIO_FUNC1, /* GPIO_S0_SC[049] ILB_LPC_CLKRUN# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 110: GPIO_FUNC1, /* GPIO_S0_SC[050] ILB_LPC_SERIRQ - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 111: GPIO_FUNC1, /* GPIO_S0_SC[051] PCU_SMB_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 112: GPIO_FUNC1, /* GPIO_S0_SC[052] PCU_SMB_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 113: GPIO_FUNC1, /* GPIO_S0_SC[053] PCU_SMB_ALERT# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 114: GPIO_NC, /* GPIO_S0_SC[054] ILB_8254_SPKR RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 115: GPIO_DEFAULT, /* GPIO_S0_SC[055] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 116: GPIO_DEFAULT, /* GPIO_S0_SC[056] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 117: GPIO_FUNC1, /* GPIO_S0_SC[057] PCU_UART_TXD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 118: GPIO_DEFAULT, /* GPIO_S0_SC[058] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 119: GPIO_DEFAULT, /* GPIO_S0_SC[059] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 120: GPIO_DEFAULT, /* GPIO_S0_SC[060] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 121: GPIO_FUNC1, /* GPIO_S0_SC[061] PCU_UART_RXD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 122: GPIO_NC, /* GPIO_S0_SC[062] LPE_I2S2_CLK SATA_DEVSLP[1] RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 123: GPIO_FUNC1, /* GPIO_S0_SC[063] LPE_I2S2_FRM RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 124: GPIO_NC, /* GPIO_S0_SC[064] LPE_I2S2_DATAIN - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 125: GPIO_FUNC1, /* GPIO_S0_SC[065] LPE_I2S2_DATAOUT - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 126: GPIO_NC, /* GPIO_S0_SC[066] SIO_SPI_CS# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 127: GPIO_NC, /* GPIO_S0_SC[067] SIO_SPI_MISO - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 128: GPIO_NC, /* GPIO_S0_SC[068] SIO_SPI_MOSI - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 129: GPIO_NC, /* GPIO_S0_SC[069] SIO_SPI_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 130: GPIO_FUNC1, /* GPIO_S0_SC[070] SIO_UART1_RXD RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 131: GPIO_FUNC1, /* GPIO_S0_SC[071] SIO_UART1_TXD RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 132: GPIO_NC, /* GPIO_S0_SC[072] SIO_UART1_RTS# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 133: GPIO_DEFAULT, /* GPIO_S0_SC[073] SIO_UART1_CTS# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 134: GPIO_NC, /* GPIO_S0_SC[074] SIO_UART2_RXD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 135: GPIO_NC, /* GPIO_S0_SC[075] SIO_UART2_TXD - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 136: GPIO_NC, /* GPIO_S0_SC[076] SIO_UART2_RTS# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 137: GPIO_NC, /* GPIO_S0_SC[077] SIO_UART2_CTS# - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 138: GPIO_FUNC1, /* GPIO_S0_SC[078] SIO_I2C0_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 139: GPIO_FUNC1, /* GPIO_S0_SC[079] SIO_I2C0_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 140: GPIO_NC, /* GPIO_S0_SC[080] SIO_I2C1_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 141: GPIO_NC, /* GPIO_S0_SC[081] SIO_I2C1_CLK RESERVED - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 142: GPIO_FUNC1, /* GPIO_S0_SC[082] SIO_I2C2_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 143: GPIO_FUNC1, /* GPIO_S0_SC[083] SIO_I2C2_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 144: GPIO_NC, /* GPIO_S0_SC[084] SIO_I2C3_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 145: GPIO_NC, /* GPIO_S0_SC[085] SIO_I2C3_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 146: GPIO_NC, /* GPIO_S0_SC[086] SIO_I2C4_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 147: GPIO_NC, /* GPIO_S0_SC[087] SIO_I2C4_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 148: GPIO_NC, /* GPIO_S0_SC[088] SIO_I2C5_DATA - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 149: GPIO_NC, /* GPIO_S0_SC[089] SIO_I2C5_CLK - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 150: GPIO_NC, /* GPIO_S0_SC[090] SIO_I2C6_DATA ILB_NMI - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 151: GPIO_NC, /* GPIO_S0_SC[091] SIO_I2C6_CLK SD3_WP - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 152: GPIO_NC, /* RESERVED GPIO_S0_SC[092] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 153: GPIO_NC, /* RESERVED GPIO_S0_SC[093] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 154: GPIO_NC, /* GPIO_S0_SC[094] SIO_PWM[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 155: GPIO_NC, /* GPIO_S0_SC[095] SIO_PWM[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 156: GPIO_NC, /* GPIO_S0_SC[096] PMC_PLT_CLK[0] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 157: GPIO_NC, /* GPIO_S0_SC[097] PMC_PLT_CLK[1] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 158: GPIO_NC, /* GPIO_S0_SC[098] PMC_PLT_CLK[2] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 159: GPIO_NC, /* GPIO_S0_SC[099] PMC_PLT_CLK[3] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 160: GPIO_NC, /* GPIO_S0_SC[100] PMC_PLT_CLK[4] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 161: GPIO_NC, /* GPIO_S0_SC[101] PMC_PLT_CLK[5] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 167: GPIO_DEFAULT, /* GPIO_S5[00] RESERVED - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 168: GPIO_NC, /* GPIO_S5[01] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[1]# */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 169: GPIO_DEFAULT, /* GPIO_S5[02] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[2]# */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 170: GPIO_DEFAULT, /* GPIO_S5[03] RESERVED RESERVED RESERVED PMC_WAKE_PCIE[3]# */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 171: GPIO_DEFAULT, /* GPIO_S5[04] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 172: GPIO_DEFAULT, /* GPIO_S5[05] PMC_SUSCLK[1] RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 173: GPIO_DEFAULT, /* GPIO_S5[06] PMC_SUSCLK[2] RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 174: GPIO_DEFAULT, /* GPIO_S5[07] PMC_SUSCLK[3] RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 175: GPIO_DEFAULT, /* GPIO_S5[08] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 176: GPIO_NC, /* GPIO_S5[09] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 177: GPIO_NC, /* GPIO_S5[10] RESERVED RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 178: GPIO_DEFAULT, /* PMC_SUSPWRDNACK GPIO_S5[11] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 179: GPIO_NC, /* PMC_SUSCLK[0] GPIO_S5[12] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 180: GPIO_NC, /* RESERVED GPIO_S5[13] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 181: GPIO_FUNC2, /* RESERVED GPIO_S5[14] USB_ULPI_RST# - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 182: GPIO_FUNC0, /* PMC_WAKE_PCIE[0]# GPIO_S5[15] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 183: GPIO_FUNC0, /* PMC_PWRBTN# GPIO_S5[16] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 184: GPIO_FUNC1, /* RESERVED GPIO_S5[17] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 185: GPIO_FUNC0, /* PMC_SUS_STAT# GPIO_S5[18] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 186: GPIO_FUNC0, /* USB_OC[0]# GPIO_S5[19] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 187: GPIO_FUNC0, /* USB_OC[1]# GPIO_S5[20] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 188: GPIO_NC, /* PCU_SPI_CS[1]# GPIO_S5[21] - - - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 189: GPIO_NC, /* GPIO_S5[22] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 190: GPIO_NC, /* GPIO_S5[23] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 191: GPIO_NC, /* GPIO_S5[24] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 192: GPIO_DEFAULT, /* GPIO_S5[25] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 193: GPIO_NC, /* GPIO_S5[26] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 194: GPIO_NC, /* GPIO_S5[27] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 195: GPIO_NC, /* GPIO_S5[28] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 196: GPIO_NC, /* GPIO_S5[29] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 197: GPIO_NC, /* GPIO_S5[30] RESERVED RESERVED RESERVED RESERVED */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 198: GPIO_FUNC1, /* GPIO_S5[31] USB_ULPI_CLK RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 199: GPIO_NC, /* GPIO_S5[32] USB_ULPI_DATA[0] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 200: GPIO_NC, /* GPIO_S5[33] USB_ULPI_DATA[1] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 201: GPIO_NC, /* GPIO_S5[34] USB_ULPI_DATA[2] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 202: GPIO_NC, /* GPIO_S5[35] USB_ULPI_DATA[3] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 203: GPIO_NC, /* GPIO_S5[36] USB_ULPI_DATA[4] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 204: GPIO_NC, /* GPIO_S5[37] USB_ULPI_DATA[5] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 205: GPIO_NC, /* GPIO_S5[38] USB_ULPI_DATA[6] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 206: GPIO_NC, /* GPIO_S5[39] USB_ULPI_DATA[7] RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 207: GPIO_NC, /* GPIO_S5[40] USB_ULPI_DIR RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 208: GPIO_NC, /* GPIO_S5[41] USB_ULPI_NXT RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 209: GPIO_NC, /* GPIO_S5[42] USB_ULPI_STP RESERVED RESERVED - */ line over 80 characters https://review.coreboot.org/#/c/22924/21/src/mainboard/opencellular/rotundu… PS21, Line 210: GPIO_NC, /* GPIO_S5[43] USB_ULPI_REFCLK RESERVED RESERVED - */ line over 80 characters -- To view, visit https://review.coreboot.org/22924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20e9d4ed7ac071d25a69eee63c9ec544d2ad152 Gerrit-Change-Number: 22924 Gerrit-PatchSet: 21 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Reg Orton <reg(a)brck.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:35:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/driver/i2c/{generic, hid, tpm, max}: Update device name based on dev...
by Naresh Solanki (Code Review) 04 Jun '18

04 Jun '18

Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/26830 Change subject: src/driver/i2c/{generic,hid,tpm,max}: Update device name based on devicetree.cb ...................................................................... src/driver/i2c/{generic,hid,tpm,max}: Update device name based on devicetree.cb Name i2c device structure based on that in devicetree.cb Now log looks like: I2C: 01:0a (WCOM Touchscreen) I2C: 03:13 (Realtek RT5663) I2C: 03:39 (SSM4567 Right Speaker Amp) I2C: 03:3a (SSM4567 Left Speaker Amp) BUG=None BRANCH=None TEST=Build & boot Soraka Change-Id: I5dbb66ab705cd8601b8b1dc94bc6ee9f181b7be2 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/drivers/i2c/generic/generic.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/tpm/chip.c 5 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26830/1 diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 46fff4a..7f1ce16 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -217,6 +217,11 @@ } dev->ops = &i2c_generic_ops; + + /* Name the device as per description provided in devicetree */ + if (config && config->desc) { + dev->name = config->desc; + } } struct chip_operations drivers_i2c_generic_ops = { diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index 71d70d0..bccce75 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -58,7 +58,13 @@ static void i2c_hid_enable(struct device *dev) { + struct drivers_i2c_hid_config *config = dev->chip_info; + dev->ops = &i2c_hid_ops; + + if (config && config->generic.desc) { + dev->name = config->generic.desc; + } } struct chip_operations drivers_i2c_hid_ops = { diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index 19dd787..17c79af 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -97,7 +97,12 @@ static void max98373_enable(struct device *dev) { + struct drivers_i2c_max98373_config *config = dev->chip_info; dev->ops = &max98373_ops; + + if (config && config->desc) { + dev->name = config->desc; + } } struct chip_operations drivers_i2c_max98373_ops = { diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c index 50b3e0c..214121a 100644 --- a/src/drivers/i2c/max98927/max98927.c +++ b/src/drivers/i2c/max98927/max98927.c @@ -93,7 +93,12 @@ static void max98927_enable(struct device *dev) { + struct drivers_i2c_max98927_config *config = dev->chip_info; dev->ops = &max98927_ops; + + if (config && config->desc) { + dev->name = config->desc; + } } struct chip_operations drivers_i2c_max98927_ops = { diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c index 2655b0d..b5ed6cc 100644 --- a/src/drivers/i2c/tpm/chip.c +++ b/src/drivers/i2c/tpm/chip.c @@ -84,7 +84,12 @@ static void i2c_tpm_enable(struct device *dev) { + struct drivers_i2c_tpm_config *config = dev->chip_info; dev->ops = &i2c_tpm_ops; + + if (config && config->desc) { + dev->name = config->desc; + } } struct chip_operations drivers_i2c_tpm_ops = { -- To view, visit https://review.coreboot.org/26830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5dbb66ab705cd8601b8b1dc94bc6ee9f181b7be2 Gerrit-Change-Number: 26830 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74157/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28264/ : SUCCESS -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 12 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:32:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/RFC/config.tex: Remove white space before tab
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26829 ) Change subject: Documentation/RFC/config.tex: Remove white space before tab ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74159/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28267/ : SUCCESS -- To view, visit https://review.coreboot.org/26829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic67a144c6d75097f5a483d73ed802c060825ec8e Gerrit-Change-Number: 26829 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:30:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/pc80/vga: Fix coding style
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26328 ) Change subject: drivers/pc80/vga: Fix coding style ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74158/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28266/ : SUCCESS -- To view, visit https://review.coreboot.org/26328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0452407d1346ca8ead2638e2a31269931ea5d12e Gerrit-Change-Number: 26328 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:25:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/RFC/config.tex: Remove white space before tab
by Elyes HAOUAS (Code Review) 04 Jun '18

04 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26829 Change subject: Documentation/RFC/config.tex: Remove white space before tab ...................................................................... Documentation/RFC/config.tex: Remove white space before tab Change-Id: Ic67a144c6d75097f5a483d73ed802c060825ec8e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Documentation/RFC/config.tex 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/26829/1 diff --git a/Documentation/RFC/config.tex b/Documentation/RFC/config.tex index 97fec9d..c11e622 100644 --- a/Documentation/RFC/config.tex +++ b/Documentation/RFC/config.tex @@ -119,8 +119,8 @@ statement ::= option | default - | cpu - | arch + | cpu + | arch | northbridge | southbridge | superio -- To view, visit https://review.coreboot.org/26829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic67a144c6d75097f5a483d73ed802c060825ec8e Gerrit-Change-Number: 26829 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Fix uncountable "information"
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26593 ) Change subject: drivers/intel/fsp2_0: Fix uncountable "information" ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74156/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28263/ : SUCCESS -- To view, visit https://review.coreboot.org/26593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e13a786b12328f1d9200f76788faa19847bbe7 Gerrit-Change-Number: 26593 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:13:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/pcengines: Remove unneeded includes and fix coding style
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26633 ) Change subject: mb/pcengines: Remove unneeded includes and fix coding style ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74155/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28262/ : SUCCESS -- To view, visit https://review.coreboot.org/26633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id13c0ee284293c0c06d46c75c850bc7e81cfc1f6 Gerrit-Change-Number: 26633 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:09:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: {drivers, nb}/intel: Enable libgfxinit for GM45/X4X
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22222 ) Change subject: {drivers,nb}/intel: Enable libgfxinit for GM45/X4X ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74154/ : SUCCESS -- To view, visit https://review.coreboot.org/22222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia637d32ffaa5d280320955d34141eddc8b7df981 Gerrit-Change-Number: 22222 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 12:00:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/pc80/vga: Fix coding style
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26328 ) Change subject: drivers/pc80/vga: Fix coding style ...................................................................... Patch Set 2: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/28265/ : SUCCESS -- To view, visit https://review.coreboot.org/26328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0452407d1346ca8ead2638e2a31269931ea5d12e Gerrit-Change-Number: 26328 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 11:59:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018