coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: src/ec: Remove whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26662 ) Change subject: src/ec: Remove whitespace before tab ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/26662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib47cc1ee617aae74a8cfbcb25c1d0c083196f417 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:15:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/samsung: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26635 ) Change subject: mb/samsung: Get rid of whitespace before tab ...................................................................... mb/samsung: Get rid of whitespace before tab Change-Id: I0aefe25e3af61c747c06629e365b8e27459181aa Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26635 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/samsung/stumpy/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/mainboard/samsung/stumpy/acpi/superio.asl b/src/mainboard/samsung/stumpy/acpi/superio.asl index c7ce92b..1262211 100644 --- a/src/mainboard/samsung/stumpy/acpi/superio.asl +++ b/src/mainboard/samsung/stumpy/acpi/superio.asl @@ -24,7 +24,7 @@ #define SIO_ENABLE_ENVC // pnp 2e.4: Enable Environmental Controller #define SIO_ENVC_IO0 0x700 // pnp 2e.4: io 0x60 #define SIO_ENVC_IO1 0x710 // pnp 2e.4: io 0x62 -#define SIO_ENABLE_GPIO // pnp 2e.7: Enable GPIO +#define SIO_ENABLE_GPIO // pnp 2e.7: Enable GPIO #define SIO_GPIO_IO0 0x720 // pnp 2e.7: io 0x60 #define SIO_GPIO_IO1 0x730 // pnp 2e.7: io 0x60 -- To view, visit https://review.coreboot.org/26635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0aefe25e3af61c747c06629e365b8e27459181aa Gerrit-Change-Number: 26635 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/samsung: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26635 ) Change subject: mb/samsung: Get rid of whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0aefe25e3af61c747c06629e365b8e27459181aa Gerrit-Change-Number: 26635 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:13:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/cpu: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26648 ) Change subject: src/cpu: Get rid of whitespace before tab ...................................................................... src/cpu: Get rid of whitespace before tab Change-Id: Ic501f5f9e8cd79774eb2a8d8902f01853d746470 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26648 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/cpu/allwinner/a10/twi.h M src/cpu/amd/family_10h-family_15h/defaults.h M src/cpu/amd/microcode/microcode.c M src/cpu/x86/smm/smmrelocate.S 4 files changed, 23 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/cpu/allwinner/a10/twi.h b/src/cpu/allwinner/a10/twi.h index 1a33419..833b1dc 100644 --- a/src/cpu/allwinner/a10/twi.h +++ b/src/cpu/allwinner/a10/twi.h @@ -31,7 +31,7 @@ /* TWI_STAT values */ enum twi_status { - TWI_STAT_BUS_ERROR = 0x00, /**< Bus error */ + TWI_STAT_BUS_ERROR = 0x00, /**< Bus error */ TWI_STAT_TX_START = 0x08, /**< START sent */ TWI_STAT_TX_RSTART = 0x10, /**< Repeated START sent */ TWI_STAT_TX_AW_ACK = 0x18, /**< Sent address+read, ACK */ diff --git a/src/cpu/amd/family_10h-family_15h/defaults.h b/src/cpu/amd/family_10h-family_15h/defaults.h index 88950a3..50b3d07 100644 --- a/src/cpu/amd/family_10h-family_15h/defaults.h +++ b/src/cpu/amd/family_10h-family_15h/defaults.h @@ -523,7 +523,7 @@ /* Errata 281 Workaround */ { 3, 0x144, ( AMD_DR_B0 | AMD_DR_B1), AMD_PTYPE_SVR, 0x00000001, 0x0000000F }, - /* [3:0] RspTok = 0001b */ + /* [3:0] RspTok = 0001b */ { 3, 0x144, AMD_FAM15_ALL, AMD_PTYPE_ALL, 0x00000028, 0x000000ff }, @@ -758,7 +758,7 @@ 0x0000006d, 0x000000ff }, /* HT_PHY_HT1_FIFO_PTR_OPT_VALUE */ { 0xDF, AMD_FAM10_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT1, - 0x0000006d, 0x000000ff }, /* HT_PHY_HT1_FIFO_PTR_OPT_VALUE */ + 0x0000006d, 0x000000ff }, /* HT_PHY_HT1_FIFO_PTR_OPT_VALUE */ /* Link Phy Receiver Loop Filter Registers */ { 0xD1, AMD_FAM10_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT3, @@ -782,28 +782,28 @@ [20:16] RttIndex = 04h */ { 0xCF, AMD_FAM15_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT3, - 0x00000a2a, 0x000000ff }, /* P0RcvRdPtr = 0xa, - P0XmtRdPtr = 0x2 - P1RcvRdPtr = 0xa - P1XmtRdPtr = 0x0 */ + 0x00000a2a, 0x000000ff }, /* P0RcvRdPtr = 0xa, + P0XmtRdPtr = 0x2 + P1RcvRdPtr = 0xa + P1XmtRdPtr = 0x0 */ { 0xDF, AMD_FAM15_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT3, - 0x00000a2a, 0x000000ff }, /* P0RcvRdPtr = 0xa, - P0XmtRdPtr = 0x2 - P1RcvRdPtr = 0xa - P1XmtRdPtr = 0x0 */ + 0x00000a2a, 0x000000ff }, /* P0RcvRdPtr = 0xa, + P0XmtRdPtr = 0x2 + P1RcvRdPtr = 0xa + P1XmtRdPtr = 0x0 */ { 0xCF, AMD_FAM15_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT1, - 0x00000d4d, 0x000000ff }, /* P0RcvRdPtr = 0xd, - P0XmtRdPtr = 0x4 - P1RcvRdPtr = 0xd - P1XmtRdPtr = 0x0 */ + 0x00000d4d, 0x000000ff }, /* P0RcvRdPtr = 0xd, + P0XmtRdPtr = 0x4 + P1RcvRdPtr = 0xd + P1XmtRdPtr = 0x0 */ { 0xDF, AMD_FAM15_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT1, - 0x00000d4d, 0x000000ff }, /* P0RcvRdPtr = 0xd, - P0XmtRdPtr = 0x4 - P1RcvRdPtr = 0xd - P1XmtRdPtr = 0x0 */ + 0x00000d4d, 0x000000ff }, /* P0RcvRdPtr = 0xd, + P0XmtRdPtr = 0x4 + P1RcvRdPtr = 0xd + P1XmtRdPtr = 0x0 */ /* Link Phy Receiver Loop Filter Registers */ { 0xD1, AMD_FAM15_ALL, AMD_PTYPE_ALL, HTPHY_LINKTYPE_HT3, diff --git a/src/cpu/amd/microcode/microcode.c b/src/cpu/amd/microcode/microcode.c index 71ecc01..541d5a8 100644 --- a/src/cpu/amd/microcode/microcode.c +++ b/src/cpu/amd/microcode/microcode.c @@ -30,9 +30,9 @@ #define UCODE_SECTION_START_ID 0x00000001 #define UCODE_MAGIC 0x00414d44 -#define F1XH_MPB_MAX_SIZE 2048 -#define F15H_MPB_MAX_SIZE 4096 -#define CONT_HDR 12 +#define F1XH_MPB_MAX_SIZE 2048 +#define F15H_MPB_MAX_SIZE 4096 +#define CONT_HDR 12 #define SECT_HDR 8 /* diff --git a/src/cpu/x86/smm/smmrelocate.S b/src/cpu/x86/smm/smmrelocate.S index ed556db..56e73cd 100644 --- a/src/cpu/x86/smm/smmrelocate.S +++ b/src/cpu/x86/smm/smmrelocate.S @@ -67,7 +67,7 @@ * * Example (with SMM handler living at 0xa0000): * - * LAPICID SMBASE SMM Entry SAVE STATE + * LAPICID SMBASE SMM Entry SAVE STATE * 0 0xa0000 0xa8000 0xafd00 * 1 0x9fc00 0xa7c00 0xaf900 * 2 0x9f800 0xa7800 0xaf500 -- To view, visit https://review.coreboot.org/26648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic501f5f9e8cd79774eb2a8d8902f01853d746470 Gerrit-Change-Number: 26648 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/cpu: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26648 ) Change subject: src/cpu: Get rid of whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic501f5f9e8cd79774eb2a8d8902f01853d746470 Gerrit-Change-Number: 26648 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:13:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/drivers: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26649 ) Change subject: src/drivers: Get rid of whitespace before tab ...................................................................... src/drivers: Get rid of whitespace before tab Change-Id: Ia9ca055679c0332613afb2bb2ed86df165de3baf Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26649 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/drivers/amd/agesa/acpi_tables.c M src/drivers/aspeed/common/ast_tables.h M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/intel/fsp1_0/fsp_util.c M src/drivers/intel/fsp1_1/cache_as_ram.inc M src/drivers/intel/gma/acpi.c M src/drivers/net/ne2k.c M src/drivers/xgi/common/initdef.h M src/drivers/xgi/common/vstruct.h 9 files changed, 86 insertions(+), 86 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/drivers/amd/agesa/acpi_tables.c b/src/drivers/amd/agesa/acpi_tables.c index 5335c02..2f0cde8 100644 --- a/src/drivers/amd/agesa/acpi_tables.c +++ b/src/drivers/amd/agesa/acpi_tables.c @@ -26,11 +26,11 @@ IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_PI_00630F01) || \ IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_PI_00730F01) -#define HAS_ACPI_SRAT TRUE -#define HAS_ACPI_SLIT TRUE +#define HAS_ACPI_SRAT TRUE +#define HAS_ACPI_SLIT TRUE #else -#define HAS_ACPI_SRAT FALSE -#define HAS_ACPI_SLIT FALSE +#define HAS_ACPI_SRAT FALSE +#define HAS_ACPI_SLIT FALSE #endif /* We will reference AmdLateParams later to copy ACPI tables. */ diff --git a/src/drivers/aspeed/common/ast_tables.h b/src/drivers/aspeed/common/ast_tables.h index 3608d5a..6c20f36 100644 --- a/src/drivers/aspeed/common/ast_tables.h +++ b/src/drivers/aspeed/common/ast_tables.h @@ -49,63 +49,63 @@ #define SyncNN (NVSync | NHSync) /* DCLK Index */ -#define VCLK25_175 0x00 -#define VCLK28_322 0x01 -#define VCLK31_5 0x02 -#define VCLK36 0x03 -#define VCLK40 0x04 -#define VCLK49_5 0x05 -#define VCLK50 0x06 -#define VCLK56_25 0x07 -#define VCLK65 0x08 -#define VCLK75 0x09 -#define VCLK78_75 0x0A -#define VCLK94_5 0x0B -#define VCLK108 0x0C -#define VCLK135 0x0D -#define VCLK157_5 0x0E -#define VCLK162 0x0F -/* #define VCLK193_25 0x10 */ -#define VCLK154 0x10 -#define VCLK83_5 0x11 -#define VCLK106_5 0x12 -#define VCLK146_25 0x13 -#define VCLK148_5 0x14 -#define VCLK71 0x15 -#define VCLK88_75 0x16 -#define VCLK119 0x17 -#define VCLK85_5 0x18 -#define VCLK97_75 0x19 -#define VCLK118_25 0x1A +#define VCLK25_175 0x00 +#define VCLK28_322 0x01 +#define VCLK31_5 0x02 +#define VCLK36 0x03 +#define VCLK40 0x04 +#define VCLK49_5 0x05 +#define VCLK50 0x06 +#define VCLK56_25 0x07 +#define VCLK65 0x08 +#define VCLK75 0x09 +#define VCLK78_75 0x0A +#define VCLK94_5 0x0B +#define VCLK108 0x0C +#define VCLK135 0x0D +#define VCLK157_5 0x0E +#define VCLK162 0x0F +/* #define VCLK193_25 0x10 */ +#define VCLK154 0x10 +#define VCLK83_5 0x11 +#define VCLK106_5 0x12 +#define VCLK146_25 0x13 +#define VCLK148_5 0x14 +#define VCLK71 0x15 +#define VCLK88_75 0x16 +#define VCLK119 0x17 +#define VCLK85_5 0x18 +#define VCLK97_75 0x19 +#define VCLK118_25 0x1A static struct ast_vbios_dclk_info dclk_table[] = { - {0x2C, 0xE7, 0x03}, /* 00: VCLK25_175 */ - {0x95, 0x62, 0x03}, /* 01: VCLK28_322 */ - {0x67, 0x63, 0x01}, /* 02: VCLK31_5 */ - {0x76, 0x63, 0x01}, /* 03: VCLK36 */ - {0xEE, 0x67, 0x01}, /* 04: VCLK40 */ - {0x82, 0x62, 0x01}, /* 05: VCLK49_5 */ - {0xC6, 0x64, 0x01}, /* 06: VCLK50 */ - {0x94, 0x62, 0x01}, /* 07: VCLK56_25 */ - {0x80, 0x64, 0x00}, /* 08: VCLK65 */ - {0x7B, 0x63, 0x00}, /* 09: VCLK75 */ - {0x67, 0x62, 0x00}, /* 0A: VCLK78_75 */ - {0x7C, 0x62, 0x00}, /* 0B: VCLK94_5 */ - {0x8E, 0x62, 0x00}, /* 0C: VCLK108 */ - {0x85, 0x24, 0x00}, /* 0D: VCLK135 */ - {0x67, 0x22, 0x00}, /* 0E: VCLK157_5 */ - {0x6A, 0x22, 0x00}, /* 0F: VCLK162 */ - {0x4d, 0x4c, 0x80}, /* 10: VCLK154 */ - {0xa7, 0x78, 0x80}, /* 11: VCLK83.5 */ - {0x28, 0x49, 0x80}, /* 12: VCLK106.5 */ - {0x37, 0x49, 0x80}, /* 13: VCLK146.25 */ - {0x1f, 0x45, 0x80}, /* 14: VCLK148.5 */ - {0x47, 0x6c, 0x80}, /* 15: VCLK71 */ - {0x25, 0x65, 0x80}, /* 16: VCLK88.75 */ - {0x77, 0x58, 0x80}, /* 17: VCLK119 */ - {0x32, 0x67, 0x80}, /* 18: VCLK85_5 */ - {0x6a, 0x6d, 0x80}, /* 19: VCLK97_75 */ - {0x3b, 0x2c, 0x81}, /* 1A: VCLK118_25 */ + {0x2C, 0xE7, 0x03}, /* 00: VCLK25_175 */ + {0x95, 0x62, 0x03}, /* 01: VCLK28_322 */ + {0x67, 0x63, 0x01}, /* 02: VCLK31_5 */ + {0x76, 0x63, 0x01}, /* 03: VCLK36 */ + {0xEE, 0x67, 0x01}, /* 04: VCLK40 */ + {0x82, 0x62, 0x01}, /* 05: VCLK49_5 */ + {0xC6, 0x64, 0x01}, /* 06: VCLK50 */ + {0x94, 0x62, 0x01}, /* 07: VCLK56_25 */ + {0x80, 0x64, 0x00}, /* 08: VCLK65 */ + {0x7B, 0x63, 0x00}, /* 09: VCLK75 */ + {0x67, 0x62, 0x00}, /* 0A: VCLK78_75 */ + {0x7C, 0x62, 0x00}, /* 0B: VCLK94_5 */ + {0x8E, 0x62, 0x00}, /* 0C: VCLK108 */ + {0x85, 0x24, 0x00}, /* 0D: VCLK135 */ + {0x67, 0x22, 0x00}, /* 0E: VCLK157_5 */ + {0x6A, 0x22, 0x00}, /* 0F: VCLK162 */ + {0x4d, 0x4c, 0x80}, /* 10: VCLK154 */ + {0xa7, 0x78, 0x80}, /* 11: VCLK83.5 */ + {0x28, 0x49, 0x80}, /* 12: VCLK106.5 */ + {0x37, 0x49, 0x80}, /* 13: VCLK146.25 */ + {0x1f, 0x45, 0x80}, /* 14: VCLK148.5 */ + {0x47, 0x6c, 0x80}, /* 15: VCLK71 */ + {0x25, 0x65, 0x80}, /* 16: VCLK88.75 */ + {0x77, 0x58, 0x80}, /* 17: VCLK119 */ + {0x32, 0x67, 0x80}, /* 18: VCLK85_5 */ + {0x6a, 0x6d, 0x80}, /* 19: VCLK97_75 */ + {0x3b, 0x2c, 0x81}, /* 1A: VCLK118_25 */ }; static struct ast_vbios_stdtable vbios_stdtable[] = { @@ -188,14 +188,14 @@ (SyncNN | HBorder | VBorder | Charx8Dot), 72, 2, 0x2E }, { 840, 640, 16, 64, 500, 480, 1, 3, VCLK31_5, /* 75Hz */ (SyncNN | Charx8Dot) , 75, 3, 0x2E }, - { 832, 640, 56, 56, 509, 480, 1, 3, VCLK36, /* 85Hz */ + { 832, 640, 56, 56, 509, 480, 1, 3, VCLK36, /* 85Hz */ (SyncNN | Charx8Dot) , 85, 4, 0x2E }, - { 832, 640, 56, 56, 509, 480, 1, 3, VCLK36, /* end */ + { 832, 640, 56, 56, 509, 480, 1, 3, VCLK36, /* end */ (SyncNN | Charx8Dot) , 0xFF, 4, 0x2E }, }; static struct ast_vbios_enhtable res_800x600[] = { - {1024, 800, 24, 72, 625, 600, 1, 2, VCLK36, /* 56Hz */ + {1024, 800, 24, 72, 625, 600, 1, 2, VCLK36, /* 56Hz */ (SyncPP | Charx8Dot), 56, 1, 0x30 }, {1056, 800, 40, 128, 628, 600, 1, 4, VCLK40, /* 60Hz */ (SyncPP | Charx8Dot), 60, 2, 0x30 }, @@ -268,7 +268,7 @@ /* 16:10 */ static struct ast_vbios_enhtable res_1280x800[] = { - {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz RB */ + {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz RB */ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 0x35 }, {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz */ (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 2, 0x35 }, @@ -287,7 +287,7 @@ }; static struct ast_vbios_enhtable res_1680x1050[] = { - {1840, 1680, 48, 32, 1080, 1050, 3, 6, VCLK119, /* 60Hz RB */ + {1840, 1680, 48, 32, 1080, 1050, 3, 6, VCLK119, /* 60Hz RB */ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 0x37 }, {2240, 1680,104,176, 1089, 1050, 3, 6, VCLK146_25, /* 60Hz */ (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 2, 0x37 }, @@ -296,7 +296,7 @@ }; static struct ast_vbios_enhtable res_1920x1200[] = { - {2080, 1920, 48, 32, 1235, 1200, 3, 6, VCLK154, /* 60Hz RB*/ + {2080, 1920, 48, 32, 1235, 1200, 3, 6, VCLK154, /* 60Hz RB*/ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 0x34 }, {2080, 1920, 48, 32, 1235, 1200, 3, 6, VCLK154, /* 60Hz RB */ (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 0xFF, 1, 0x34 }, diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index cbaf8cf..6120981 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -85,7 +85,7 @@ acpi_dp_add_string(dsd, "compatible", drv_string); if (config->is_polled) acpi_dp_add_integer(dsd, "poll-interval", - config->poll_interval); + config->poll_interval); /* Child device defining key */ child = gpio_keys_add_child_node(config, path); if (child) @@ -112,8 +112,8 @@ static struct device_operations gpio_keys_ops = { .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .acpi_name = &gpio_keys_acpi_name, .acpi_fill_ssdt_generator = &gpio_keys_fill_ssdt_generator, }; diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c index 17b2fd4..5a6321d 100644 --- a/src/drivers/intel/fsp1_0/fsp_util.c +++ b/src/drivers/intel/fsp1_0/fsp_util.c @@ -113,7 +113,7 @@ ); #else volatile u8 *fsp_ptr; -#endif /* __PRE_RAM__ */ +#endif /* __PRE_RAM__ */ /* The FSP is stored in CBFS */ fsp_ptr = (u8 *) CONFIG_FSP_LOC; diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.inc b/src/drivers/intel/fsp1_1/cache_as_ram.inc index fc66208..af6f3a9 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.inc +++ b/src/drivers/intel/fsp1_1/cache_as_ram.inc @@ -131,7 +131,7 @@ movd %mm1, %eax pushl %eax /* tsc[63:32] */ movd %mm0, %eax - pushl %eax /* tsc[31:0] */ + pushl %eax /* tsc[31:0] */ pushl %esp /* pointer to cache_as_ram_params */ /* Save FSP_INFO_HEADER location in ebx */ diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index f62e8ee..65117aa 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -72,7 +72,7 @@ /* Method (_BCL, 0, NotSerialized) { - Return (^^XBCL()) + Return (^^XBCL()) } */ acpigen_write_method("_BCL", 0); @@ -83,7 +83,7 @@ /* Method (_BCM, 1, NotSerialized) { - ^^XBCM(Arg0) + ^^XBCM(Arg0) } */ acpigen_write_method("_BCM", 1); @@ -94,7 +94,7 @@ /* Method (_BQC, 0, NotSerialized) { - Return (^^XBQC()) + Return (^^XBQC()) } */ acpigen_write_method("_BQC", 0); diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index bec1d78..9614296 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -437,7 +437,7 @@ res->gran = 5; res->limit = res->base + res->size - 1; res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_STORED | - IORESOURCE_ASSIGNED; + IORESOURCE_ASSIGNED; return; } diff --git a/src/drivers/xgi/common/initdef.h b/src/drivers/xgi/common/initdef.h index 0195757..e164e6b 100644 --- a/src/drivers/xgi/common/initdef.h +++ b/src/drivers/xgi/common/initdef.h @@ -42,7 +42,7 @@ * * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF * * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * - * Author: Thomas Winischhofer <thomas(a)winischhofer.net> + * Author: Thomas Winischhofer <thomas(a)winischhofer.net> * */ @@ -80,7 +80,7 @@ #define VB_SIS307T 0x0080 #define VB_SIS307LV 0x0100 #define VB_UMC 0x4000 -#define VB_NoLCD 0x8000 +#define VB_NoLCD 0x8000 #define VB_SIS30xB (VB_SIS301B | VB_SIS301C | VB_SIS302B | VB_SIS307T) #define VB_SIS30xC (VB_SIS301C | VB_SIS307T) #define VB_SISTMDS (VB_SIS301 | VB_SIS301B | VB_SIS301C | VB_SIS302B | VB_SIS307T) @@ -110,10 +110,10 @@ #define SetCRT2ToSCART 0x0010 #define SetCRT2ToLCD 0x0020 #define SetCRT2ToRAMDAC 0x0040 -#define SetCRT2ToHiVision 0x0080 /* for SiS bridge */ -#define SetCRT2ToCHYPbPr SetCRT2ToHiVision /* for Chrontel */ +#define SetCRT2ToHiVision 0x0080 /* for SiS bridge */ +#define SetCRT2ToCHYPbPr SetCRT2ToHiVision /* for Chrontel */ #define SetNTSCTV 0x0000 /* CR 31 */ -#define SetPALTV 0x0100 /* Deprecated here, now in TVMode */ +#define SetPALTV 0x0100 /* Deprecated here, now in TVMode */ #define SetInSlaveMode 0x0200 #define SetNotSimuMode 0x0400 #define SetNotSimuTVMode SetNotSimuMode @@ -128,7 +128,7 @@ /* v-- Needs change in sis_vga.c if changed (GPIO) --v */ #define SetCRT2ToTV (SetCRT2ToYPbPr525750|SetCRT2ToHiVision|SetCRT2ToSCART|SetCRT2ToSVIDEO|SetCRT2ToAVIDEO) #define SetCRT2ToTVNoYPbPrHiVision (SetCRT2ToSCART | SetCRT2ToSVIDEO | SetCRT2ToAVIDEO) -#define SetCRT2ToTVNoHiVision (SetCRT2ToYPbPr525750 | SetCRT2ToSCART | SetCRT2ToSVIDEO | SetCRT2ToAVIDEO) +#define SetCRT2ToTVNoHiVision (SetCRT2ToYPbPr525750 | SetCRT2ToSCART | SetCRT2ToSVIDEO | SetCRT2ToAVIDEO) /* SiS_ModeType */ #define ModeText 0x00 @@ -159,7 +159,7 @@ /* Infoflag */ #define SupportTV 0x0008 #define SupportTV1024 0x0800 -#define SupportCHTV 0x0800 +#define SupportCHTV 0x0800 #define Support64048060Hz 0x0800 /* Special for 640x480 LCD */ #define SupportHiVision 0x0010 #define SupportYPbPr750p 0x1000 @@ -297,7 +297,7 @@ #define LCDSyncShift 6 /* CR38 (315 series) */ -#define EnableDualEdge 0x01 +#define EnableDualEdge 0x01 #define SetToLCDA 0x02 /* LCD channel A (301C/302B/30x(E)LV and 650+LVDS only) */ #define EnableCHScart 0x04 /* Scart on Ch7019 (unofficial definition - TW) */ #define EnableCHYPbPr 0x08 /* YPbPr on Ch7019 (480i HDTV); only on 650/Ch7019 systems */ @@ -605,7 +605,7 @@ #define _PanelType0E 0x70 #define _PanelType0F 0x78 -#define PRIMARY_VGA 0 /* 1: SiS is primary vga 0:SiS is secondary vga */ +#define PRIMARY_VGA 0 /* 1: SiS is primary vga 0:SiS is secondary vga */ #define BIOSIDCodeAddr 0x235 /* Offsets to ptrs in BIOS image */ #define OEMUtilIDCodeAddr 0x237 @@ -650,7 +650,7 @@ /* ============================================================= - for 315 series (old data layout) + for 315 series (old data layout) ============================================================= */ #define SoftDRAMType 0x80 diff --git a/src/drivers/xgi/common/vstruct.h b/src/drivers/xgi/common/vstruct.h index d14a182..3e530a2 100644 --- a/src/drivers/xgi/common/vstruct.h +++ b/src/drivers/xgi/common/vstruct.h @@ -42,7 +42,7 @@ * * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF * * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * - * Author: Thomas Winischhofer <thomas(a)winischhofer.net> + * Author: Thomas Winischhofer <thomas(a)winischhofer.net> * */ @@ -230,7 +230,7 @@ unsigned char ChipType; unsigned char ChipRevision; void *ivideo; - unsigned char *VirtualRomBase; + unsigned char *VirtualRomBase; bool UseROM; unsigned char SISIOMEMTYPE *VideoMemoryAddress; unsigned int VideoMemorySize; -- To view, visit https://review.coreboot.org/26649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia9ca055679c0332613afb2bb2ed86df165de3baf Gerrit-Change-Number: 26649 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/drivers: Get rid of whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26649 ) Change subject: src/drivers: Get rid of whitespace before tab ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/26649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ca055679c0332613afb2bb2ed86df165de3baf Gerrit-Change-Number: 26649 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:12:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/superio/{ite, smsc}: Remove space before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26650 ) Change subject: src/superio/{ite,smsc}: Remove space before tab ...................................................................... src/superio/{ite,smsc}: Remove space before tab Change-Id: I2829e4cb1445f8412f57da10fda6b92c92e56ea0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26650 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/superio/ite/common/env_ctrl.h M src/superio/smsc/lpc47n217/superio.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/superio/ite/common/env_ctrl.h b/src/superio/ite/common/env_ctrl.h index 020f383..11316db 100644 --- a/src/superio/ite/common/env_ctrl.h +++ b/src/superio/ite/common/env_ctrl.h @@ -77,7 +77,7 @@ #define ITE_EC_FAN_CTL_PWM_MODE_AUTOMATIC (1 << 7) #define ITE_EC_FAN_CTL_PWM_DUTY_MASK (ITE_EC_FAN_MAX_PWM << 0) #define ITE_EC_FAN_CTL_PWM_DUTY(p) \ - ({ \ + ({ \ const unsigned int _p = p; \ (_p >= 100) \ ? ITE_EC_FAN_MAX_PWM \ diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c index 9c5dff0..43b56dc 100644 --- a/src/superio/smsc/lpc47n217/superio.c +++ b/src/superio/smsc/lpc47n217/superio.c @@ -91,7 +91,7 @@ for (res = dev->resource_list; res; res = res->next) lpc47n217_pnp_set_resource(dev, res); /* dump_pnp_device(dev); */ - pnp_exit_conf_state(dev); + pnp_exit_conf_state(dev); } /* -- To view, visit https://review.coreboot.org/26650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2829e4cb1445f8412f57da10fda6b92c92e56ea0 Gerrit-Change-Number: 26650 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/superio/{ite, smsc}: Remove space before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26650 ) Change subject: src/superio/{ite,smsc}: Remove space before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2829e4cb1445f8412f57da10fda6b92c92e56ea0 Gerrit-Change-Number: 26650 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:11:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/superiotool: Remove whitespace before tab
by Patrick Georgi (Code Review) 04 Jun '18

04 Jun '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26668 ) Change subject: util/superiotool: Remove whitespace before tab ...................................................................... util/superiotool: Remove whitespace before tab Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/26668 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/superiotool/Makefile M util/superiotool/smsc.c M util/superiotool/superiotool.h M util/superiotool/winbond.c 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index f05e1f9..cedd631 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -104,7 +104,7 @@ @printf "\nChecking for pciutils and zlib... " @echo "$$LIBPCI_TEST" > .test.c @$(CC) $(CFLAGS) .test.c -o .test $(LIBS) >/dev/null 2>&1 && \ - printf "found.\n" || ( printf "not found.\n\n"; \ + printf "found.\n" || ( printf "not found.\n\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "See README for more information.\n\n"; \ rm -f .test.c .test; exit 1) diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 640f438..21763ec 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -20,8 +20,8 @@ #define DEVICE_ID_REG_OLD 0x0d #define DEVICE_REV_REG_OLD 0x0e -#define DEVICE_ID_REG 0x20 -#define DEVICE_REV_REG 0x21 +#define DEVICE_ID_REG 0x20 +#define DEVICE_REV_REG 0x21 static const struct superio_registers reg_table[] = { /* The following Super I/Os use the 0x20/0x21 ID registers. */ diff --git a/util/superiotool/superiotool.h b/util/superiotool/superiotool.h index 01237a5..ed7beae 100644 --- a/util/superiotool/superiotool.h +++ b/util/superiotool/superiotool.h @@ -133,7 +133,7 @@ #define MAXLDN 0x14 /* Biggest LDN */ #define LDNSIZE (MAXLDN + 3) /* Biggest LDN + 0 + NOLDN + EOT */ #define MAXNUMIDX 170 /* Maximum number of indices */ -#define IDXSIZE (MAXNUMIDX + 1) +#define IDXSIZE (MAXNUMIDX + 1) #define MAXNUMPORTS (6 + 1) /* Maximum number of Super I/O ports */ /* Select registers for various components. */ diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c index 281c179..fce860d 100644 --- a/util/superiotool/winbond.c +++ b/util/superiotool/winbond.c @@ -229,8 +229,8 @@ {0x00,0x48,0x48,0x48,0x48,0x00,0x00,0x48,0x00,0x00, EOT}}, {EOT}}}, - {0xa23, "W83627UHG = NCT6627UD", { /* TODO: Not yet in sensors-detect */ - {NOLDN, NULL, /* CR2B (485) is only valid for chip rev.E */ + {0xa23, "W83627UHG = NCT6627UD", { /* TODO: Not yet in sensors-detect */ + {NOLDN, NULL, /* CR2B (485) is only valid for chip rev.E */ {0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28, 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, {0x00,0xa2,NANA,0xff,0xF0,MISC,0x00,MISC,RSVD,0x00, -- To view, visit https://review.coreboot.org/26668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie79cfb92cfb8b8f628aa4b12bba946b0479fc466 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018