Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26629 )
Change subject: mb/kontron: Get rid of whitespace before tab
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/26629
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335dda11d0c1ee58bd2728580c48c41cef574654
Gerrit-Change-Number: 26629
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 09:03:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26628 )
Change subject: mb/jetway: Get rid of whitespace before tab
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc7d7fee38e41f4bfda685fd42bf504a788b440c
Gerrit-Change-Number: 26628
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 09:03:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26626 )
Change subject: mb/intel: Get rid of whitespace before tab
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/26626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I891b056b64fde27ef0e351f8cf24a258fb5cabfa
Gerrit-Change-Number: 26626
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 09:03:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26625 )
Change subject: mb/iei: Get rid of whitespace before tab
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26625
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I750ec788b7526ee2a7aa803bffb93805cedfb2ff
Gerrit-Change-Number: 26625
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 09:02:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25414 )
Change subject: src/sb/intel/common/spi.c: Adapt and link in romstage
......................................................................
Patch Set 4: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74139/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28250/ : SUCCESS
--
To view, visit https://review.coreboot.org/25414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4671653c0b07ab5c4bf91128f18f142ce4f893cf
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 08:54:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23358 )
Change subject: sb/intel/i82801gx: Add the option to lock the platform
......................................................................
Patch Set 5: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74140/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28251/ : SUCCESS
--
To view, visit https://review.coreboot.org/23358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c3a6118f4586d51c093edec896c347ba904b8f
Gerrit-Change-Number: 23358
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 08:51:21 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25414 )
Change subject: src/sb/intel/common/spi.c: Adapt and link in romstage
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c@…
PS4, Line 324: car_set_var(g_ichspi_lock, readw_(&ich7_spi->spis) & HSFS_FLOCKDN);
line over 80 characters
https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c@…
PS4, Line 964: writel_ (0x1000, &cntlr->ich9_spi->fdoc);
space prohibited between function name and open parenthesis '('
--
To view, visit https://review.coreboot.org/25414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4671653c0b07ab5c4bf91128f18f142ce4f893cf
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 08:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No