coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: src/northbridge: Remove whitespace before tab
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26603 ) Change subject: src/northbridge: Remove whitespace before tab ...................................................................... Patch Set 9: (14 comments) https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/agesa/family14/… File src/northbridge/amd/agesa/family14/chip.h: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/agesa/family14/… PS9, Line 30: * { {0x00, 0x00}, {0x00, 0x00}, }, // socket 1 - Channel 0 & 1 (Unused) line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdht/h3gtopo.h File src/northbridge/amd/amdht/h3gtopo.h: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdht/h3gtopo.h… PS9, Line 259: 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x10, 0xFF // Node6 line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/amddefs.h File src/northbridge/amd/amdmct/amddefs.h: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/amddefs.… PS9, Line 77: #define AMD_DA_Cx (AMD_DA_C2 | AMD_DA_C3) please, no space before tabs https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mct_… File src/northbridge/amd/amdmct/mct/mct_d.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mct_… PS9, Line 3756: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mctd… File src/northbridge/amd/amdmct/mct/mctdqs_d.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mctd… PS9, Line 464: BanksPresent = 1; /* flag for at least one bank is present */ line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… File src/northbridge/amd/amdmct/mct_ddr3/mct_d.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… PS9, Line 7912: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… File src/northbridge/amd/amdmct/mct_ddr3/mctecc_d.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… PS9, Line 118: OB_ChipKill = mctGet_NVbits(NV_ChipKill); /* ECC Chip-kill mode */ line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… PS9, Line 123: /* mct_AdjustScrub_D(pDCTstatA, &nvbits); */ /* Need not adjust */ line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3… PS9, Line 699: // wrmsr_uint64_t(0x00000260 | (i + 8), data->msr0000026[i]); line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/northbridgei… File src/northbridge/amd/lx/northbridgeinit.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/northbridgei… PS9, Line 597: * SYSRC(7:0) = 00h ; writeback, can set to 08h to make writethrough line over 80 characters https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c File src/northbridge/amd/lx/raminit.c: https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@422 PS9, Line 422: ((dimm_setting >> CF8F_LOWER_PRE2ACT_SHIFT) & 0x07)) code indent should use tabs where possible https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@422 PS9, Line 422: ((dimm_setting >> CF8F_LOWER_PRE2ACT_SHIFT) & 0x07)) please, no space before tabs https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@423 PS9, Line 423: << CF8F_LOWER_ACT2ACTREF_SHIFT; code indent should use tabs where possible https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@423 PS9, Line 423: << CF8F_LOWER_ACT2ACTREF_SHIFT; please, no space before tabs -- To view, visit https://review.coreboot.org/26603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf13c08129c71372e9870159bbe0a1b86af93935 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 10:39:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in libgfxinit[master]: gma pipe setup: Add missing `pragma Debug`
by Nico Huber (Code Review) 06 Jun '18

06 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26884 Change subject: gma pipe setup: Add missing `pragma Debug` ...................................................................... gma pipe setup: Add missing `pragma Debug` We should keep the core functionality free of `HW.Debug`. Change-Id: Id5fd31b137f5a9da99dc18bcb21535ddfbaf264a Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/hw-gfx-gma-pipe_setup.adb 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/84/26884/1 diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index d62475e..50b63e5 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -567,7 +567,8 @@ (Register => Registers.GMCH_PFIT_CONTROL, Value => PF_CTRL_ENABLE or PF_Ctrl_Pipe_Sel or PF_Ctrl_Scaling); else - Debug.Put_Line ("GMCH Pannel fitter already in use, skipping..."); + pragma Debug (Debug.Put_Line + ("GMCH Pannel fitter already in use, skipping...")); end if; end Setup_Gmch_Panel_Fitter; -- To view, visit https://review.coreboot.org/26884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id5fd31b137f5a9da99dc18bcb21535ddfbaf264a Gerrit-Change-Number: 26884 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: nb/intel/fsp_rangeley: Use MSR_PLATFORM_INFO instead of 0xce
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22957 ) Change subject: nb/intel/fsp_rangeley: Use MSR_PLATFORM_INFO instead of 0xce ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74389/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28507/ : SUCCESS -- To view, visit https://review.coreboot.org/22957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8aa43b6545482bc7fc136a90c4bbaa18d46089 Gerrit-Change-Number: 22957 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 10:25:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/haswell: Always locate mrc.bin in the COREBOOT fmap region
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26883 ) Change subject: nb/intel/haswell: Always locate mrc.bin in the COREBOOT fmap region ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74387/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28505/ : SUCCESS -- To view, visit https://review.coreboot.org/26883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia73d468ab23932f92331ef40b8e8066cef55af2c Gerrit-Change-Number: 26883 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 09:05:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: vboot: Fix linking error
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26863 ) Change subject: vboot: Fix linking error ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74388/ : SUCCESS -- To view, visit https://review.coreboot.org/26863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5 Gerrit-Change-Number: 26863 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 09:01:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vboot: Fix linking error
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26863 ) Change subject: vboot: Fix linking error ...................................................................... Patch Set 2: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/28506/ : SUCCESS -- To view, visit https://review.coreboot.org/26863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5 Gerrit-Change-Number: 26863 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 08:55:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74386/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28504/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 08:45:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/haswell: Always locate mrc.bin in the COREBOOT fmap region
by Arthur Heymans (Code Review) 06 Jun '18

06 Jun '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/26883 Change subject: nb/intel/haswell: Always locate mrc.bin in the COREBOOT fmap region ...................................................................... nb/intel/haswell: Always locate mrc.bin in the COREBOOT fmap region This binary needs to be at a specific offset and will therefore always be located in the COREBOOT fmap region. This will be useful with C_ENVIRONMENT_BOOTBLOCK where romstages in FW_MAIN_x will still need the same binary. Change-Id: Ia73d468ab23932f92331ef40b8e8066cef55af2c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/haswell/Kconfig M src/northbridge/intel/haswell/raminit.c 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/26883/1 diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index 3a47195..692744b 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -84,4 +84,9 @@ VBIOS. On those systems we need to wait for a bit before executing the VBIOS. +config RO_REGION_ONLY + string + depends on CHROMEOS + default "mrc.bin" + endif diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index e5e2b93..cdbb1a9 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -120,6 +120,9 @@ void sdram_initialize(struct pei_data *pei_data) { unsigned long entry; + uint32_t type = CBFS_TYPE_MRC; + struct cbfsf f; + size_t fsize; printk(BIOS_DEBUG, "Starting UEFI PEI System Agent\n"); @@ -142,9 +145,14 @@ /* Pass console handler in pei_data */ pei_data->tx_byte = do_putchar; - /* Locate and call UEFI System Agent binary. */ - entry = (unsigned long)cbfs_boot_map_with_leak("mrc.bin", - CBFS_TYPE_MRC, NULL); + /* + * Locate and call UEFI System Agent binary. The binary needs to be at + * a fixed offset in the flash and can therefore only reside in the + * COREBOOT fmap region + */ + cbfs_locate_file_in_region(&f, "COREBOOT", "mrc.bin", &type); + fsize = region_device_sz(&f.data); + entry = (unsigned long)rdev_mmap(&f.data, 0, fsize); if (entry) { int rv; asm volatile ( -- To view, visit https://review.coreboot.org/26883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia73d468ab23932f92331ef40b8e8066cef55af2c Gerrit-Change-Number: 26883 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: soc/intel/{apollolake, geminilake}: Rectify GSPI device name
by Subrata Banik (Code Review) 06 Jun '18

06 Jun '18

Subrata Banik has abandoned this change. ( https://review.coreboot.org/26882 ) Change subject: soc/intel/{apollolake, geminilake}: Rectify GSPI device name ...................................................................... Abandoned i believe first documentation need to be fixed before this CL goes. APL and GLK EDS are not in sync in terms of explaining the nomenclature between SPI and GSPI According to the EDS, SPI 0(19.0), SPI 1(19.1) and SPI 2(19.2). -- To view, visit https://review.coreboot.org/26882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Iff540eefa5e93b8ad86916745705b48e99cc6767 Gerrit-Change-Number: 26882 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cbfstool: Show current FMAP region in print
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26862 ) Change subject: cbfstool: Show current FMAP region in print ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74385/ : SUCCESS -- To view, visit https://review.coreboot.org/26862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6f29ebeda8a9bde6dfe39362e0f2a5e33c86b26 Gerrit-Change-Number: 26862 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 07:49:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018