Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26885 )
Change subject: Documentation/releases: Add W530 mainboard to 4.9 relnotes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26885
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9651b24dd68f9a5e324a4532c3cebac32aacca7e
Gerrit-Change-Number: 26885
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:05:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26833 )
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................
g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
With GMCH_HDMI_MODE_SELECT_HDMI set the controller will be sending
null packets during Vsync. This only works on displays supporting HDMI
operation, while GMCH_HDMI_MODE_SELECT_DVI ought to work on all
HDMI/DVI displays.
Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-on: https://review.coreboot.org/26833
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M common/g45/hw-gfx-gma-gmch-hdmi.adb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Arthur Heymans: Verified
Nico Huber: Looks good to me, approved
diff --git a/common/g45/hw-gfx-gma-gmch-hdmi.adb b/common/g45/hw-gfx-gma-gmch-hdmi.adb
index 4c84f36..3e34c52 100644
--- a/common/g45/hw-gfx-gma-gmch-hdmi.adb
+++ b/common/g45/hw-gfx-gma-gmch-hdmi.adb
@@ -66,7 +66,7 @@
Mask_Set => GMCH_HDMI_ENABLE or
GMCH_PORT_PIPE_SELECT (Pipe) or
GMCH_HDMI_SDVO_ENCODING_HDMI or
- GMCH_HDMI_MODE_SELECT_HDMI or
+ GMCH_HDMI_MODE_SELECT_DVI or
Polarity);
end On;
--
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Hello Martin Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/26886
to review the following change.
Change subject: Documentation/release: Add some of the things we added since 4.8.1
......................................................................
Documentation/release: Add some of the things we added since 4.8.1
From here on, changes should directly touch the release notes, but these
are notable, too.
Change-Id: I602d67f8dd38391663094212cdb4609cdad458ee
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
---
M Documentation/releases/coreboot-4.9-relnotes.md
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/26886/1
diff --git a/Documentation/releases/coreboot-4.9-relnotes.md b/Documentation/releases/coreboot-4.9-relnotes.md
index 788d695..c484b32 100644
--- a/Documentation/releases/coreboot-4.9-relnotes.md
+++ b/Documentation/releases/coreboot-4.9-relnotes.md
@@ -16,6 +16,13 @@
General changes
---------------
+* Various code cleanups
+ * Removed `device_t` in favor of `struct device*` in ramstage code
+ * Improve adherence to coding style
+* Expand use of the postcar stage
+* Add bootblock compression capability: on systems that copy the bootblock
+ from very slow flash to ERAM, allow adding a stub that decompresses the
+ bootblock into ERAM to minimize the amount of flash reads
Toolchain
---------
--
To view, visit https://review.coreboot.org/26886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I602d67f8dd38391663094212cdb4609cdad458ee
Gerrit-Change-Number: 26886
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>