build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26888 )
Change subject: [WIP]sb/intel/common/spi: Add method to probe protected regions
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@…
PS1, Line 1026: if (IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX)) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@…
PS1, Line 1068: if (range_entry_base(entry) <= start &&
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/26888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40812eacba552d9c24790942fc5612b4836238f3
Gerrit-Change-Number: 26888
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26699 )
Change subject: util/docker/docs.coreboot.org: Downgrade sphinx
......................................................................
Patch Set 2: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74397/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28515/ : SUCCESS
--
To view, visit https://review.coreboot.org/26699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec
Gerrit-Change-Number: 26699
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:36:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/26886 )
Change subject: Documentation/release: Add some of the things we added since 4.8.1
......................................................................
Patch Set 1:
can be added :
Move find_dev_path() to device_const.c ?
--
To view, visit https://review.coreboot.org/26886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I602d67f8dd38391663094212cdb4609cdad458ee
Gerrit-Change-Number: 26886
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:13:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26886 )
Change subject: Documentation/release: Add some of the things we added since 4.8.1
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74395/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28513/ : SUCCESS
--
To view, visit https://review.coreboot.org/26886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I602d67f8dd38391663094212cdb4609cdad458ee
Gerrit-Change-Number: 26886
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:11:39 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/26886 )
Change subject: Documentation/release: Add some of the things we added since 4.8.1
......................................................................
Patch Set 1:
nb & sb: Add and update license headers
--
To view, visit https://review.coreboot.org/26886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I602d67f8dd38391663094212cdb4609cdad458ee
Gerrit-Change-Number: 26886
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:09:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No