Martin Roth has uploaded this change for review. ( https://review.coreboot.org/26878
Change subject: Makefile.inc: Skip -fconserve-stack flag if running scan-build
......................................................................
Makefile.inc: Skip -fconserve-stack flag if running scan-build
Scan-build refuses to run if the -fconserve-stack flag is added to
cflags. It fails with the cryptic message "could not find clang line".
Change-Id: Ib1b56ef7d217138a1a195fe993d8e8dd965bd855
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
---
M Makefile.inc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/26878/1
diff --git a/Makefile.inc b/Makefile.inc
index ec086b9..b7c4904 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -395,7 +395,11 @@
CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
ifeq ($(CONFIG_COMPILER_GCC),y)
-CFLAGS_common += -fno-delete-null-pointer-checks -fconserve-stack
+CFLAGS_common += -fno-delete-null-pointer-checks
+# Don't add these GCC specific flags when running scan-build
+ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),)
+CFLAGS_common += -fconserve-stack
+endif
endif
ADAFLAGS_common += -gnatp
--
To view, visit https://review.coreboot.org/26878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1b56ef7d217138a1a195fe993d8e8dd965bd855
Gerrit-Change-Number: 26878
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/26876
Change subject: mb/google/poppy/variants/nami: Disable rear camera/DMIC for Sona
......................................................................
mb/google/poppy/variants/nami: Disable rear camera/DMIC for Sona
Since there are two cameras on Nami and only one camera on Sona.
We need to disable rear camera/DMIC on all Sona sku.
BUG=b:109710674
BRANCH=master
TEST=Verify if only front camera/DMIC shown on Sona
Change-Id: Id84ee22c9ffc15db78be3bbad148af5cd7dc866e
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
M src/mainboard/google/poppy/variants/nami/include/variant/sku.h
M src/mainboard/google/poppy/variants/nami/mainboard.c
3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/26876/1
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 1e99dab..6755be7 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -407,6 +407,8 @@
case SKU_0_PANTHEON:
case SKU_1_PANTHEON:
case SKU_2_PANTHEON:
+ case SKU_0_SONA:
+ case SKU_1_SONA:
*num = ARRAY_SIZE(vayne_sku_gpio_table);
board_gpio_tables = vayne_sku_gpio_table;
break;
diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
index a2c9c49..15fbcee 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
@@ -24,5 +24,7 @@
#define SKU_0_PANTHEON 0x3F63
#define SKU_1_PANTHEON 0x3F67
#define SKU_2_PANTHEON 0x3F62
+#define SKU_0_SONA 0x3AE2
+#define SKU_1_SONA 0x3AE3
#endif /* __MAINBOARD_SKU_H__ */
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index f8671ec..1d5a0b2 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -71,6 +71,8 @@
case SKU_0_PANTHEON:
case SKU_1_PANTHEON:
case SKU_2_PANTHEON:
+ case SKU_0_SONA:
+ case SKU_1_SONA:
/* Disable unused port USB port */
cfg->usb2_ports[5].enable = 0;
break;
--
To view, visit https://review.coreboot.org/26876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id84ee22c9ffc15db78be3bbad148af5cd7dc866e
Gerrit-Change-Number: 26876
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/26875
Change subject: mb/google/poppy/variants/nami: Disable rear camera/DMIC for Pantheon
......................................................................
mb/google/poppy/variants/nami: Disable rear camera/DMIC for Pantheon
Since there are two cameras on Nami and only one camera on Pantheon.
We need to disable rear camera/DMIC on all Pantheon sku.
BUG=b:109720689
BRANCH=master
TEST=Verify if only front camera/DMIC shown on Pantheon
Change-Id: Ibe48a945dc57f2c05344479253040ad1945d92fd
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
M src/mainboard/google/poppy/variants/nami/include/variant/sku.h
M src/mainboard/google/poppy/variants/nami/mainboard.c
3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/26875/1
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 0e6b1b7..1e99dab 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -404,6 +404,9 @@
case SKU_0_VAYNE:
case SKU_1_VAYNE:
case SKU_2_VAYNE:
+ case SKU_0_PANTHEON:
+ case SKU_1_PANTHEON:
+ case SKU_2_PANTHEON:
*num = ARRAY_SIZE(vayne_sku_gpio_table);
board_gpio_tables = vayne_sku_gpio_table;
break;
diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
index 9dfffe1..a2c9c49 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
@@ -23,5 +23,6 @@
#define SKU_2_VAYNE 0x3A7F
#define SKU_0_PANTHEON 0x3F63
#define SKU_1_PANTHEON 0x3F67
+#define SKU_2_PANTHEON 0x3F62
#endif /* __MAINBOARD_SKU_H__ */
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index 9577623..f8671ec 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -68,6 +68,9 @@
case SKU_0_VAYNE:
case SKU_1_VAYNE:
case SKU_2_VAYNE:
+ case SKU_0_PANTHEON:
+ case SKU_1_PANTHEON:
+ case SKU_2_PANTHEON:
/* Disable unused port USB port */
cfg->usb2_ports[5].enable = 0;
break;
--
To view, visit https://review.coreboot.org/26875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe48a945dc57f2c05344479253040ad1945d92fd
Gerrit-Change-Number: 26875
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>