coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: drivers/spi: Remove DEBUG_SMI guard
by Nico Huber (Code Review) 06 Jun '18

06 Jun '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26870 Change subject: drivers/spi: Remove DEBUG_SMI guard ...................................................................... drivers/spi: Remove DEBUG_SMI guard Let the linker take care of it. Change-Id: I67d2636ceb042f833c1b44888b98135d728940e0 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/drivers/spi/Makefile.inc 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/26870/1 diff --git a/src/drivers/spi/Makefile.inc b/src/drivers/spi/Makefile.inc index edea392..cd404f4 100644 --- a/src/drivers/spi/Makefile.inc +++ b/src/drivers/spi/Makefile.inc @@ -4,7 +4,7 @@ ifeq ($(CONFIG_SPI_CONSOLE),y) ramstage-y += spiconsole.c -smm-$(CONFIG_DEBUG_SMI) += spiconsole.c +smm-y += spiconsole.c endif ifeq ($(CONFIG_CONSOLE_SPI_FLASH),y) @@ -13,8 +13,7 @@ romstage-y += flashconsole.c ramstage-y += flashconsole.c postcar-y += flashconsole.c -smm-$(CONFIG_DEBUG_SMI) += flashconsole.c - +smm-y += flashconsole.c endif bootblock-y += spi-generic.c -- To view, visit https://review.coreboot.org/26870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I67d2636ceb042f833c1b44888b98135d728940e0 Gerrit-Change-Number: 26870 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: google/chromeec: Set proper dev ops
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26869 ) Change subject: google/chromeec: Set proper dev ops ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74355/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28473/ : SUCCESS -- To view, visit https://review.coreboot.org/26869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210 Gerrit-Change-Number: 26869 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 17:47:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/chromeec: Set proper dev ops
by Naresh Solanki (Code Review) 06 Jun '18

06 Jun '18

Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/26869 Change subject: google/chromeec: Set proper dev ops ...................................................................... google/chromeec: Set proper dev ops For enable_resource & set_resource, use default DEVICE_NOOP so that they are not reported as missing during enumeration. BUG=None BRANCH=None TEST= Build & boot soraka. Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26869/1 diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 42a18e4..3078c22 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -459,15 +459,11 @@ res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; } -static void lpc_ec_enable_resources(struct device *dev) -{ - /* Nothing, but this function avoids an error on serial console. */ -} - static struct device_operations ops = { .init = lpc_ec_init, .read_resources = lpc_ec_read_resources, - .enable_resources = lpc_ec_enable_resources + .enable_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP }; static struct pnp_info pnp_dev_info[] = { -- To view, visit https://review.coreboot.org/26869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210 Gerrit-Change-Number: 26869 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: arch/x86/smbios: Conditionally call SMBIOS ops
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26864 ) Change subject: arch/x86/smbios: Conditionally call SMBIOS ops ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74348/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28466/ : SUCCESS -- To view, visit https://review.coreboot.org/26864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79681c10679e1de3a2d177503f29239968d0c157 Gerrit-Change-Number: 26864 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 16:43:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86/smbios: Conditionally call SMBIOS ops
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26864 ) Change subject: arch/x86/smbios: Conditionally call SMBIOS ops ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74347/ : SUCCESS -- To view, visit https://review.coreboot.org/26864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79681c10679e1de3a2d177503f29239968d0c157 Gerrit-Change-Number: 26864 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 16:02:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74346/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28465/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 15:57:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74345/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28464/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 15:28:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 06 Jun '18

06 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74344/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28463/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 15:10:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74341/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28460/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 14:41:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo: Add ThinkPad W530 support
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26136 ) Change subject: mb/lenovo: Add ThinkPad W530 support ...................................................................... Patch Set 27: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74343/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28462/ : SUCCESS -- To view, visit https://review.coreboot.org/26136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7918ea18712221cc62c5564caede340f71ce400 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 27 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 14:31:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018