build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26862 )
Change subject: cbfstool: Show current FMAP region in print
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74322/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28440/ : SUCCESS
--
To view, visit https://review.coreboot.org/26862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6f29ebeda8a9bde6dfe39362e0f2a5e33c86b26
Gerrit-Change-Number: 26862
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 13:31:39 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/26863 )
Change subject: cbfs: Fix compilation error with VBOOT enabled
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/26863/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/#/c/26863/1/src/lib/cbfs.c@323
PS1, Line 323: #if IS_ENABLED(CONFIG_VBOOT) && !defined(__SMM__)
> I don't think this is the right answer. […]
woah ultra fast as always. :) Yeah but there is no vboot smm support AFAIK
--
To view, visit https://review.coreboot.org/26863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5
Gerrit-Change-Number: 26863
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 13:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No