coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: nocturne: enable nvme
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26933 ) Change subject: nocturne: enable nvme ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74514/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28635/ : SUCCESS -- To view, visit https://review.coreboot.org/26933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0070d33b1ed09bd1f51a680d92ddb7e2bcb1ebc2 Gerrit-Change-Number: 26933 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Jun 2018 00:16:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nocturne: enable nvme
by Nick Vaccaro (Code Review) 07 Jun '18

07 Jun '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/26933 Change subject: nocturne: enable nvme ...................................................................... nocturne: enable nvme BUG=b:78122599 BRANCH=chromeos-2016.05 TEST='emerge-nocturne depthcharge coreboot chromeos-bootimage', boot to kernel, and verify /dev/nvme* entries exist. CQ-DEPEND=CL:1090070 Change-Id: I0070d33b1ed09bd1f51a680d92ddb7e2bcb1ebc2 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/26933/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 5b4c924..f746c08 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -160,6 +160,20 @@ register "PcieRpAdvancedErrorReporting[0]" = "1" register "PcieRpLtrEnable[0]" = "1" + # Root port 9 (x2) + # PcieRpEnable: Enable root port + # PcieRpClkReqSupport: Enable CLKREQ# + # PcieRpClkReqNumber: Uses SRCCLKREQ2# + # PcieRpClkSrcNumber: Uses 2 + # PcieRpAdvancedErrorReporting: Enable Advanced Error Reporting + # PcieRpLtrEnable: Enable Latency Tolerance Reporting Mechanism + register "PcieRpEnable[8]" = "1" + register "PcieRpClkReqSupport[8]" = "1" + register "PcieRpClkReqNumber[8]" = "2" + register "PcieRpClkSrcNumber[8]" = "2" + register "PcieRpAdvancedErrorReporting[8]" = "1" + register "PcieRpLtrEnable[8]" = "1" + # USB 2.0 register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)" # Type-C Port 1 register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Empty @@ -326,7 +340,7 @@ device pci 1c.5 off end # PCI Express Port 6 device pci 1c.6 off end # PCI Express Port 7 device pci 1c.7 off end # PCI Express Port 8 - device pci 1d.0 off end # PCI Express Port 9 + device pci 1d.0 on end # PCI Express Port 9 device pci 1d.1 off end # PCI Express Port 10 device pci 1d.2 off end # PCI Express Port 11 device pci 1d.3 off end # PCI Express Port 12 -- To view, visit https://review.coreboot.org/26933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0070d33b1ed09bd1f51a680d92ddb7e2bcb1ebc2 Gerrit-Change-Number: 26933 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: nocturne: set default to 4 cpu cores
by Nick Vaccaro (Code Review) 07 Jun '18

07 Jun '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/26932 Change subject: nocturne: set default to 4 cpu cores ...................................................................... nocturne: set default to 4 cpu cores BUG=b:78122599 BRANCH=chromeos-2016.05 TEST='emerge-nocturne coreboot chromeos-bootimage', boot into kernel, cat /proc/cpuinfo and verify four cores show up. Change-Id: I2eb3459664d479e2f3ef687d8c5f893a3c750a4b Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26932/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index ad08dd4..40781ba 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -110,6 +110,7 @@ config MAX_CPUS int + default 4 if BOARD_GOOGLE_NOCTURNE default 8 config OEM_BIN_FILE -- To view, visit https://review.coreboot.org/26932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2eb3459664d479e2f3ef687d8c5f893a3c750a4b Gerrit-Change-Number: 26932 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: util/sconfig: Re-factor device structure in parse tree
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

1 0

Change in coreboot[master]: util/sconfig: Make queue handling more generic within main.c
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26802 ) Change subject: util/sconfig: Make queue handling more generic within main.c ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74511/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28632/ : SUCCESS -- To view, visit https://review.coreboot.org/26802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2de85b48c5d4e2790bf974ea3bb1bd387f66ee Gerrit-Change-Number: 26802 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 23:47:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Re-factor device structure in parse tree
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 ) Change subject: util/sconfig: Re-factor device structure in parse tree ...................................................................... Patch Set 8: (12 comments) https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c File util/sconfig/main.c: https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@45 PS8, Line 45: * +------------------------+ +----------------------+ line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@46 PS8, Line 46: * | | | Mainboard | line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@47 PS8, Line 47: * +---------+ Root device (root_dev) +--------------->+ instance + line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@48 PS8, Line 48: * | | | chip_instance | (mainboard_instance)| line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@49 PS8, Line 49: * | +------------------------+ | | line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@50 PS8, Line 50: * | | +----------------------+ line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@68 PS8, Line 68: * +-------+----------+ line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@69 PS8, Line 69: * | | line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@70 PS8, Line 70: * | Mainboard chip +----------->X (new chips will be line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@71 PS8, Line 71: * | (mainboard_chip) | added here) line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@72 PS8, Line 72: * | | line over 80 characters https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@73 PS8, Line 73: * +------------------+ line over 80 characters -- To view, visit https://review.coreboot.org/26800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1 Gerrit-Change-Number: 26800 Gerrit-PatchSet: 8 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 23:47:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Re-factor device structure in parse tree
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

1 0

Change in coreboot[master]: util/sconfig: Get rid of unused parameter to walk_device_tree
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26801 ) Change subject: util/sconfig: Get rid of unused parameter to walk_device_tree ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74509/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28630/ : SUCCESS -- To view, visit https://review.coreboot.org/26801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I255ff030562073b16310fc22a0981808bf2c062f Gerrit-Change-Number: 26801 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 23:42:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Make queue handling more generic within main.c
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26802 ) Change subject: util/sconfig: Make queue handling more generic within main.c ...................................................................... Patch Set 6: No Builds Executed -- To view, visit https://review.coreboot.org/26802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2de85b48c5d4e2790bf974ea3bb1bd387f66ee Gerrit-Change-Number: 26802 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 23:37:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Re-factor device structure in parse tree
by build bot (Jenkins) (Code Review) 07 Jun '18

07 Jun '18

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018