Hello Haridhar Kalvala,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26940
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Enable low power S0Idle capability
......................................................................
soc/intel/skylake: Enable low power S0Idle capability
This patch sets the ACPI FADT flag ACPI_FADT_LOW_POWER_S0
if S0ix is enabled for the platform. This also sets the
FSPUPD to indicate the status of S0ix on the platform.
BUG=b:79559085
TEST= Boot to OS and check the ACPI_FADT_LOW_PWR_IDLE_S0
flag is set in FACP table - FADT.Flags[21] bit.
Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Signed-off-by: Haridhar Kalvala <haridhar.kalvala(a)intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com>
---
M src/soc/intel/skylake/acpi.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/26940/2
--
To view, visit https://review.coreboot.org/26940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Gerrit-Change-Number: 26940
Gerrit-PatchSet: 2
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com>
Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Haridhar Kalvala,
I'd like you to do a code review. Please visit
https://review.coreboot.org/26940
to review the following change.
Change subject: soc/intel/skylake: Enable low power S0Idle capability
......................................................................
soc/intel/skylake: Enable low power S0Idle capability
This patch sets the ACPI FADT flag ACPI_FADT_LOW_POWER_S0
if S0ix is enabled for the platform. This also sets the
FSPUPD to indicate the status of S0ix on the platform.
BUG=b:79559085
TEST= Boot to OS and check the ACPI_FADT_LOW_PWR_IDLE_S0
flag is set in FACP table - FADT.Flags[21] bit.
Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Signed-off-by: Haridhar Kalvala <haridhar.kalvala(a)intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com>
---
M src/soc/intel/skylake/acpi.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/26940/1
diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index be1200b..560b20c 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -234,6 +234,8 @@
void acpi_fill_fadt(acpi_fadt_t *fadt)
{
+ const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC);
+ const struct soc_intel_skylake_config *config = dev->chip_info;
const uint16_t pmbase = ACPI_BASE_ADDRESS;
/* Use ACPI 3.0 revision */
@@ -282,6 +284,9 @@
ACPI_FADT_RESET_REGISTER | ACPI_FADT_SEALED_CASE |
ACPI_FADT_S4_RTC_WAKE | ACPI_FADT_PLATFORM_CLOCK;
+ if(config->s0ix_enable)
+ fadt->flags |= ACPI_FADT_LOW_PWR_IDLE_S0;
+
fadt->reset_reg.space_id = 1;
fadt->reset_reg.bit_width = 8;
fadt->reset_reg.bit_offset = 0;
--
To view, visit https://review.coreboot.org/26940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Gerrit-Change-Number: 26940
Gerrit-PatchSet: 1
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com>
Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala(a)intel.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26659 )
Change subject: mediatek/mt8183: Add a stub implementation of the MT8183 SOC
......................................................................
Patch Set 16:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74526/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28647/ : SUCCESS
--
To view, visit https://review.coreboot.org/26659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81fa56ffce85188e1f9e979f9b0e64b764c2627
Gerrit-Change-Number: 26659
Gerrit-PatchSet: 16
Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicolas Boichat <drinkcat(a)chromium.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 07:55:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No