build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 )
Change subject: [WIP]drivers/spi: Winbond specific writeprotection enable
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/25105/5/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25105/5/src/drivers/spi/winbond.c@351
PS5, Line 351: "0x%08zx-0x%08zx\n",region->offset, region->size);
space required after that ',' (ctx:VxV)
--
To view, visit https://review.coreboot.org/25105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3765b013855538eca37bc7800d3f9d5d09b8402
Gerrit-Change-Number: 25105
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 07:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25082 )
Change subject: [WIP]drivers/spi: Read Winbond's flash protection bits
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/25082/8/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25082/8/src/drivers/spi/winbond.c@64
PS8, Line 64: u8 : 6;
space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/#/c/25082/8/src/drivers/spi/winbond.c@66
PS8, Line 66: u8 : 1;
space prohibited before that ':' (ctx:WxW)
--
To view, visit https://review.coreboot.org/25082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I933a8abdc28174ec32acf323c102d606b58c1ea5
Gerrit-Change-Number: 25082
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 07:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26658 )
Change subject: mediatek: Move uart, timer and cbmem code to a common directory.
......................................................................
Patch Set 12: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74524/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28645/ : SUCCESS
--
To view, visit https://review.coreboot.org/26658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5210149b324947ee90f1a481b42f0e2e1f7cfc25
Gerrit-Change-Number: 26658
Gerrit-PatchSet: 12
Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicolas Boichat <drinkcat(a)chromium.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 07:43:39 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23853 )
Change subject: tint: make it possible to reboot by pressing 'q' key two times
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74521/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28642/ : SUCCESS
--
To view, visit https://review.coreboot.org/23853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56d639fa8e563047fb3d2723695626a449ead40
Gerrit-Change-Number: 23853
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 06:53:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26933 )
Change subject: nocturne: enable nvme
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26933
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0070d33b1ed09bd1f51a680d92ddb7e2bcb1ebc2
Gerrit-Change-Number: 26933
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 06:35:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26932 )
Change subject: nocturne: set default to 4 cpu cores
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb3459664d479e2f3ef687d8c5f893a3c750a4b
Gerrit-Change-Number: 26932
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 06:35:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/26938 )
Change subject: util/lint: Add filename checker
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bf0be15d588aa1a5ece628b56e871662d6af44b
Gerrit-Change-Number: 26938
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 04:48:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes