Richard Spiegel has uploaded a new patch set (#2) to the change originally created by Daniel Kurtz. ( https://review.coreboot.org/26930 )
Change subject: amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.
......................................................................
amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.
By default we use a 1:1 mapping between GEVENT bits and the corresponding
SCI_MAP entry. However, we still must program the SCI_MAP entries
with the GEVENT number.
Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org>
BUG=b:109759838
TEST=(1) powerd_dbus_suspend
(2) move finger on touchpad for ~1 second
=> system resumes from S3
Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a
Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
---
M src/soc/amd/stoneyridge/gpio.c
M src/soc/amd/stoneyridge/include/soc/gpio.h
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26930/2
--
To view, visit https://review.coreboot.org/26930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a
Gerrit-Change-Number: 26930
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/26931 )
Change subject: mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe
Gerrit-Change-Number: 26931
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 22:32:09 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/26930 )
Change subject: amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c
File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@236
PS1, Line 236:
In here you should add a special case, if gpio == 2 and mux == 0 then do the SCI mapping (event 8). This is for wake on LAN.
https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@271
PS1, Line 271: sci_map = (uint8_t*)(uintptr_t)(APU_SMI_BASE +
: SMI_SCI_MAP(gevent_num));
:
Too complicated. Include soc/southbridge.h and use:
smi_write8(SMI_SCI_MAP(event), event);
I wrote a static function to be called both places:
static void route_sci(uint8_t event)
{
smi_write8(SMI_SCI_MAP(event), event);
}
--
To view, visit https://review.coreboot.org/26930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a
Gerrit-Change-Number: 26930
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 22:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26930 )
Change subject: amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c
File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@271
PS1, Line 271: sci_map = (uint8_t*)(uintptr_t)(APU_SMI_BASE +
"(foo*)" should be "(foo *)"
--
To view, visit https://review.coreboot.org/26930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a
Gerrit-Change-Number: 26930
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 22:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Daniel Kurtz has uploaded this change for review. ( https://review.coreboot.org/26931
Change subject: mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source
......................................................................
mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source
Configuring EC_PCH_WAKE_L as an SCI enabled GPIO allows the EC to wake
the AP from S3 on keyboard presses.
Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org>
BUG=b:109759838
TEST=(1) powerd_dbus_suspend
(2) press a key on the internal keyboard
=> system resumes from S3
Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/26931/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 4a7cfae..28f2293 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -98,7 +98,7 @@
PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
/* GPIO_24 - EC_PCH_WAKE_L */
- PAD_GPI(GPIO_24, PULL_UP),
+ PAD_SCI(GPIO_24, PULL_UP, EDGE_LOW),
/* GPIO_26 - APU_PCIE_RST_L */
PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),
--
To view, visit https://review.coreboot.org/26931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe
Gerrit-Change-Number: 26931
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>