Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/26975 )
Change subject: [RFC] Revert recent bootmem changes
......................................................................
Patch Set 2:
I agree with Aaron about fixing instead of reverting. Also keep in mind we are working on master guys which is not production ready.. Reverting the patches in the 4.8 branch is fine for me.
--
To view, visit https://review.coreboot.org/26975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9b28ee50d94fe443a6e2b6e9d337f0c784b18c4
Gerrit-Change-Number: 26975
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 20:02:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26989 )
Change subject: mainboard/emulation: Get rid of device_t
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/26989/1/src/mainboard/emulation/qemu-i440fx…
File src/mainboard/emulation/qemu-i440fx/acpi.h:
https://review.coreboot.org/#/c/26989/1/src/mainboard/emulation/qemu-i440fx…
PS1, Line 1: unsigned long northbridge_write_acpi_tables(struct device *device, unsigned long start);
line over 80 characters
--
To view, visit https://review.coreboot.org/26989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbfc6c5bba31838dd29f3e3fcfedc5a7ad15a25d
Gerrit-Change-Number: 26989
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 19:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/26984 )
Change subject: mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/26984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Gerrit-Change-Number: 26984
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 19:16:37 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26969 )
Change subject: mainboard/google/kahlee: Turn on backlight for all SKUs
......................................................................
Patch Set 2:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74668/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28778/ : SUCCESS
--
To view, visit https://review.coreboot.org/26969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Gerrit-Change-Number: 26969
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 18:53:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/26969 )
Change subject: mainboard/google/kahlee: Turn on backlight for all SKUs
......................................................................
mainboard/google/kahlee: Turn on backlight for all SKUs
Careena uses a different keyboard backlight method, so let the EC
handle the different SKUs and backlight methods.
BUG=b:80106042
TEST=None
Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/26969
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Raul Rangel <rrangel(a)chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/romstage.c
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/baseboard/romstage.c b/src/mainboard/google/kahlee/variants/baseboard/romstage.c
index 2b8baf8..f87a9d6 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/romstage.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/romstage.c
@@ -18,9 +18,6 @@
void variant_romstage_entry(int s3_resume)
{
- uint32_t sku = google_chromeec_get_sku_id();
-
- /* Based on SKU, turn on keyboard backlight to show system is booting */
- if (sku <= 6 && !s3_resume)
+ if (!s3_resume)
google_chromeec_kbbacklight(75);
}
--
To view, visit https://review.coreboot.org/26969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Gerrit-Change-Number: 26969
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>