Raul Rangel has posted comments on this change. ( https://review.coreboot.org/26969 )
Change subject: mainboard/google/kahlee: Turn on backlight for all SKUs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Gerrit-Change-Number: 26969
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 17:41:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/26968 )
Change subject: src/mainboard/kahlee: Use common mainboard and romstage files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65188bee1958d442bfe64637c3b93dc05583a686
Gerrit-Change-Number: 26968
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 17:41:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26984
to look at the new patch set (#4).
Change subject: mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
......................................................................
mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
In romstage use pci_devfn_t or pnp_devfn_t.
Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/compulab/intense_pc/romstage.c
M src/mainboard/google/beltino/chromeos.c
M src/mainboard/google/butterfly/chromeos.c
M src/mainboard/google/jecht/chromeos.c
M src/mainboard/google/parrot/chromeos.c
M src/mainboard/google/stout/chromeos.c
M src/mainboard/intel/baskingridge/chromeos.c
M src/mainboard/intel/cougar_canyon2/romstage.c
M src/mainboard/intel/d510mo/romstage.c
M src/mainboard/intel/emeraldlake2/chromeos.c
M src/mainboard/intel/emeraldlake2/romstage.c
M src/mainboard/intel/galileo/gpio.c
M src/mainboard/samsung/lumpy/chromeos.c
M src/mainboard/samsung/stumpy/chromeos.c
M src/mainboard/tyan/s2912_fam10/get_bus_conf.c
15 files changed, 28 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26984/4
--
To view, visit https://review.coreboot.org/26984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Gerrit-Change-Number: 26984
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/26986 )
Change subject: southbridge/intel/lynxpoint: add hard_reset to postcar
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/26986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448a8702a30108f1fc82179a766cbdd209336df7
Gerrit-Change-Number: 26986
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 17:34:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/26986
Change subject: southbridge/intel/lynxpoint: add hard_reset to postcar
......................................................................
southbridge/intel/lynxpoint: add hard_reset to postcar
This fixes the following failure on certain google/peppy configs:
build/postcar/lib/reset.o: In function `__hard_reset':
/home/pgeorgi/coreboot/src/lib/reset.c:24: undefined reference to `do_hard_reset'
Change-Id: I448a8702a30108f1fc82179a766cbdd209336df7
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
---
M src/southbridge/intel/lynxpoint/Makefile.inc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/26986/1
diff --git a/src/southbridge/intel/lynxpoint/Makefile.inc b/src/southbridge/intel/lynxpoint/Makefile.inc
index 6abdf4d..7ea0d8b 100644
--- a/src/southbridge/intel/lynxpoint/Makefile.inc
+++ b/src/southbridge/intel/lynxpoint/Makefile.inc
@@ -55,4 +55,6 @@
smm-$(CONFIG_HAVE_SMI_HANDLER) += lp_gpio.c
endif
+postcar-y += reset.c
+
endif
--
To view, visit https://review.coreboot.org/26986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I448a8702a30108f1fc82179a766cbdd209336df7
Gerrit-Change-Number: 26986
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/26984
to look at the new patch set (#3).
Change subject: mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
......................................................................
mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
In romstage use pci_devfn_t or pnp_devfn_t.
Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/compulab/intense_pc/romstage.c
M src/mainboard/google/beltino/chromeos.c
M src/mainboard/google/butterfly/chromeos.c
M src/mainboard/google/jecht/chromeos.c
M src/mainboard/google/parrot/chromeos.c
M src/mainboard/google/stout/chromeos.c
M src/mainboard/intel/baskingridge/chromeos.c
M src/mainboard/intel/cougar_canyon2/romstage.c
M src/mainboard/intel/d510mo/romstage.c
M src/mainboard/intel/emeraldlake2/chromeos.c
M src/mainboard/intel/emeraldlake2/romstage.c
M src/mainboard/intel/galileo/gpio.c
M src/mainboard/samsung/lumpy/chromeos.c
M src/mainboard/samsung/stumpy/chromeos.c
M src/mainboard/tyan/s2912_fam10/get_bus_conf.c
15 files changed, 28 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26984/3
--
To view, visit https://review.coreboot.org/26984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Gerrit-Change-Number: 26984
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>