build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27010 )
Change subject: src: Get rid of device_t
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27010/2/src/device/hypertransport.c
File src/device/hypertransport.c:
https://review.coreboot.org/#/c/27010/2/src/device/hypertransport.c@76
PS2, Line 76: static int ht_setup_link(struct ht_link *prev, struct device *dev, unsigned pos)
Prefer 'unsigned int' to bare use of 'unsigned'
--
To view, visit https://review.coreboot.org/27010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cebfc5c77187bd81094031c43ff6df094908417
Gerrit-Change-Number: 27010
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 11 Jun 2018 06:16:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27010
to look at the new patch set (#2).
Change subject: src: Get rid of device_t
......................................................................
src: Get rid of device_t
Change-Id: I9cebfc5c77187bd81094031c43ff6df094908417
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/device/hypertransport.c
M src/drivers/net/ne2k.c
M src/drivers/usb/pci_ehci.c
M src/include/device/cardbus.h
M src/include/device/pciexp.h
M src/include/device/pcix.h
M src/mainboard/hp/dl165_g6_fam10/bootblock.c
M src/northbridge/amd/amdfam10/acpi.c
M src/northbridge/amd/amdfam10/amdfam10.h
M src/northbridge/amd/amdfam10/ht_config.c
M src/northbridge/amd/amdfam10/ht_config.h
M src/northbridge/amd/amdfam10/misc_control.c
M src/northbridge/amd/amdfam10/northbridge.h
M src/northbridge/amd/amdfam10/util.c
M src/northbridge/amd/lx/northbridge.c
M src/northbridge/amd/pi/00630F01/iommu.c
M src/soc/intel/apollolake/bootblock/bootblock.c
M src/soc/intel/apollolake/smihandler.c
M src/soc/intel/baytrail/pmutil.c
M src/soc/intel/baytrail/smihandler.c
M src/soc/intel/baytrail/spi.c
M src/soc/intel/braswell/pmutil.c
M src/soc/intel/braswell/smihandler.c
M src/soc/intel/braswell/spi.c
M src/soc/intel/cannonlake/bootblock/pch.c
M src/soc/intel/cannonlake/bootblock/report_platform.c
M src/soc/intel/cannonlake/smihandler.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/fsp_baytrail/pmutil.c
M src/soc/intel/fsp_baytrail/spi.c
M src/southbridge/amd/sr5650/early_setup.c
M src/superio/intel/i8900/i8900.h
M src/superio/winbond/wpcd376i/early_serial.c
M src/superio/winbond/wpcd376i/superio.c
M src/superio/winbond/wpcd376i/wpcd376i.h
35 files changed, 109 insertions(+), 104 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/27010/2
--
To view, visit https://review.coreboot.org/27010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cebfc5c77187bd81094031c43ff6df094908417
Gerrit-Change-Number: 27010
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27011
Change subject: util/lint: Run lint-extended-007-final-newlines checks in parallel
......................................................................
util/lint: Run lint-extended-007-final-newlines checks in parallel
Instead of checking each directory in series, kick off the checks
in parallel and then wait for them to finish. Failures print out with
file information, so mixing output isn't a problem. This reduces
the time it takes to run on lumberingbuilder by 60%.
This could probably be sped up even more by splitting up src/mainboard
into smaller sections.
This method does skip a few control files at the top level - .gitignore,
.checkpatch.conf, gnat.adc, etc. These could be added to the list of
files to check, but I didn't think it was needed.
Change-Id: I171977e713a9956cf4142cfc0a199e10040abb35
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
---
M util/lint/lint-extended-015-final-newlines
1 file changed, 15 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/27011/1
diff --git a/util/lint/lint-extended-015-final-newlines b/util/lint/lint-extended-015-final-newlines
index 4ddd00b..b5a503f 100755
--- a/util/lint/lint-extended-015-final-newlines
+++ b/util/lint/lint-extended-015-final-newlines
@@ -16,6 +16,8 @@
LC_ALL=C export LC_ALL
+PIDS=""
+INCLUDED_DIRS_AND_FILES='util/* src/* payloads/* configs/* Makefile *.inc'
EXCLUDED_DIRS='src/vendorcode/\|util/romcc/\|cbfstool/lzma/\|cbfstool/lz4/\|Documentation/\|build/\|3rdparty/\|\.git/\|coreboot-builds/\|util/nvidia/cbootimage/'
EXCLUDED_FILES='\.jpg$\|\.cksum$\|\.bin$\|\.vbt$\|\.hex$\|\.ico$\|\.o$\|\.bz2$\|\.xz$\|^.tmpconfig\|\.pyc$\|_shipped$\|sha256$\|\.png$\|\.patch$'
@@ -25,7 +27,7 @@
then
FIND_FILES="git ls-files"
else
- FIND_FILES="find . "
+ FIND_FILES="find"
fi
HAVE_FILE=$(command -v file 1>/dev/null 2>&1; echo $?)
@@ -49,7 +51,6 @@
if [ -f "$filename" ] && { [ ! -x "$filename" ] || \
is_eligible_executable "$filename"; };
then
-
# Verify that there is a newline at the end
# $() strips trailing newlines
if [ -n "$(tail -c 1 "$filename")" ]; then
@@ -65,7 +66,15 @@
done
}
-${FIND_FILES} | sed 's|^\./||' | sort | \
- grep -v "$EXCLUDED_DIRS" | \
- grep -v "$EXCLUDED_FILES" | \
- test_for_final_newline
+for directory in $INCLUDED_DIRS_AND_FILES ; do
+ ${FIND_FILES} ${directory} | sed 's|^\./||' | sort | \
+ grep -v "$EXCLUDED_DIRS" | \
+ grep -v "$EXCLUDED_FILES" | \
+ test_for_final_newline &
+ PIDS="$PIDS $!"
+done
+
+# wait for tests to finish.
+for pid in $PIDS; do
+ wait "$pid"
+done
--
To view, visit https://review.coreboot.org/27011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I171977e713a9956cf4142cfc0a199e10040abb35
Gerrit-Change-Number: 27011
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>