build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27010 )
Change subject: src/device/hypertransport.c: Get rid of device_t
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27010/1/src/device/hypertransport.c
File src/device/hypertransport.c:
https://review.coreboot.org/#/c/27010/1/src/device/hypertransport.c@76
PS1, Line 76: static int ht_setup_link(struct ht_link *prev, struct device *dev, unsigned pos)
Prefer 'unsigned int' to bare use of 'unsigned'
--
To view, visit https://review.coreboot.org/27010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cebfc5c77187bd81094031c43ff6df094908417
Gerrit-Change-Number: 27010
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 10 Jun 2018 21:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/27009 )
Change subject: drivers/i2c/generic: Ensure config is not NULL before accessing it
......................................................................
drivers/i2c/generic: Ensure config is not NULL before accessing it
This change checks to ensure that config is not NULL before it is
accessed for the first time.
Reported by: Coverity CID #1393312
Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/drivers/i2c/generic/generic.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/27009/2
--
To view, visit https://review.coreboot.org/27009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c
Gerrit-Change-Number: 27009
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27009
Change subject: drivers/i2c/generic: Encure config is not NULL before accessing it
......................................................................
drivers/i2c/generic: Encure config is not NULL before accessing it
This change checks to ensure that config is not NULL before it is
accessed for the first time.
Reported by: Coverity CID #1393312
Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/drivers/i2c/generic/generic.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/27009/1
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index 7f1ce16..1b12df5 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -202,6 +202,9 @@
{
struct drivers_i2c_generic_config *config = dev->chip_info;
+ if (!config)
+ return;
+
/* Check if device is present by reading GPIO */
if (config->device_present_gpio) {
int present = gpio_get(config->device_present_gpio);
@@ -219,9 +222,8 @@
dev->ops = &i2c_generic_ops;
/* Name the device as per description provided in devicetree */
- if (config && config->desc) {
+ if (config->desc)
dev->name = config->desc;
- }
}
struct chip_operations drivers_i2c_generic_ops = {
--
To view, visit https://review.coreboot.org/27009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c
Gerrit-Change-Number: 27009
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26995 )
Change subject: util/lint: Run lint-extended-007-checkpatch checks in parallel
......................................................................
Patch Set 1:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/28812/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/74726/ : SUCCESS
--
To view, visit https://review.coreboot.org/26995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1252a68a723370389d399f3d1a2aff3fad64c365
Gerrit-Change-Number: 26995
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 10 Jun 2018 17:17:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No