build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 )
Change subject: sb/intel/common/smihandler: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75574/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29634/ : SUCCESS
--
To view, visit https://review.coreboot.org/27281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:06:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 )
Change subject: sb/intel/common/smihandler: Use new PMBASE API
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/27281/6/src/southbridge/intel/common/smihan…
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/#/c/27281/6/src/southbridge/intel/common/smihan…
PS6, Line 295: write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) &~SCI_EN);
need consistent spacing around '&' (ctx:WxO)
--
To view, visit https://review.coreboot.org/27281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27280 )
Change subject: sb/intel/lynxpoint: Use new common PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75573/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29633/ : SUCCESS
--
To view, visit https://review.coreboot.org/27280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e62846d34af3d81d9b787a313caa6dabb275bcf
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:02:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )
Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................
Patch Set 8: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29631/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75571/ : SUCCESS
--
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 10:49:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )
Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c@185
PS8, Line 185: if (rdev_writeat(&store, &key_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c@189
PS8, Line 189: if (rdev_writeat(&store, &value_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c@193
PS8, Line 193: if (rdev_writeat(&store, key, end, key_sz) != key_sz) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c@197
PS8, Line 197: if (rdev_writeat(&store, value, end, value_sz) != value_sz) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/8/src/drivers/smmstore/store.c@202
PS8, Line 202: if (rdev_writeat(&store, &nul, end, 1) != 1) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 10:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27029 )
Change subject: mediatek: Move mtcmos code to a common directory
......................................................................
Patch Set 7:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29629/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75570/ : SUCCESS
--
To view, visit https://review.coreboot.org/27029
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92b138890424b4f4a68cdb00bf2326eef9cd87b7
Gerrit-Change-Number: 27029
Gerrit-PatchSet: 7
Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kevin Paul Herbert <kph(a)meraki.net>
Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 10:33:51 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27028 )
Change subject: mediatek: Share mtcmos code among similar SOCs
......................................................................
Patch Set 7:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29627/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75567/ : SUCCESS
--
To view, visit https://review.coreboot.org/27028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd0a90f6eba3ed2e74a3fd54279c7645aa41774
Gerrit-Change-Number: 27028
Gerrit-PatchSet: 7
Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 10:27:14 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No