build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27280 )
Change subject: sb/intel/lynxpoint: Use new common PMBASE API
......................................................................
Patch Set 4:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75553/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29607/ : SUCCESS
--
To view, visit https://review.coreboot.org/27280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e62846d34af3d81d9b787a313caa6dabb275bcf
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:54:19 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 )
Change subject: sb/intel/common/smihandler: Use new PMBASE API
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/27281/4/src/southbridge/intel/common/smihan…
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/#/c/27281/4/src/southbridge/intel/common/smihan…
PS4, Line 295: write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) &~SCI_EN);
need consistent spacing around '&' (ctx:WxO)
--
To view, visit https://review.coreboot.org/27281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27285 )
Change subject: mb/samsung/lumpy: Use new PMBASE API
......................................................................
Patch Set 3: Verified-1
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/75547/ : ABORTED
https://qa.coreboot.org/job/coreboot-checkpatch/29599/ : SUCCESS
--
To view, visit https://review.coreboot.org/27285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife344d1699a2eff7d93738221a0e87d0481f05d7
Gerrit-Change-Number: 27285
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:37:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27286 )
Change subject: sb/intel/bd82x6x: Use new PMBASE API
......................................................................
Patch Set 3: Verified-1
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/75548/ : ABORTED
https://qa.coreboot.org/job/coreboot-checkpatch/29600/ : SUCCESS
--
To view, visit https://review.coreboot.org/27286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42bbea1f2deb0be80af2c8008045d37a926126a
Gerrit-Change-Number: 27286
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:37:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27287 )
Change subject: sb/intel/common/pmutil: Use new PMBASE API
......................................................................
Patch Set 3:
Build Failed
https://qa.coreboot.org/job/coreboot-checkpatch/29601/ : SUCCESS
--
To view, visit https://review.coreboot.org/27287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f37f0c49fd58adafd8a508e806e0f30759a6963
Gerrit-Change-Number: 27287
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:37:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27279
to look at the new patch set (#4).
Change subject: intel: Get rid of smm_get_pmbase
......................................................................
intel: Get rid of smm_get_pmbase
Change-Id: I2b3168c600a81502f9cd1ff3203c492cf026e532
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/include/cpu/x86/smm.h
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/fsp_bd82x6x/smihandler.c
M src/southbridge/intel/fsp_i89xx/smihandler.c
M src/southbridge/intel/ibexpeak/smihandler.c
5 files changed, 0 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/27279/4
--
To view, visit https://review.coreboot.org/27279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b3168c600a81502f9cd1ff3203c492cf026e532
Gerrit-Change-Number: 27279
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>