coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: sb/intel/common/smihandler: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 ) Change subject: sb/intel/common/smihandler: Use new PMBASE API ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/27281/3/src/southbridge/intel/common/smihan… File src/southbridge/intel/common/smihandler.c: https://review.coreboot.org/#/c/27281/3/src/southbridge/intel/common/smihan… PS3, Line 289: write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) &~SCI_EN); need consistent spacing around '&' (ctx:WxO) -- To view, visit https://review.coreboot.org/27281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97 Gerrit-Change-Number: 27281 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:23:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/common: Add functions to manipulate PMBASE
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27278 ) Change subject: sb/intel/common: Add functions to manipulate PMBASE ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75540/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29592/ : SUCCESS -- To view, visit https://review.coreboot.org/27278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b454434ade560fb056b1fc0afe9541df93e14dd Gerrit-Change-Number: 27278 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:23:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/parrot: Use new common SMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27282 ) Change subject: mb/google/parrot: Use new common SMBASE API ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75538/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29586/ : SUCCESS -- To view, visit https://review.coreboot.org/27282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee3a7cc3808ad7ec26464e54bf6144b70f426aa6 Gerrit-Change-Number: 27282 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:19:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/common/smihandler: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 ) Change subject: sb/intel/common/smihandler: Use new PMBASE API ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75539/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/29585/ : SUCCESS -- To view, visit https://review.coreboot.org/27281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97 Gerrit-Change-Number: 27281 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/common/pmutil: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27287 ) Change subject: sb/intel/common/pmutil: Use new PMBASE API ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29591/ : SUCCESS -- To view, visit https://review.coreboot.org/27287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f37f0c49fd58adafd8a508e806e0f30759a6963 Gerrit-Change-Number: 27287 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27286 ) Change subject: sb/intel/bd82x6x: Use new PMBASE API ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29590/ : SUCCESS -- To view, visit https://review.coreboot.org/27286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id42bbea1f2deb0be80af2c8008045d37a926126a Gerrit-Change-Number: 27286 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/samsung/lumpy: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27285 ) Change subject: mb/samsung/lumpy: Use new PMBASE API ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29589/ : SUCCESS -- To view, visit https://review.coreboot.org/27285 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife344d1699a2eff7d93738221a0e87d0481f05d7 Gerrit-Change-Number: 27285 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/link: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27284 ) Change subject: mb/google/link: Use new PMBASE API ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29588/ : SUCCESS -- To view, visit https://review.coreboot.org/27284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4d6c80e95469341f0c978f302f04508f50280bd Gerrit-Change-Number: 27284 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/stout: Use new PMBASE API
by build bot (Jenkins) (Code Review) 29 Jun '18

29 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27283 ) Change subject: mb/google/stout: Use new PMBASE API ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29587/ : SUCCESS -- To view, visit https://review.coreboot.org/27283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb13627bcd2ad023f7686b5ae0bd7331e09cf5b4 Gerrit-Change-Number: 27283 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Jun 2018 09:18:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/common: Add functions to manipulate PMBASE
by Patrick Rudolph (Code Review) 29 Jun '18

29 Jun '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27278 to look at the new patch set (#3). Change subject: sb/intel/common: Add functions to manipulate PMBASE ...................................................................... sb/intel/common: Add functions to manipulate PMBASE Get rid of duplicated get_pmbase and use the new common function. TODO: Use the new functions to manipulate register in PMBASE. Change-Id: I3b454434ade560fb056b1fc0afe9541df93e14dd Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/common/Makefile.inc A src/southbridge/intel/common/pmbase.c A src/southbridge/intel/common/pmbase.h M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smi.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c 11 files changed, 113 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27278/3 -- To view, visit https://review.coreboot.org/27278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b454434ade560fb056b1fc0afe9541df93e14dd Gerrit-Change-Number: 27278 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018