build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27120 )
Change subject: mb/intel/dg41wv: Expose some SIO devices via ACPI
......................................................................
Patch Set 2:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/75583/ : SUCCESS
--
To view, visit https://review.coreboot.org/27120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia658c117434c3fae45bbbe6c472ca58ba4f1a117
Gerrit-Change-Number: 27120
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 12:27:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )
Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................
Patch Set 9: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/29642/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/75582/ : SUCCESS
--
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 12:07:06 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )
Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c@185
PS9, Line 185: if (rdev_writeat(&store, &key_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c@189
PS9, Line 189: if (rdev_writeat(&store, &value_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c@193
PS9, Line 193: if (rdev_writeat(&store, key, end, key_sz) != key_sz) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c@197
PS9, Line 197: if (rdev_writeat(&store, value, end, value_sz) != value_sz) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25182/9/src/drivers/smmstore/store.c@202
PS9, Line 202: if (rdev_writeat(&store, &nul, end, 1) != 1) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 12:03:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27287 )
Change subject: sb/intel/common/pmutil: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75581/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29641/ : SUCCESS
--
To view, visit https://review.coreboot.org/27287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f37f0c49fd58adafd8a508e806e0f30759a6963
Gerrit-Change-Number: 27287
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:25:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27279 )
Change subject: intel: Get rid of smm_get_pmbase
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75580/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29640/ : SUCCESS
--
To view, visit https://review.coreboot.org/27279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3168c600a81502f9cd1ff3203c492cf026e532
Gerrit-Change-Number: 27279
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:20:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27286 )
Change subject: sb/intel/bd82x6x: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75579/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29639/ : SUCCESS
--
To view, visit https://review.coreboot.org/27286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42bbea1f2deb0be80af2c8008045d37a926126a
Gerrit-Change-Number: 27286
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:20:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27285 )
Change subject: mb/samsung/lumpy: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75578/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29638/ : SUCCESS
--
To view, visit https://review.coreboot.org/27285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife344d1699a2eff7d93738221a0e87d0481f05d7
Gerrit-Change-Number: 27285
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:15:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27284 )
Change subject: mb/google/link: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75577/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29637/ : SUCCESS
--
To view, visit https://review.coreboot.org/27284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d6c80e95469341f0c978f302f04508f50280bd
Gerrit-Change-Number: 27284
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:14:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27283 )
Change subject: mb/google/stout: Use new PMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75576/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29636/ : SUCCESS
--
To view, visit https://review.coreboot.org/27283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb13627bcd2ad023f7686b5ae0bd7331e09cf5b4
Gerrit-Change-Number: 27283
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:11:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27282 )
Change subject: mb/google/parrot: Use new common SMBASE API
......................................................................
Patch Set 6:
Build Unstable
https://qa.coreboot.org/job/coreboot-gerrit/75575/ : UNSTABLE
https://qa.coreboot.org/job/coreboot-checkpatch/29635/ : SUCCESS
--
To view, visit https://review.coreboot.org/27282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee3a7cc3808ad7ec26464e54bf6144b70f426aa6
Gerrit-Change-Number: 27282
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 11:08:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No