coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: soc/intel/cannonlake: Switch to common block for GSPI
by Maulik V Vaghela (Code Review) 27 Apr '18

27 Apr '18

Hello Subrata Banik, Balaji Manigandan, Aamir Bohra, Rizwan Qureshi, V Sowmya, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25863 to look at the new patch set (#8). Change subject: soc/intel/cannonlake: Switch to common block for GSPI ...................................................................... soc/intel/cannonlake: Switch to common block for GSPI >From cannonlake onwards we'll use GSPI functionality from common block which was created in previous patch and remove gspi.c file from soc. We need to implement/move one soc specific function which is moved to chip_config.c which returns soc specific configuration for gspi. This will reduce redundant copy of code which is common across multiple soc. BUG=none BRANCH=none TEST=Coreboot builds with different board configuration. Also coreboot boots with these changes on cannonlake board. Change-Id: Ia456f6d8e03fcca1a916dc86b3d8cc68fb45a155 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc M src/soc/intel/cannonlake/chip_config.c D src/soc/intel/cannonlake/gspi.c 4 files changed, 23 insertions(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/25863/8 -- To view, visit https://review.coreboot.org/25863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia456f6d8e03fcca1a916dc86b3d8cc68fb45a155 Gerrit-Change-Number: 25863 Gerrit-PatchSet: 8 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Fix crossystem wpsw_cur error
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25892 ) Change subject: mb/google/octopus: Fix crossystem wpsw_cur error ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70901/ : SUCCESS -- To view, visit https://review.coreboot.org/25892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica60f342420d95d09a45580f2f940443c03601de Gerrit-Change-Number: 25892 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 07:00:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Create a common gspi V3 block
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25862 ) Change subject: soc/intel/common/block: Create a common gspi V3 block ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25082/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70900/ : SUCCESS -- To view, visit https://review.coreboot.org/25862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8573c4b487394893b467bddccb702d4942a4b87 Gerrit-Change-Number: 25862 Gerrit-PatchSet: 6 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:48:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Use common i2c function instead of soc
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25807 ) Change subject: soc/intel/cannonlake: Use common i2c function instead of soc ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70897/ : SUCCESS -- To view, visit https://review.coreboot.org/25807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I569f407a82c09f37a31fa3e090c27acb12bf758e Gerrit-Change-Number: 25807 Gerrit-PatchSet: 9 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:48:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Fix crossystem wpsw_cur error
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25892 ) Change subject: mb/google/octopus: Fix crossystem wpsw_cur error ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25084/ : SUCCESS -- To view, visit https://review.coreboot.org/25892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica60f342420d95d09a45580f2f940443c03601de Gerrit-Change-Number: 25892 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:48:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel: use common lockdown for skylake and cannonlake
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel: use common lockdown for skylake and cannonlake ...................................................................... Patch Set 35: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70896/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 35 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:48:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Switch to common block for GSPI
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25863 ) Change subject: soc/intel/cannonlake: Switch to common block for GSPI ...................................................................... Patch Set 7: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70899/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/25083/ : SUCCESS -- To view, visit https://review.coreboot.org/25863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia456f6d8e03fcca1a916dc86b3d8cc68fb45a155 Gerrit-Change-Number: 25863 Gerrit-PatchSet: 7 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:48:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Fix crossystem wpsw_cur error
by Hannah Williams (Code Review) 27 Apr '18

27 Apr '18

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/25892 Change subject: mb/google/octopus: Fix crossystem wpsw_cur error ...................................................................... mb/google/octopus: Fix crossystem wpsw_cur error With only one entry for Write Protect gpio in the OIPG package, the sysfs entry /sys/devices/platform/chromeos_acpi/GPIO.x is created as "GPIO" instead of "GPIO.x".This was causing crossytem to return error for wpsw_cur. BUG=b:78009842 Change-Id: Ica60f342420d95d09a45580f2f940443c03601de Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/soc/intel/apollolake/include/soc/gpio_glk.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/25892/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 8863bbb..1f2e728 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -300,6 +300,7 @@ } static const struct cros_gpio cros_gpios[] = { + CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), CROS_GPIO_WP_AH(PAD_SCC(GPIO_PCH_WP), GPIO_COMM_SCC_NAME), }; diff --git a/src/soc/intel/apollolake/include/soc/gpio_glk.h b/src/soc/intel/apollolake/include/soc/gpio_glk.h index 7145a28..63bee3b 100644 --- a/src/soc/intel/apollolake/include/soc/gpio_glk.h +++ b/src/soc/intel/apollolake/include/soc/gpio_glk.h @@ -321,6 +321,7 @@ #define PAD_SCC(pad) (pad - SCC_OFFSET) /* Linux names of the GPIO devices. */ +#define CROS_GPIO_DEVICE_NAME "INT3453" #define GPIO_COMM_NW_NAME "INT3453:00" #define GPIO_COMM_N_NAME "INT3453:01" #define GPIO_COMM_AUDIO_NAME "INT3453:02" -- To view, visit https://review.coreboot.org/25892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ica60f342420d95d09a45580f2f940443c03601de Gerrit-Change-Number: 25892 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Create new folder for common i2c V2 code
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25806 ) Change subject: soc/intel/common/block: Create new folder for common i2c V2 code ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70898/ : SUCCESS -- To view, visit https://review.coreboot.org/25806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1d8fc80b6fd06a88c76b040967e8694af256ea Gerrit-Change-Number: 25806 Gerrit-PatchSet: 9 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:43:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel: use common lockdown for skylake and cannonlake
by build bot (Jenkins) (Code Review) 27 Apr '18

27 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel: use common lockdown for skylake and cannonlake ...................................................................... Patch Set 35: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/25080/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 35 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Apr 2018 06:38:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018