build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25383 )
Change subject: lib/bootmem: Introduce new memory type
......................................................................
Patch Set 11:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/24132/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/69850/ : SUCCESS
--
To view, visit https://review.coreboot.org/25383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c983ce43616147c519a43edee3b61d54eadbb9a
Gerrit-Change-Number: 25383
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 13:39:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/25585 )
Change subject: siemens/mc_apl1: Fix for using IDT PMIC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainb…
File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainb…
PS1, Line 146: mdelay(1);
is this delay required here? if not, you might be better off by using the stopwatch API from src/include/timer.h: create a stopwatch and use "while (!stopwatch_expired(sw)) ..."
--
To view, visit https://review.coreboot.org/25585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25
Gerrit-Change-Number: 25585
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 13:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/25590 )
Change subject: util/cbfstool: Print all supported architectures
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/25590
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7ed67c3bfd928b304c314fcc8e1bea35561662
Gerrit-Change-Number: 25590
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 13:26:05 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/25589 )
Change subject: util/cbfstool: Print types on stdout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/25589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I800c9205c59383b63a640bc0798a1bd9117b0f99
Gerrit-Change-Number: 25589
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 13:25:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes