coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mainboard/google/meowth: Disable debug consent
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25312 ) Change subject: mainboard/google/meowth: Disable debug consent ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23277/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68909/ : SUCCESS -- To view, visit https://review.coreboot.org/25312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Gerrit-Change-Number: 25312 Gerrit-PatchSet: 1 Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:26:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/meowth: Disable debug consent
by Lijian Zhao (Code Review) 22 Mar '18

22 Mar '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/25312 ) Change subject: mainboard/google/meowth: Disable debug consent ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25312/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25312/1//COMMIT_MSG@13 PS1, Line 13: None Submit a partner issue and list the partner issue bug number here for tracking purpose. -- To view, visit https://review.coreboot.org/25312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Gerrit-Change-Number: 25312 Gerrit-PatchSet: 1 Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:25:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/meowth: Disable debug consent
by Lijian Zhao (Code Review) 22 Mar '18

22 Mar '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/25312 ) Change subject: mainboard/google/meowth: Disable debug consent ...................................................................... Patch Set 1: If current meowth CPFE OS release already support s0ix successfully, and meowth did require to support s0ix. Then other than this patch, a separated patch that will disable DCI in fit_config.xml will be also needed. -- To view, visit https://review.coreboot.org/25312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Gerrit-Change-Number: 25312 Gerrit-PatchSet: 1 Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:24:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/intel:Update FSP Header files per v2.0.0
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25247 ) Change subject: vendorcode/intel:Update FSP Header files per v2.0.0 ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23275/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68906/ : SUCCESS -- To view, visit https://review.coreboot.org/25247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93d95e1977a4e31981e8b91882059611d91f78a5 Gerrit-Change-Number: 25247 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:24:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/meowth: Disable debug consent
by Furquan Shaikh (Code Review) 22 Mar '18

22 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25312 ) Change subject: mainboard/google/meowth: Disable debug consent ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25312/1/src/mainboard/google/zoombini/varia… File src/mainboard/google/zoombini/variants/meowth/devicetree.cb: https://review.coreboot.org/#/c/25312/1/src/mainboard/google/zoombini/varia… PS1, Line 9: DBC over USB 3.0 port only Update this comment too. -- To view, visit https://review.coreboot.org/25312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Gerrit-Change-Number: 25312 Gerrit-PatchSet: 1 Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:23:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/meowth: Disable debug consent
by Vaibhav Shankar (Code Review) 22 Mar '18

22 Mar '18

Vaibhav Shankar has uploaded this change for review. ( https://review.coreboot.org/25312 Change subject: mainboard/google/meowth: Disable debug consent ...................................................................... mainboard/google/meowth: Disable debug consent This patch disables debug consent in the devicetree. When debug conset is set to DBC by default, it prevents some clocks from turning off during S0ix. This blocks S0ix entry. BUG=None TEST=enter S0ix and check if slp_s0 is asserted Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Signed-off-by: Vaibhav Shankar <vaibhav.shankar(a)intel.com> --- M src/mainboard/google/zoombini/variants/meowth/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/25312/1 diff --git a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb index 062c6ec..9e6d95d 100644 --- a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb +++ b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb @@ -7,7 +7,7 @@ register "deep_s5_enable_dc" = "1" # Debug Option, set to DBC over USB 3.0 port only - register "DebugConsent" = "DebugConsent_USB3_DBC" + register "DebugConsent" = "DebugConsent_Disabled" # GPE configuration # Note that GPE events called out in ASL code rely on this -- To view, visit https://review.coreboot.org/25312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f Gerrit-Change-Number: 25312 Gerrit-PatchSet: 1 Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25311 ) Change subject: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal. ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68907/ : FAILURE -- To view, visit https://review.coreboot.org/25311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a Gerrit-Change-Number: 25311 Gerrit-PatchSet: 1 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 00:18:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.
by Shamile Khan (Code Review) 22 Mar '18

22 Mar '18

Shamile Khan has uploaded a new patch set (#2). ( https://review.coreboot.org/25311 ) Change subject: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal. ...................................................................... soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal. BUG=b:76058338 BRANCH=None TEST=Build coreboot for Octopus board. Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a Signed-off-by: Shamile Khan <shamile.khan(a)intel.com> --- M src/soc/intel/apollolake/chip.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25311/2 -- To view, visit https://review.coreboot.org/25311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a Gerrit-Change-Number: 25311 Gerrit-PatchSet: 2 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal.
by Shamile Khan (Code Review) 22 Mar '18

22 Mar '18

Shamile Khan has uploaded this change for review. ( https://review.coreboot.org/25311 Change subject: soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal. ...................................................................... soc/intel/apollolake: Turn off FSP's deassertion of PERST# signal. BUG=b:76058338 BRANCH=None TEST=Build coreboot for Octopus board. Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a Signed-off-by: Shamile Khan <shamile.khan(a)intel.com> --- M src/soc/intel/apollolake/chip.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25311/1 diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index cac2f11..88044d3 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -513,6 +513,17 @@ memcpy(silconfig->PcieRpSelectableDeemphasis, cfg->pcie_rp_deemphasis_enable, sizeof(silconfig->PcieRpSelectableDeemphasis)); + + /* FSP performs a PERST# signal deassertion for PCIe ports with + * the GPIO address specified in these UPDs. Over-ride the default + * addresses with 0 to turn off PERST# signal deassertion. + */ + silconfig->RootPort0Perst = 0; + silconfig->RootPort1Perst = 0; + silconfig->RootPort2Perst = 0; + silconfig->RootPort3Perst = 0; + silconfig->RootPort4Perst = 0; + silconfig->RootPort5Perst = 0; } void __attribute__((weak)) mainboard_devtree_update(struct device *dev) -- To view, visit https://review.coreboot.org/25311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1858c7843d16b6b63fc30762a889916bbb9b781a Gerrit-Change-Number: 25311 Gerrit-PatchSet: 1 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com>

1 0

Change in coreboot[master]: mb/google/zoombini: always report EC is in RO mode
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25298 ) Change subject: mb/google/zoombini: always report EC is in RO mode ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23274/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68905/ : SUCCESS -- To view, visit https://review.coreboot.org/25298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3705bba0bb1f351da79e599566fbffab94428f3 Gerrit-Change-Number: 25298 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 22:56:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018