coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: soc/intel/cannonlake: Clear EMMC timeout when booting from USB
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25290 ) Change subject: soc/intel/cannonlake: Clear EMMC timeout when booting from USB ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68880/ : SUCCESS -- To view, visit https://review.coreboot.org/25290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eef23f637f781b709696951c5bd825530cc1d11 Gerrit-Change-Number: 25290 Gerrit-PatchSet: 8 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 18:14:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL
by Furquan Shaikh (Code Review) 21 Mar '18

21 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25306 ) Change subject: util/ifdtool: Fix region access control for SKL/KBL ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c: https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c@829 PS1, Line 829: PLATFORM_SKLKBL > How about putting different entries as below for SKL and KBL considering different variants like SKL […] Are the values different for each variant? -- To view, visit https://review.coreboot.org/25306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Gerrit-Change-Number: 25306 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 18:13:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL
by Sumeet R Pawnikar (Code Review) 21 Mar '18

21 Mar '18

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/25306 ) Change subject: util/ifdtool: Fix region access control for SKL/KBL ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c: https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c@829 PS1, Line 829: PLATFORM_SKLKBL How about putting different entries as below for SKL and KBL considering different variants like SKL-U, SKL-Y, KBL-U and KBL-Y. case PLATFORM_SKL: case PLATFORM_KBL: -- To view, visit https://review.coreboot.org/25306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Gerrit-Change-Number: 25306 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 18:11:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25306 ) Change subject: util/ifdtool: Fix region access control for SKL/KBL ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23249/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68878/ : SUCCESS -- To view, visit https://review.coreboot.org/25306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Gerrit-Change-Number: 25306 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 17:58:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Define IFD_CHIPSET
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25307 ) Change subject: soc/intel/skylake: Define IFD_CHIPSET ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23250/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68879/ : SUCCESS -- To view, visit https://review.coreboot.org/25307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b2131caa06d6a975e703262931ec0ea519a86aa Gerrit-Change-Number: 25307 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 17:56:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Strip trailing whitespace on DMI 17 part number.
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25302 ) Change subject: Strip trailing whitespace on DMI 17 part number. ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23246/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68876/ : SUCCESS -- To view, visit https://review.coreboot.org/25302 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia10ef434a2377e34ae7a8f733c6465c2f8ee8dfa Gerrit-Change-Number: 25302 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 17:51:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Define IFD_CHIPSET
by Furquan Shaikh (Code Review) 21 Mar '18

21 Mar '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25307 Change subject: soc/intel/skylake: Define IFD_CHIPSET ...................................................................... soc/intel/skylake: Define IFD_CHIPSET This change defines IFD_CHIPSET as sklkbl to allow ifdtool to set the right access control bits for SKL/KBL platforms. BUG=b:76098647 BRANCH=poppy TEST=Verified that the access control bits on KBL platforms are set correctly. Change-Id: I7b2131caa06d6a975e703262931ec0ea519a86aa Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/skylake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/25307/1 diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 34893dc..aac4a8f 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -355,4 +355,8 @@ hex default 0xc35 +config IFD_CHIPSET + string + default "sklkbl" + endif -- To view, visit https://review.coreboot.org/25307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7b2131caa06d6a975e703262931ec0ea519a86aa Gerrit-Change-Number: 25307 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL
by Furquan Shaikh (Code Review) 21 Mar '18

21 Mar '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25306 Change subject: util/ifdtool: Fix region access control for SKL/KBL ...................................................................... util/ifdtool: Fix region access control for SKL/KBL The default values used by ifdtool for setting region access control do not match the expected values for SKL/KBL as per the SPI programming guide. This change adds platform "sklkbl" that sets region access control bits differently for SKL/KBL images. BUG=b:76098647 BRANCH=poppy TEST=Verified that the access control bits on KBL images is set correctly. Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/25306/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 8397f5c..290c777 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -826,6 +826,20 @@ /* TXE can only write Device Expansion */ fmba->flmstr2 |= 0x20 << wr_shift; break; + case PLATFORM_SKLKBL: + /* CPU/BIOS can read descriptor, BIOS and GbE. */ + fmba->flmstr1 |= 0xb << rd_shift; + /* CPU/BIOS can write BIOS and Gbe. */ + fmba->flmstr1 |= 0xa << wr_shift; + /* ME can read descriptor, ME and GbE. */ + fmba->flmstr2 |= 0xd << rd_shift; + /* ME can write ME. */ + fmba->flmstr2 |= 0x4 << wr_shift; + /* GbE can read GbE and descriptor. */ + fmba->flmstr3 |= 0x9 << rd_shift; + /* GbE can write GbE. */ + fmba->flmstr3 |= 0x8 << wr_shift; + break; default: /* CPU/BIOS can read descriptor, BIOS, and GbE. */ fmba->flmstr1 |= 0xb << rd_shift; @@ -1325,6 +1339,8 @@ case 'p': if (!strcmp(optarg, "aplk")) { platform = PLATFORM_APOLLOLAKE; + } else if (!strcmp(optarg, "sklkbl")) { + platform = PLATFORM_SKLKBL; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index cd5af79..ad299a9 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -22,7 +22,8 @@ }; enum platform { - PLATFORM_APOLLOLAKE + PLATFORM_APOLLOLAKE, + PLATFORM_SKLKBL, }; #define LAYOUT_LINELEN 80 -- To view, visit https://review.coreboot.org/25306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Gerrit-Change-Number: 25306 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: include: Update dimm_info documentation
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25301 ) Change subject: include: Update dimm_info documentation ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23245/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68874/ : SUCCESS -- To view, visit https://review.coreboot.org/25301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f2a3a70919c34f17472904323ec5accdfc876be Gerrit-Change-Number: 25301 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 17:17:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd: Fix generating SMBIOS Type 17
by build bot (Jenkins) (Code Review) 21 Mar '18

21 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25304 ) Change subject: soc/amd: Fix generating SMBIOS Type 17 ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23248/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68877/ : SUCCESS -- To view, visit https://review.coreboot.org/25304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I076bc3f965f81a9374c8976da48c7fdce014dc0c Gerrit-Change-Number: 25304 Gerrit-PatchSet: 8 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 17:17:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018