coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: arch/x86/smbios: Strip trailing whitespace on DMI 17 part number.
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25302 ) Change subject: arch/x86/smbios: Strip trailing whitespace on DMI 17 part number. ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23291/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68927/ : SUCCESS -- To view, visit https://review.coreboot.org/25302 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia10ef434a2377e34ae7a8f733c6465c2f8ee8dfa Gerrit-Change-Number: 25302 Gerrit-PatchSet: 9 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 17:13:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd: Print dimm_info and TYPE17_DMI_INFO to help debug incorrect ...
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25303 ) Change subject: soc/amd: Print dimm_info and TYPE17_DMI_INFO to help debug incorrect values ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23292/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68926/ : SUCCESS -- To view, visit https://review.coreboot.org/25303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eac00b9400056357915761287770a400b3f9f8b Gerrit-Change-Number: 25303 Gerrit-PatchSet: 9 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 17:13:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/octopus: Set PNP config to PNP_PERF_POWER
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25310 ) Change subject: mb/octopus: Set PNP config to PNP_PERF_POWER ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23289/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68923/ : SUCCESS -- To view, visit https://review.coreboot.org/25310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2239aa70cb708e6e1c06339ca9d517e7eaa198ed Gerrit-Change-Number: 25310 Gerrit-PatchSet: 4 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 15:18:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/glkrvp: Set PNP config to PNP_PERF_POWER
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25309 ) Change subject: mb/glkrvp: Set PNP config to PNP_PERF_POWER ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68924/ : SUCCESS -- To view, visit https://review.coreboot.org/25309 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia390c0fafe2de64bd9e4ca44e5ed5d904663ae3c Gerrit-Change-Number: 25309 Gerrit-PatchSet: 2 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 15:15:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/octopus: Set PNP config to PNP_PERF_POWER
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25310 ) Change subject: mb/octopus: Set PNP config to PNP_PERF_POWER ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68922/ : ABORTED -- To view, visit https://review.coreboot.org/25310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2239aa70cb708e6e1c06339ca9d517e7eaa198ed Gerrit-Change-Number: 25310 Gerrit-PatchSet: 3 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 15:10:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/pc80/tpm: Add some delay to tis_readresponse()
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25322 ) Change subject: drivers/pc80/tpm: Add some delay to tis_readresponse() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23288/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68921/ : SUCCESS -- To view, visit https://review.coreboot.org/25322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a2f252e72a0bbce51e2863f8e46647b1570ba5 Gerrit-Change-Number: 25322 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 10:26:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/pc80/tpm: Add some delay to tis_readresponse()
by Bill XIE (Code Review) 22 Mar '18

22 Mar '18

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/25322 Change subject: drivers/pc80/tpm: Add some delay to tis_readresponse() ...................................................................... drivers/pc80/tpm: Add some delay to tis_readresponse() Certain TPMs (observed on Infineon SLB9635 installed on revolve 810 g1) seem to need some delay between tis_wait_valid() and tis_has_valid_data(), or tis_has_valid_data() may invalidly return 0, ending the loop immaturely with some bytes left unread, and fail to pass the check below, causing the current command not finalized by tis_command_ready(), and blocking any later tis_wait_ready(). Change-Id: Ic2a2f252e72a0bbce51e2863f8e46647b1570ba5 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/drivers/pc80/tpm/tis.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/25322/1 diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 9802654..0c175dd 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -595,6 +595,12 @@ if (offset == expected_count) break; /* We got all we need */ + /* + * Certain TPMs seem to need some delay between tis_wait_valid() + * and tis_has_valid_data(), or some race condition will occur. + */ + udelay(10); + } while (tis_has_valid_data(locality)); /* * Make sure we indeed read all there was. */ -- To view, visit https://review.coreboot.org/25322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2a2f252e72a0bbce51e2863f8e46647b1570ba5 Gerrit-Change-Number: 25322 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com>

1 0

Change in coreboot[master]: mb/intel/kblrvp8: Add KBLRVP8 support
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25194 ) Change subject: mb/intel/kblrvp8: Add KBLRVP8 support ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23287/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68920/ : SUCCESS -- To view, visit https://review.coreboot.org/25194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I985968d331991884050c3920ec9798cd4cb371c7 Gerrit-Change-Number: 25194 Gerrit-PatchSet: 6 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 07:57:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Define IFD_CHIPSET
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25307 ) Change subject: soc/intel/skylake: Define IFD_CHIPSET ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23286/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68919/ : SUCCESS -- To view, visit https://review.coreboot.org/25307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b2131caa06d6a975e703262931ec0ea519a86aa Gerrit-Change-Number: 25307 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 04:33:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL
by build bot (Jenkins) (Code Review) 22 Mar '18

22 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25306 ) Change subject: util/ifdtool: Fix region access control for SKL/KBL ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23285/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68918/ : SUCCESS -- To view, visit https://review.coreboot.org/25306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3 Gerrit-Change-Number: 25306 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 04:33:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018