build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23676 )
Change subject: util/abuild: Allow use of payloads when not providing a configfile
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67285/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/21832/ : SUCCESS
--
To view, visit https://review.coreboot.org/23676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4368d9609bceb4cf7edb76c10bc0af0cdeb76958
Gerrit-Change-Number: 23676
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 09 Feb 2018 17:06:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23676 )
Change subject: util/abuild: Allow use of payloads when not providing a configfile
......................................................................
Patch Set 1:
providing payloads seems to have some restrictions... with seabios you have no way of adding seavgabios if using native graphic init and tianocore is not provided as an elf binary afaik...
--
To view, visit https://review.coreboot.org/23676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4368d9609bceb4cf7edb76c10bc0af0cdeb76958
Gerrit-Change-Number: 23676
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 09 Feb 2018 17:05:05 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23676
Change subject: util/abuild: Allow use of payloads when not providing a configfile
......................................................................
util/abuild: Allow use of payloads when not providing a configfile
This only worked if a configfile is provided.
Change-Id: I4368d9609bceb4cf7edb76c10bc0af0cdeb76958
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/abuild/abuild
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/23676/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 91c5bf9..e2cad28 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -292,13 +292,15 @@
if [ -z "$config_file" ]; then
create_config "$BUILD_NAME" "$build_dir"
+ local new_config_file="${build_dir}/config.build"
else
local new_config_file="${build_dir}/config.build"
cp "$config_file" "$new_config_file"
- update_config "$BUILD_NAME" "$build_dir" "$new_config_file"
fi
local ret=$?
+ update_config "$BUILD_NAME" "$build_dir" "$new_config_file"
+
# Allow simple "make" in the target directory
local MAKEFILE=$TARGET/${BUILD_NAME}/Makefile
echo "# autogenerated" > "$MAKEFILE"
--
To view, visit https://review.coreboot.org/23676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4368d9609bceb4cf7edb76c10bc0af0cdeb76958
Gerrit-Change-Number: 23676
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>