coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: nb/intel/nehalem: Get rid off device_t
by Elyes HAOUAS (Code Review) 09 Feb '18

09 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23674 to look at the new patch set (#2). Change subject: nb/intel/nehalem: Get rid off device_t ...................................................................... nb/intel/nehalem: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: Idcb8ff4081f2c45427aabb455a70fae1b46bcfc4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/nehalem/northbridge.c 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/23674/2 -- To view, visit https://review.coreboot.org/23674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idcb8ff4081f2c45427aabb455a70fae1b46bcfc4 Gerrit-Change-Number: 23674 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/nehalem: Get rid off device_t
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23674 ) Change subject: nb/intel/nehalem: Get rid off device_t ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67271/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21821/ : SUCCESS -- To view, visit https://review.coreboot.org/23674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb8ff4081f2c45427aabb455a70fae1b46bcfc4 Gerrit-Change-Number: 23674 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:56:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/pineview: Get rid off device_t
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23673 ) Change subject: nb/intel/pineview: Get rid off device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67270/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21820/ : SUCCESS -- To view, visit https://review.coreboot.org/23673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icec2e5f722c1f15493e5861b47f64698250f5813 Gerrit-Change-Number: 23673 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:55:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/nehalem: Get rid off device_t
by Elyes HAOUAS (Code Review) 09 Feb '18

09 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23674 Change subject: nb/intel/nehalem: Get rid off device_t ...................................................................... nb/intel/nehalem: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: Idcb8ff4081f2c45427aabb455a70fae1b46bcfc4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/nehalem/northbridge.c 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/23674/1 diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c index 4dcbfb3..6b8b98e 100644 --- a/src/northbridge/intel/nehalem/gma.c +++ b/src/northbridge/intel/nehalem/gma.c @@ -1080,7 +1080,7 @@ intel_gma_restore_opregion(); } -static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, @@ -1114,7 +1114,7 @@ const struct i915_gpu_controller_info * intel_gma_get_controller_info(void) { - device_t dev = dev_find_slot(0, PCI_DEVFN(0x2,0)); + struct device *dev = dev_find_slot(0, PCI_DEVFN(0x2,0)); if (!dev) { return NULL; } @@ -1122,7 +1122,7 @@ return &chip->gfx; } -static void gma_ssdt(device_t device) +static void gma_ssdt(struct device *device) { const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info(); if (!gfx) { diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index b09460c..aebbd8e 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -87,7 +87,7 @@ #endif } -static void pci_domain_set_resources(device_t dev) +static void pci_domain_set_resources(struct device *dev) { assign_resources(dev->link_list); } @@ -101,7 +101,7 @@ .ops_pci_bus = pci_bus_default_ops, }; -static void mc_read_resources(device_t dev) +static void mc_read_resources(struct device *dev) { uint32_t tseg_base; uint64_t TOUUD; @@ -156,18 +156,18 @@ u32 northbridge_get_tseg_base(void) { - const device_t dev = dev_find_slot(0, PCI_DEVFN(0, 0)); + const struct device *dev = dev_find_slot(0, PCI_DEVFN(0, 0)); return pci_read_config32(dev, TSEG) & ~1; } -static void mc_set_resources(device_t dev) +static void mc_set_resources(struct device *dev) { /* And call the normal set_resources */ pci_dev_set_resources(dev); } -static void intel_set_subsystem(device_t dev, unsigned vendor, unsigned device) +static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, @@ -299,7 +299,7 @@ .device = 0x0044, /* Nehalem */ }; -static void cpu_bus_init(device_t dev) +static void cpu_bus_init(struct device *dev) { initialize_cpus(dev->link_list); } @@ -312,7 +312,7 @@ .scan_bus = 0, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) { -- To view, visit https://review.coreboot.org/23674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idcb8ff4081f2c45427aabb455a70fae1b46bcfc4 Gerrit-Change-Number: 23674 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/i440: Get rid off device_t
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23672 ) Change subject: nb/intel/i440: Get rid off device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67269/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21819/ : SUCCESS -- To view, visit https://review.coreboot.org/23672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd01659f518b7a2b1aaf334fe5b16cfb936b68b7 Gerrit-Change-Number: 23672 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:51:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/fsp_rangeley: Get rid off device_t
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23671 ) Change subject: nb/intel/fsp_rangeley: Get rid off device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67268/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21818/ : SUCCESS -- To view, visit https://review.coreboot.org/23671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b969a5109276d108e6140bad338c74786b967f3 Gerrit-Change-Number: 23671 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:48:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/pineview: Get rid off device_t
by Elyes HAOUAS (Code Review) 09 Feb '18

09 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23673 Change subject: nb/intel/pineview: Get rid off device_t ...................................................................... nb/intel/pineview: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: Icec2e5f722c1f15493e5861b47f64698250f5813 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/pineview/gma.c M src/northbridge/intel/pineview/northbridge.c 2 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/23673/1 diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index d47fc0e..ec332e6 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -74,7 +74,7 @@ static int gtt_setup(u8 *mmiobase) { u32 gttbase; - device_t dev = dev_find_slot(0, PCI_DEVFN(0,0)); + struct device *dev = dev_find_slot(0, PCI_DEVFN(0,0)); gttbase = pci_read_config32(dev, BGSM); printk(BIOS_DEBUG, "gttbase = %08x\n", gttbase); @@ -298,7 +298,7 @@ intel_gma_restore_opregion(); } -static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device) +static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, @@ -312,7 +312,7 @@ const struct i915_gpu_controller_info *intel_gma_get_controller_info(void) { - device_t dev = dev_find_slot(0, PCI_DEVFN(0x2,0)); + struct device *dev = dev_find_slot(0, PCI_DEVFN(0x2,0)); if (!dev) { printk(BIOS_WARNING, "WARNING: Can't find IGD (0,2,0)\n"); return NULL; diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c index ea55974..61b9edb 100644 --- a/src/northbridge/intel/pineview/northbridge.c +++ b/src/northbridge/intel/pineview/northbridge.c @@ -35,7 +35,7 @@ */ static const int legacy_hole_base_k = 0xa0000 / 1024; -static void add_fixed_resources(device_t dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource; @@ -51,7 +51,7 @@ (0x100000 - 0xc0000) >> 10); } -static void mch_domain_read_resources(device_t dev) +static void mch_domain_read_resources(struct device *dev) { u64 tom, touud; u32 tomk, tolud, tseg_sizek; @@ -127,7 +127,7 @@ add_fixed_resources(dev, index); } -static void mch_domain_set_resources(device_t dev) +static void mch_domain_set_resources(struct device *dev) { struct resource *res; @@ -137,7 +137,7 @@ assign_resources(dev->link_list); } -static void mch_domain_init(device_t dev) +static void mch_domain_init(struct device *dev) { u32 reg32; @@ -156,7 +156,7 @@ .acpi_fill_ssdt_generator = generate_cpu_entries, }; -static void cpu_bus_init(device_t dev) +static void cpu_bus_init(struct device *dev) { initialize_cpus(dev->link_list); } @@ -169,7 +169,7 @@ }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) { -- To view, visit https://review.coreboot.org/23673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icec2e5f722c1f15493e5861b47f64698250f5813 Gerrit-Change-Number: 23673 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: set oem_id, oem_table_id fields of acp...
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23670 ) Change subject: mb/google/poppy/variants/nami: set oem_id, oem_table_id fields of acpi_header_t ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67267/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21817/ : SUCCESS -- To view, visit https://review.coreboot.org/23670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513a997f312e2d37d76da0379feb017d1f591f9a Gerrit-Change-Number: 23670 Gerrit-PatchSet: 2 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:46:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: set oem_id, oem_table_id fields of acp...
by Furquan Shaikh (Code Review) 09 Feb '18

09 Feb '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23670 ) Change subject: mb/google/poppy/variants/nami: set oem_id, oem_table_id fields of acpi_header_t ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/23670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513a997f312e2d37d76da0379feb017d1f591f9a Gerrit-Change-Number: 23670 Gerrit-PatchSet: 2 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 07:45:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i440: Get rid off device_t
by Elyes HAOUAS (Code Review) 09 Feb '18

09 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23672 Change subject: nb/intel/i440: Get rid off device_t ...................................................................... nb/intel/i440: Get rid off device_t Use of `device_t` has been abandoned in ramstage Change-Id: Ibd01659f518b7a2b1aaf334fe5b16cfb936b68b7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i440bx/northbridge.c M src/northbridge/intel/i440bx/northbridge.h 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/23672/1 diff --git a/src/northbridge/intel/i440bx/northbridge.c b/src/northbridge/intel/i440bx/northbridge.c index 8e5aa11..1245be6 100644 --- a/src/northbridge/intel/i440bx/northbridge.c +++ b/src/northbridge/intel/i440bx/northbridge.c @@ -12,7 +12,7 @@ #include "northbridge.h" #include "i440bx.h" -static void northbridge_init(device_t dev) +static void northbridge_init(struct device *dev) { printk(BIOS_SPEW, "Northbridge Init\n"); } @@ -32,7 +32,7 @@ .device = 0x7190, }; -static void i440bx_domain_set_resources(device_t dev) +static void i440bx_domain_set_resources(struct device *dev) { device_t mc_dev; uint32_t pci_tolm; @@ -82,7 +82,7 @@ .ops_pci_bus = pci_bus_default_ops, }; -static void cpu_bus_init(device_t dev) +static void cpu_bus_init(struct device *dev) { initialize_cpus(dev->link_list); } diff --git a/src/northbridge/intel/i440bx/northbridge.h b/src/northbridge/intel/i440bx/northbridge.h index 5b721b5..8df5666 100644 --- a/src/northbridge/intel/i440bx/northbridge.h +++ b/src/northbridge/intel/i440bx/northbridge.h @@ -17,6 +17,6 @@ #ifndef NORTHBRIDGE_INTEL_440BX_H #define NORTHBRIDGE_INTEL_440BX_H -extern unsigned int i440bx_scan_root_bus(device_t root, unsigned int max); +extern unsigned int i440bx_scan_root_bus(struct device *root, unsigned int max); #endif /* NORTHBRIDGE_INTEL_440BX_H */ -- To view, visit https://review.coreboot.org/23672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd01659f518b7a2b1aaf334fe5b16cfb936b68b7 Gerrit-Change-Number: 23672 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018