coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: src/mainboard/hp: Add hp pavilion g7-2247us support
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23352 ) Change subject: src/mainboard/hp: Add hp pavilion g7-2247us support ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67313/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21859/ : SUCCESS -- To view, visit https://review.coreboot.org/23352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f91595b0c06d683afb74eb54b3b78bd0458d6a1 Gerrit-Change-Number: 23352 Gerrit-PatchSet: 4 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 02:53:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Explicitely enable Intel SpeedStep Technology
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23684 ) Change subject: purism/librem_skl: Explicitely enable Intel SpeedStep Technology ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67312/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21857/ : SUCCESS -- To view, visit https://review.coreboot.org/23684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387 Gerrit-Change-Number: 23684 Gerrit-PatchSet: 2 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 02:38:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Enable TPM support
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23683 ) Change subject: purism/librem_skl: Enable TPM support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67311/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21858/ : SUCCESS -- To view, visit https://review.coreboot.org/23683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I425654c1c972118aa81c27961246238c2eef782d Gerrit-Change-Number: 23683 Gerrit-PatchSet: 2 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 02:36:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Enable TPM support
by Youness Alaoui (Code Review) 10 Feb '18

10 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23683 to look at the new patch set (#2). Change subject: purism/librem_skl: Enable TPM support ...................................................................... purism/librem_skl: Enable TPM support Change the GPIO to match the TPM-enabled motherboards, and add TPM support in devicetree and enable the config. After changing the GPIO table, the librem 13v2 and librem 15v3 now have the same GPIOs, so use a single gpio.h file instead of one file per variant. Change-Id: I425654c1c972118aa81c27961246238c2eef782d Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_skl/Makefile.inc R src/mainboard/purism/librem_skl/gpio.h M src/mainboard/purism/librem_skl/ramstage.c M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb D src/mainboard/purism/librem_skl/variants/librem15v3/include/variant/gpio.h 7 files changed, 16 insertions(+), 212 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/23683/2 -- To view, visit https://review.coreboot.org/23683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I425654c1c972118aa81c27961246238c2eef782d Gerrit-Change-Number: 23683 Gerrit-PatchSet: 2 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: Add IOMMU support
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23682 ) Change subject: soc/intel/skylake: Add IOMMU support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67308/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21852/ : SUCCESS -- To view, visit https://review.coreboot.org/23682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifadaa11340406d1da0f98813589d20118744cc6f Gerrit-Change-Number: 23682 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:58:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Generate ACPI DMAR table
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23681 ) Change subject: soc/intel/skylake: Generate ACPI DMAR table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67307/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21853/ : SUCCESS -- To view, visit https://review.coreboot.org/23681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea48a349d60bdd2e7d3bc74b4e1036b050d2ae71 Gerrit-Change-Number: 23681 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:57:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/fsp: Fix TPM initialization when vboot is disabled
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23680 ) Change subject: intel/fsp: Fix TPM initialization when vboot is disabled ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67306/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21854/ : SUCCESS -- To view, visit https://review.coreboot.org/23680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43d1aa31a296386c7eab6d997f9b701e9ea0fe5 Gerrit-Change-Number: 23680 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:55:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Explicitely enable Intel SpeedStep Technology
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23684 ) Change subject: purism/librem_skl: Explicitely enable Intel SpeedStep Technology ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67310/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/21856/ : SUCCESS -- To view, visit https://review.coreboot.org/23684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387 Gerrit-Change-Number: 23684 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:54:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Enable TPM support
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23683 ) Change subject: purism/librem_skl: Enable TPM support ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67309/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/21855/ : SUCCESS -- To view, visit https://review.coreboot.org/23683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I425654c1c972118aa81c27961246238c2eef782d Gerrit-Change-Number: 23683 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:53:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: purism/librem_skl: Explicitely enable Intel SpeedStep Technology
by Youness Alaoui (Code Review) 10 Feb '18

10 Feb '18

Youness Alaoui has uploaded this change for review. ( https://review.coreboot.org/23684 Change subject: purism/librem_skl: Explicitely enable Intel SpeedStep Technology ...................................................................... purism/librem_skl: Explicitely enable Intel SpeedStep Technology Enabling Intel SpeedStep Technology ensures the ACPI tables contain the C-states/P-states which are required for the xen-acpi-processor module to be loaded. Without it, the Qubes 4.0-rc4 installer will complain at boot about modules that could not be loaded. The VMX feature was enabled by default by the FSP but a different FSP might have it disabled, so this ensures that VMX is explicitely enabled for the Librem machines. This option however doesn't seem to work in the FSP since VMX doesn't actually get enabled but as long as the features MSR remains unlocked, it's not critical. Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387 Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/23684/1 diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb index e2e2ac0..9ce1d91 100644 --- a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb @@ -7,6 +7,9 @@ register "deep_s5_enable_dc" = "0" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN" + register "eist_enable" = "1" + register "VmxEnable" = "1" + # GPE configuration # Note that GPE events called out in ASL code rely on this # route. i.e. If this route changes then the affected GPE -- To view, visit https://review.coreboot.org/23684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387 Gerrit-Change-Number: 23684 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018