coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE
by build bot (Jenkins) (Code Review) 11 Feb '18

11 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23695 ) Change subject: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67327/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21873/ : ABORTED -- To view, visit https://review.coreboot.org/23695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d6cc61ea29214d338d4c52ff799d6620a9cac7 Gerrit-Change-Number: 23695 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Feb 2018 18:45:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE
by Arthur Heymans (Code Review) 11 Feb '18

11 Feb '18

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/23695 ) Change subject: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE ...................................................................... driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE Some assumptions are made with respect to CONFIG_ROM_SIZE being the actual size of the boot medium, e.g. when automatically creating an fmap with and RW_MRC_CACHE region. With this patch the user is warned when this is detected. Change-Id: Ib5d6cc61ea29214d338d4c52ff799d6620a9cac7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/spi/spi_flash.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/23695/2 -- To view, visit https://review.coreboot.org/23695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5d6cc61ea29214d338d4c52ff799d6620a9cac7 Gerrit-Change-Number: 23695 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE
by Arthur Heymans (Code Review) 11 Feb '18

11 Feb '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23695 Change subject: driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE ...................................................................... driver/spi: Warn when probed SF size differs from CONFIG_ROM_SIZE Some assumptions are made with respect to CONFIG_ROM_SIZE being the actual size of the boot medium, e.g. when automatically creating an fmap with and RW_MRC_CACHE region. It is therefore a good to warn the user when this is not the case. Change-Id: Ib5d6cc61ea29214d338d4c52ff799d6620a9cac7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/spi/spi_flash.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/23695/1 diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index 93335de..b166d2a 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -374,6 +374,10 @@ printk(BIOS_INFO, "SF: Detected %s with sector size 0x%x, total 0x%x\n", flash->name, flash->sector_size, flash->size); + if (flash->size != CONFIG_ROM_SIZE) + printk(BIOS_ERR, "SF size 0x%x does not correspond to" + " CONFIG_ROM_SIZE 0x%x!!", flash->size, + CONFIG_ROM_SIZE); return 0; } -- To view, visit https://review.coreboot.org/23695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5d6cc61ea29214d338d4c52ff799d6620a9cac7 Gerrit-Change-Number: 23695 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS
by build bot (Jenkins) (Code Review) 11 Feb '18

11 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23692 ) Change subject: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67326/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21872/ : SUCCESS -- To view, visit https://review.coreboot.org/23692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892 Gerrit-Change-Number: 23692 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Feb 2018 11:47:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS
by build bot (Jenkins) (Code Review) 11 Feb '18

11 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23692 ) Change subject: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67325/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21871/ : ABORTED -- To view, visit https://review.coreboot.org/23692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892 Gerrit-Change-Number: 23692 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Feb 2018 11:38:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS
by Mike Banon (Code Review) 11 Feb '18

11 Feb '18

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/23692 Change subject: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS ...................................................................... southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS Currently, when no blobs are selected, empty apu/amdfw area (full of 0xFF) is being included to the CBFS - thus wasting 4096 bytes. After this commit apu/amdfw will be created only if there are blobs chosen to be installed Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M src/southbridge/amd/agesa/hudson/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/23692/1 diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 2bf6f02..4ac48f3 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -48,6 +48,8 @@ pci$(stripped_ahci_rom_id).rom-required := Hudson AHCI Option ROM (Contact your AMD representative) endif +ifneq ($(CONFIG_HUDSON_XHCI_FWM_FILE)$(CONFIG_HUDSON_IMC_FWM_FILE)$(CONFIG_HUDSON_GEC_FWM_FILE),) + add_opt_prefix=$(if $(call strip_quotes, $(1)), $(2) $(call strip_quotes, $(1)), ) OPT_HUDSON_XHCI_FWM_FILE=$(call add_opt_prefix, $(CONFIG_HUDSON_XHCI_FWM_FILE), --xhci) @@ -71,3 +73,5 @@ apu/amdfw-file := $(obj)/amdfw.rom apu/amdfw-position := $(HUDSON_FWM_POSITION) apu/amdfw-type := raw + +endif -- To view, visit https://review.coreboot.org/23692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892 Gerrit-Change-Number: 23692 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>

1 0

Change in coreboot[master]: drivers/adau7002: Add driver for handling ADAU7002
by build bot (Jenkins) (Code Review) 11 Feb '18

11 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23659 ) Change subject: drivers/adau7002: Add driver for handling ADAU7002 ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67324/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21870/ : SUCCESS -- To view, visit https://review.coreboot.org/23659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b64c8e1cbc0a68984482a7d496f8c4498cb6cbe Gerrit-Change-Number: 23659 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Dylan Reid <dgreid(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Feb 2018 00:06:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Generate ACPI DMAR table
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21588 ) Change subject: soc/intel/skylake: Generate ACPI DMAR table ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67323/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21869/ : SUCCESS -- To view, visit https://review.coreboot.org/21588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8176401dd19aee7ad09a8a145b7a3801fe5b2ae1 Gerrit-Change-Number: 21588 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 18:23:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Enable VT-d and X2APIC
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21597 ) Change subject: soc/intel/skylake: Enable VT-d and X2APIC ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67322/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21868/ : SUCCESS -- To view, visit https://review.coreboot.org/21597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77f87c385736615c127143760bbd144f97986b37 Gerrit-Change-Number: 21597 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 18:21:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] soc/intel/skylake: Hook up libgfxinit
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20113 ) Change subject: [WIP] soc/intel/skylake: Hook up libgfxinit ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67321/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21867/ : SUCCESS -- To view, visit https://review.coreboot.org/20113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79fbfed7732cf02d054530ea7ec0d34de32836ba Gerrit-Change-Number: 20113 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 18:20:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018