build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23173 )
Change subject: arch/riscv: Align trap_entry to 4 bytes, as required by spec
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67341/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/21886/ : SUCCESS
--
To view, visit https://review.coreboot.org/23173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83ea23e2c8f984775985ae7d61f80ad75286baaa
Gerrit-Change-Number: 23173
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 11:35:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22735 )
Change subject: security/tpm: Implement hashing function in TSS
......................................................................
Patch Set 26:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67337/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/21882/ : SUCCESS
--
To view, visit https://review.coreboot.org/22735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84513e8cbfe1ef11f495b873de0331178915c59
Gerrit-Change-Number: 22735
Gerrit-PatchSet: 26
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 11:26:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23171 )
Change subject: payloads/external/GRUB2: Build only for supported architectures
......................................................................
Patch Set 6:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67335/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/21880/ : SUCCESS
--
To view, visit https://review.coreboot.org/23171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef2020b2acb4cd008a57a2372734674f8b84a36
Gerrit-Change-Number: 23171
Gerrit-PatchSet: 6
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 09:21:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/23699
Change subject: soc/intel/cannonlake: Use common PCR ASL
......................................................................
soc/intel/cannonlake: Use common PCR ASL
Switch to use common version of PCR asl.
BUG=NONE
TEST=Boot up into OS.
Change-Id: I4975704434d4743bcc0fb6062115da349166c3a6
Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com>
---
D src/soc/intel/cannonlake/acpi/pcr.asl
M src/soc/intel/cannonlake/acpi/southbridge.asl
2 files changed, 1 insertion(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/23699/1
diff --git a/src/soc/intel/cannonlake/acpi/pcr.asl b/src/soc/intel/cannonlake/acpi/pcr.asl
deleted file mode 100644
index 7915226..0000000
--- a/src/soc/intel/cannonlake/acpi/pcr.asl
+++ /dev/null
@@ -1,23 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 Google Inc.
- * Copyright (C) 2017 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <intelblocks/pcr.h>
-
-Method (PCRB, 1, NotSerialized)
-{
- Return (Add (CONFIG_PCR_BASE_ADDRESS,
- ShiftLeft (Arg0, PCR_PORTID_SHIFT)))
-}
diff --git a/src/soc/intel/cannonlake/acpi/southbridge.asl b/src/soc/intel/cannonlake/acpi/southbridge.asl
index d0d03f0..8d74da9 100644
--- a/src/soc/intel/cannonlake/acpi/southbridge.asl
+++ b/src/soc/intel/cannonlake/acpi/southbridge.asl
@@ -23,7 +23,7 @@
#include "scs.asl"
/* PCR access */
-#include "pcr.asl"
+#include <soc/intel/common/acpi/pcr.asl>
/* GPIO controller */
#include "gpio.asl"
--
To view, visit https://review.coreboot.org/23699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4975704434d4743bcc0fb6062115da349166c3a6
Gerrit-Change-Number: 23699
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>