coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23686 ) Change subject: libpayload/drivers/usb/uhci: Fix regression ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67316/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21860/ : SUCCESS -- To view, visit https://review.coreboot.org/23686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3 Gerrit-Change-Number: 23686 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 11:19:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix infinite loop
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23687 ) Change subject: libpayload/drivers/usb/uhci: Fix infinite loop ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67315/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21861/ : SUCCESS -- To view, visit https://review.coreboot.org/23687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic652311e995e7addd807d2dda8e1c8f385a0d45c Gerrit-Change-Number: 23687 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 11:17:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb: Fix broken retry counter
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23688 ) Change subject: libpayload/drivers/usb: Fix broken retry counter ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67314/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21862/ : SUCCESS -- To view, visit https://review.coreboot.org/23688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47 Gerrit-Change-Number: 23688 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 11:16:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/drivers/usb: Fix leaks
by Patrick Rudolph (Code Review) 10 Feb '18

10 Feb '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23689 Change subject: libpayload/drivers/usb: Fix leaks ...................................................................... libpayload/drivers/usb: Fix leaks Don't leak buffers on device detach. Tested on Lenovo T500 using UHCI controller by attaching and detaching USB devices a few hundred times. Change-Id: Ib2d80dd4590aa0dacdf2da3b614c6505c931d0be Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/drivers/usb/usb_dev.c M payloads/libpayload/drivers/usb/usbhid.c M payloads/libpayload/drivers/usb/usbmsc.c 4 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/23689/1 diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index 906df84..5d36585 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -669,6 +669,13 @@ { if (usb_generic_remove) usb_generic_remove(dev); + + if (dev->descriptor) + free(dev->descriptor); + dev->descriptor = 0; + if (dev->configuration) + free(dev->configuration); + dev->configuration = 0; } void diff --git a/payloads/libpayload/drivers/usb/usb_dev.c b/payloads/libpayload/drivers/usb/usb_dev.c index 9a0aecd..096c072 100644 --- a/payloads/libpayload/drivers/usb/usb_dev.c +++ b/payloads/libpayload/drivers/usb/usb_dev.c @@ -34,6 +34,8 @@ { if (dev->descriptor != 0) free (dev->descriptor); + if (dev->configuration != 0) + free(dev->configuration); usb_nop_init (dev); dev->address = -1; dev->hub = -1; @@ -50,6 +52,7 @@ usb_nop_init (usbdev_t *dev) { dev->descriptor = 0; + dev->configuration = 0; dev->destroy = usb_nop_destroy; dev->poll = usb_nop_poll; } diff --git a/payloads/libpayload/drivers/usb/usbhid.c b/payloads/libpayload/drivers/usb/usbhid.c index 3100d37..08dae24 100644 --- a/payloads/libpayload/drivers/usb/usbhid.c +++ b/payloads/libpayload/drivers/usb/usbhid.c @@ -80,7 +80,17 @@ &dev->endpoints[i], HID_INST(dev)->queue); HID_INST(dev)->queue = NULL; } + if (HID_INST(dev)->descriptor) + free(HID_INST(dev)->descriptor); + HID_INST(dev)->descriptor = 0; + free (dev->data); + if (dev->descriptor) + free(dev->descriptor); + dev->descriptor = 0; + if (dev->configuration) + free(dev->configuration); + dev->configuration = 0; } /* keybuffer is global to all USB keyboards */ diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c index 2c7cbe5..866d23d 100644 --- a/payloads/libpayload/drivers/usb/usbmsc.c +++ b/payloads/libpayload/drivers/usb/usbmsc.c @@ -91,6 +91,12 @@ free (dev->data); } dev->data = 0; + if (dev->descriptor) + free(dev->descriptor); + dev->descriptor = 0; + if (dev->configuration) + free(dev->configuration); + dev->configuration = 0; } const int DEV_RESET = 0xff; -- To view, visit https://review.coreboot.org/23689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2d80dd4590aa0dacdf2da3b614c6505c931d0be Gerrit-Change-Number: 23689 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: libpayload/drivers/usb: Fix broken retry counter
by Patrick Rudolph (Code Review) 10 Feb '18

10 Feb '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23688 Change subject: libpayload/drivers/usb: Fix broken retry counter ...................................................................... libpayload/drivers/usb: Fix broken retry counter Exit on first sucessful CONTROL transfer instead of doing GET_DESCRIPTOR_TRIES iterations. Tested on Lenovo T500 using UHCI controller. Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/usb/usb.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/23688/1 diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index bb42f89..906df84 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -173,10 +173,11 @@ ret = dev->controller->control(dev, IN, sizeof(dr), &dr, len, data); - if (ret) + + if (ret != len) udelay(10); else - return 0; + return len; } return ret; } -- To view, visit https://review.coreboot.org/23688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47 Gerrit-Change-Number: 23688 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix infinite loop
by Patrick Rudolph (Code Review) 10 Feb '18

10 Feb '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23687 Change subject: libpayload/drivers/usb/uhci: Fix infinite loop ...................................................................... libpayload/drivers/usb/uhci: Fix infinite loop Libpayload and the libpayload-client might not handle some USB devices at all. The current UHCI implementation does find an unattached device, and tries to load a driver again and again, which will not happen for unsupported devices. Only handle port change events, and port disconnect events, like it's done on other HCI controllers. Tested on Lenovo T500 using UHCI controller. Devices are found on startup and hot(un)plugging is still working. Change-Id: Ic652311e995e7addd807d2dda8e1c8f385a0d45c Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/usb/uhci_rh.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/23687/1 diff --git a/payloads/libpayload/drivers/usb/uhci_rh.c b/payloads/libpayload/drivers/usb/uhci_rh.c index e08cce1..79ad8fb 100644 --- a/payloads/libpayload/drivers/usb/uhci_rh.c +++ b/payloads/libpayload/drivers/usb/uhci_rh.c @@ -145,14 +145,14 @@ u16 stored, real; stored = (RH_INST (dev)->port[0] == -1); - real = ((uhci_reg_read16 (dev->controller, PORTSC1) & 1) == 0); + real = ((uhci_reg_read16(dev->controller, PORTSC1) & 8) == 0); if (stored != real) { usb_debug("change on port 1\n"); return 1; } stored = (RH_INST (dev)->port[1] == -1); - real = ((uhci_reg_read16 (dev->controller, PORTSC2) & 1) == 0); + real = ((uhci_reg_read16(dev->controller, PORTSC2) & 8) == 0); if (stored != real) { usb_debug("change on port 2\n"); return 2; -- To view, visit https://review.coreboot.org/23687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic652311e995e7addd807d2dda8e1c8f385a0d45c Gerrit-Change-Number: 23687 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression
by Patrick Rudolph (Code Review) 10 Feb '18

10 Feb '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/23686 Change subject: libpayload/drivers/usb/uhci: Fix regression ...................................................................... libpayload/drivers/usb/uhci: Fix regression Commit e9738dbe "Make USB transfer functions return amount of bytes" introduced a regression on all UHCI controllers. Instead of returning the amount of bytes processed, it returned zero on success. Fixes infinite usb_poll loop on Lenovo T500 using UHCI controller. Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/libpayload/drivers/usb/uhci.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23686/1 diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c index cdba3de..c2a0beb 100644 --- a/payloads/libpayload/drivers/usb/uhci.c +++ b/payloads/libpayload/drivers/usb/uhci.c @@ -315,6 +315,7 @@ int count = (2 + (dalen + mlen - 1) / mlen); unsigned short req = ((unsigned short *) devreq)[0]; int i; + int result = dalen; td_t *tds = memalign (16, sizeof (td_t) * count); memset (tds, 0, sizeof (td_t) * count); count--; /* to compensate for 0-indexed array */ @@ -367,10 +368,7 @@ td_t *td = wait_for_completed_qh (dev->controller, UHCI_INST (dev->controller)-> qh_data); - int result; - if (td == 0) { - result = 0; - } else { + if (td) { usb_debug ("control packet, req %x\n", req); td_dump (td); result = -1; -- To view, visit https://review.coreboot.org/23686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3 Gerrit-Change-Number: 23686 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: intel/fsp: Fix TPM initialization when vboot is disabled
by Arthur Heymans (Code Review) 10 Feb '18

10 Feb '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23680 ) Change subject: intel/fsp: Fix TPM initialization when vboot is disabled ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23680/1/src/drivers/intel/fsp1_1/romstage.c File src/drivers/intel/fsp1_1/romstage.c: https://review.coreboot.org/#/c/23680/1/src/drivers/intel/fsp1_1/romstage.c… PS1, Line 175: !IS_ENABLED(CONFIG_RESUME_PATH_SAME_AS_BOOT) simply remove this line? it is always 0... -- To view, visit https://review.coreboot.org/23680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43d1aa31a296386c7eab6d997f9b701e9ea0fe5 Gerrit-Change-Number: 23680 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 08:30:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: Generate ACPI DMAR table
by Matt DeVillier (Code Review) 10 Feb '18

10 Feb '18

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/23681 ) Change subject: soc/intel/skylake: Generate ACPI DMAR table ...................................................................... Patch Set 1: Code-Review+1 verified along with 23682 on Librem13v2 running Qubes 4.0-rc4 -- To view, visit https://review.coreboot.org/23681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea48a349d60bdd2e7d3bc74b4e1036b050d2ae71 Gerrit-Change-Number: 23681 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 06:32:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Add IOMMU support
by Matt DeVillier (Code Review) 10 Feb '18

10 Feb '18

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/23682 ) Change subject: soc/intel/skylake: Add IOMMU support ...................................................................... Patch Set 1: Code-Review+1 verified along with 23681 on Librem13v2 running Qubes 4.0-rc4 -- To view, visit https://review.coreboot.org/23682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifadaa11340406d1da0f98813589d20118744cc6f Gerrit-Change-Number: 23682 Gerrit-PatchSet: 1 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 06:31:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018