build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23856 )
Change subject: tint: introduce the new tint build system with checksum verification
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67841/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/22335/ : SUCCESS
--
To view, visit https://review.coreboot.org/23856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290
Gerrit-Change-Number: 23856
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:30:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23853 )
Change subject: tint: make it possible to reboot by pressing 'q' key two times
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67839/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/22333/ : SUCCESS
--
To view, visit https://review.coreboot.org/23853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56d639fa8e563047fb3d2723695626a449ead40
Gerrit-Change-Number: 23853
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:26:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/23855
Change subject: tint: change the tint download link from HTTP Debian to HTTPS FSF
......................................................................
tint: change the tint download link from HTTP Debian to HTTPS FSF
Last time there was a request to change a link from HTTP to HTTPS.
I haven't found a similar HTTPS link at the Debian server and thought
it is a good idea to take it from the Free Software Foundation server
Change-Id: I55147ee2668de03ba6e9feb84936de24b2a001df
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
M payloads/external/tint/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/23855/1
diff --git a/payloads/external/tint/Makefile b/payloads/external/tint/Makefile
index 5ab8974..253bfea 100644
--- a/payloads/external/tint/Makefile
+++ b/payloads/external/tint/Makefile
@@ -1,4 +1,4 @@
-project_url=http://http.debian.net/debian/pool/main/t/tint/tint_0.04+nmu1.tar.gz
+project_url=https://mirror.fsf.org/trisquel/pool/main/t/tint/tint_0.04+nmu1.tar.gz
archive_name=tint_0.04+nmu1.tar.gz
unexport KCONFIG_AUTOHEADER
--
To view, visit https://review.coreboot.org/23855
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55147ee2668de03ba6e9feb84936de24b2a001df
Gerrit-Change-Number: 23855
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/23854
Change subject: tint: fix the "Paused - Press any key to continue" message for pause
......................................................................
tint: fix the "Paused - Press any key to continue" message for pause
Earlier this message has not been shown even at the corner of screen.
This fixes it by refreshing the screen, and moves it to the center
Change-Id: If4e33e884c00c17f19ab330167d9293c8396ff3e
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
M payloads/external/tint/libpayload_tint.patch
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/23854/1
diff --git a/payloads/external/tint/libpayload_tint.patch b/payloads/external/tint/libpayload_tint.patch
index a21eabf..bb19718 100644
--- a/payloads/external/tint/libpayload_tint.patch
+++ b/payloads/external/tint/libpayload_tint.patch
@@ -376,7 +376,25 @@
rand_init (); /* must be called before engine_init () */
engine_init (&engine,score_function); /* must be called before using engine.curshape */
finished = shownext = FALSE;
-@@ -673,11 +692,31 @@ int main (int argc,char *argv[])
+@@ -632,13 +651,15 @@ int main (int argc,char *argv[])
+ /* pause */
+ case 'p':
+ out_setcolor (COLOR_WHITE,COLOR_BLACK);
+- out_gotoxy ((out_width () - 34) / 2,out_height () - 2);
++ out_gotoxy ((out_width () - 34) / 2,out_height () / 2);
+ out_printf ("Paused - Press any key to continue");
++ refresh ();
+ while ((ch = in_getch ()) == ERR) ; /* Wait for a key to be pressed */
+ in_flush (); /* Clear keyboard buffer */
+- out_gotoxy ((out_width () - 34) / 2,out_height () - 2);
++ out_gotoxy ((out_width () - 34) / 2,out_height () / 2);
+ out_printf (" ");
++ refresh ();
+ break;
+ /* unknown keypress */
+ default:
+ out_beep ();
+@@ -673,11 +694,31 @@ int main (int argc,char *argv[])
/* Restore console settings and exit */
io_close ();
+#if 0
--
To view, visit https://review.coreboot.org/23854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4e33e884c00c17f19ab330167d9293c8396ff3e
Gerrit-Change-Number: 23854
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/23853
Change subject: tint: make it possible to reboot by pressing 'q' key two times
......................................................................
tint: make it possible to reboot by pressing 'q' key two times
Earlier it was impossible to exit without pressing the power button
Change-Id: Ia56d639fa8e563047fb3d2723695626a449ead40
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
M payloads/external/tint/libpayload_tint.patch
1 file changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23853/1
diff --git a/payloads/external/tint/libpayload_tint.patch b/payloads/external/tint/libpayload_tint.patch
index b743b2f..a21eabf 100644
--- a/payloads/external/tint/libpayload_tint.patch
+++ b/payloads/external/tint/libpayload_tint.patch
@@ -376,7 +376,7 @@
rand_init (); /* must be called before engine_init () */
engine_init (&engine,score_function); /* must be called before using engine.curshape */
finished = shownext = FALSE;
-@@ -673,11 +692,20 @@ int main (int argc,char *argv[])
+@@ -673,11 +692,31 @@ int main (int argc,char *argv[])
/* Restore console settings and exit */
io_close ();
+#if 0
@@ -389,9 +389,20 @@
savescores (GETSCORE (engine.score));
}
+#endif
-+ printf("Bye.\n");
++ printf("Press 'q' to reboot...\n");
+ refresh();
-+ for(;;); //halt();
++ for (;;) {
++ in_flush ();
++ while ((ch = in_getch ()) == ERR) ; /* Wait for a key to be pressed */
++ if (ch == 'q') { /* reboot */
++ outb(0x6, 0xcf9);
++ for(;;); //halt();
++ }
++ else {
++ in_flush ();
++ }
++ }
++
+#if 0
exit (EXIT_SUCCESS);
+#endif
--
To view, visit https://review.coreboot.org/23853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56d639fa8e563047fb3d2723695626a449ead40
Gerrit-Change-Number: 23853
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>