coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: ec/google/wilco/acpi: Fix issues and clean up
by Duncan Laurie (Code Review) 03 Dec '18

03 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29760 ) Change subject: ec/google/wilco/acpi: Fix issues and clean up ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic65ebbb6a6151444c47b4aeff7429e186856c49a Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 16:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Add DPTF ACPI code
by Duncan Laurie (Code Review) 03 Dec '18

03 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29759 ) Change subject: soc/intel/cannonlake: Add DPTF ACPI code ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43c2f8dd7281d3e9f791ab01478ee7823fd6b128 Gerrit-Change-Number: 29759 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 16:09:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: smmstore: make smmstore's SMM handler code follow everything else
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30023 Change subject: smmstore: make smmstore's SMM handler code follow everything else ...................................................................... smmstore: make smmstore's SMM handler code follow everything else Instead of SMMSTORE_APM_CNT use APM_CNT_SMMSTORE and define it in cpu/x86/smm.h Change-Id: Iabc0c9662284ed3ac2933001e64524011a5bf420 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/include/cpu/x86/smm.h M src/include/smmstore.h M src/soc/intel/common/block/smm/smihandler.c 3 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/30023/1 diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 857ab35..576449d 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -473,6 +473,7 @@ #define APM_CNT_GNVS_UPDATE 0xea #define APM_CNT_FINALIZE 0xcb #define APM_CNT_LEGACY 0xcc +#define APM_CNT_SMMSTORE 0xed #define APM_CNT_ELOG_GSMI 0xef #define APM_STS 0xb3 diff --git a/src/include/smmstore.h b/src/include/smmstore.h index 685a425..a535c5b 100644 --- a/src/include/smmstore.h +++ b/src/include/smmstore.h @@ -19,8 +19,6 @@ #include <stddef.h> #include <stdint.h> -#define SMMSTORE_APM_CNT 0xed - #define SMMSTORE_RET_SUCCESS 0 #define SMMSTORE_RET_FAILURE 1 #define SMMSTORE_RET_UNSUPPORTED 2 diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 093c50e..2ffc00f 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -301,7 +301,7 @@ void *io_smi; uint32_t reg_ebx; - io_smi = find_save_state(save_state_ops, SMMSTORE_APM_CNT); + io_smi = find_save_state(save_state_ops, APM_CNT_SMMSTORE); if (!io_smi) return; /* Command and return value in EAX */ @@ -391,7 +391,7 @@ if (IS_ENABLED(CONFIG_ELOG_GSMI)) southbridge_smi_gsmi(save_state_ops); break; - case SMMSTORE_APM_CNT: + case APM_CNT_SMMSTORE: if (IS_ENABLED(CONFIG_SMMSTORE)) southbridge_smi_store(save_state_ops); break; -- To view, visit https://review.coreboot.org/c/coreboot/+/30023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc0c9662284ed3ac2933001e64524011a5bf420 Gerrit-Change-Number: 30023 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: elog: make elog's SMM handler code follow everything else
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30022 Change subject: elog: make elog's SMM handler code follow everything else ...................................................................... elog: make elog's SMM handler code follow everything else Instead of ELOG_GSMI_APM_CNT use APM_CNT_ELOG_GSMI and define it in cpu/x86/smm.h Change-Id: I3a3e2f823c91b475d1e15b8c20e9cf5f3fd9de83 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/include/cpu/x86/smm.h M src/include/elog.h M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/smihandler.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/fsp_baytrail/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 11 files changed, 19 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/30022/1 diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 379b512..857ab35 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -473,6 +473,7 @@ #define APM_CNT_GNVS_UPDATE 0xea #define APM_CNT_FINALIZE 0xcb #define APM_CNT_LEGACY 0xcc +#define APM_CNT_ELOG_GSMI 0xef #define APM_STS 0xb3 /* SMI handler function prototypes */ diff --git a/src/include/elog.h b/src/include/elog.h index 8aecf2c..31891e0 100644 --- a/src/include/elog.h +++ b/src/include/elog.h @@ -16,9 +16,6 @@ #ifndef ELOG_H_ #define ELOG_H_ -/* SMI command code for GSMI event logging */ -#define ELOG_GSMI_APM_CNT 0xEF - #define MAX_EVENT_SIZE 0x7F /* End of log */ diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c index a5e66a8..a662bc5d 100644 --- a/src/soc/amd/stoneyridge/smihandler.c +++ b/src/soc/amd/stoneyridge/smihandler.c @@ -72,7 +72,7 @@ amd64_smm_state_save_area_t *io_smi; u32 reg_ebx; - io_smi = find_save_state(ELOG_GSMI_APM_CNT); + io_smi = find_save_state(APM_CNT_ELOG_GSMI); if (!io_smi) return; /* Command and return value in EAX */ @@ -101,7 +101,7 @@ reg32 &= ~(1 << 0); /* clear SCI_EN */ acpi_write32(MMIO_ACPI_PM1_CNT_BLK, reg32); break; - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: if (IS_ENABLED(CONFIG_ELOG_GSMI)) southbridge_smi_gsmi(); break; diff --git a/src/soc/intel/baytrail/smihandler.c b/src/soc/intel/baytrail/smihandler.c index c222739..3f8727d 100644 --- a/src/soc/intel/baytrail/smihandler.c +++ b/src/soc/intel/baytrail/smihandler.c @@ -214,7 +214,7 @@ u32 *ret, *param; uint8_t sub_command; em64t100_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -347,7 +347,7 @@ } break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c index edbb766..a4d2d88 100644 --- a/src/soc/intel/braswell/smihandler.c +++ b/src/soc/intel/braswell/smihandler.c @@ -263,7 +263,7 @@ u32 *ret, *param; uint8_t sub_command; em64t100_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -344,7 +344,7 @@ } break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/soc/intel/broadwell/smihandler.c b/src/soc/intel/broadwell/smihandler.c index 24f6a3d..64a315d 100644 --- a/src/soc/intel/broadwell/smihandler.c +++ b/src/soc/intel/broadwell/smihandler.c @@ -300,7 +300,7 @@ u32 *ret, *param; u8 sub_command; em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -374,7 +374,7 @@ } break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 0832bb5..093c50e 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -279,7 +279,7 @@ void *io_smi = NULL; uint32_t reg_ebx; - io_smi = find_save_state(save_state_ops, ELOG_GSMI_APM_CNT); + io_smi = find_save_state(save_state_ops, APM_CNT_ELOG_GSMI); if (!io_smi) return; /* Command and return value in EAX */ @@ -387,7 +387,7 @@ printk(BIOS_DEBUG, "SMI#: Setting GNVS to %p\n", gnvs); } break; - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: if (IS_ENABLED(CONFIG_ELOG_GSMI)) southbridge_smi_gsmi(save_state_ops); break; diff --git a/src/soc/intel/fsp_baytrail/smihandler.c b/src/soc/intel/fsp_baytrail/smihandler.c index 48c828b..e8021ce 100644 --- a/src/soc/intel/fsp_baytrail/smihandler.c +++ b/src/soc/intel/fsp_baytrail/smihandler.c @@ -212,7 +212,7 @@ u32 *ret, *param; uint8_t sub_command; em64t100_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -274,7 +274,7 @@ } break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index 0ad400c..6347ad6 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -249,7 +249,7 @@ u32 *ret, *param; u8 sub_command; em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -316,7 +316,7 @@ mainboard_finalized = 1; break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c index b70273c..e510f19 100644 --- a/src/southbridge/intel/ibexpeak/smihandler.c +++ b/src/southbridge/intel/ibexpeak/smihandler.c @@ -537,7 +537,7 @@ u32 *ret, *param; u8 sub_command; em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -604,7 +604,7 @@ } break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index a3965d0..72298f3 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -253,7 +253,7 @@ u32 *ret, *param; u8 sub_command; em64t101_smm_state_save_area_t *io_smi = - smi_apmc_find_state_save(ELOG_GSMI_APM_CNT); + smi_apmc_find_state_save(APM_CNT_ELOG_GSMI); if (!io_smi) return; @@ -333,7 +333,7 @@ usb_xhci_route_all(); break; #if IS_ENABLED(CONFIG_ELOG_GSMI) - case ELOG_GSMI_APM_CNT: + case APM_CNT_ELOG_GSMI: southbridge_smi_gsmi(); break; #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/30022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a3e2f823c91b475d1e15b8c20e9cf5f3fd9de83 Gerrit-Change-Number: 30022 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: drivers/smmstore: Allow using raw FMAP regions
by build bot (Jenkins) (Code Review) 03 Dec '18

03 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29991 ) Change subject: drivers/smmstore: Allow using raw FMAP regions ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29991/6/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c: https://review.coreboot.org/#/c/29991/6/src/drivers/smmstore/store.c@73 PS6, Line 73: if (fmap_locate_area_as_rdev_rw(CONFIG_SMMSTORE_REGION, rstore)) { line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/29991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c2b9b3a0ed16b2d37e6a97e33c671fb54df8de0 Gerrit-Change-Number: 29991 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 15:02:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: cpu/intel/fsp_model_406dx: Drop dead microcode reference
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29931 ) Change subject: cpu/intel/fsp_model_406dx: Drop dead microcode reference ...................................................................... cpu/intel/fsp_model_406dx: Drop dead microcode reference The referenced Kconfig symbols don't exist (anymore?). Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/29931 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Guckian Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/cpu/intel/fsp_model_406dx/Makefile.inc 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved David Guckian: Looks good to me, but someone else must approve diff --git a/src/cpu/intel/fsp_model_406dx/Makefile.inc b/src/cpu/intel/fsp_model_406dx/Makefile.inc index d82ddd6..26f4633 100644 --- a/src/cpu/intel/fsp_model_406dx/Makefile.inc +++ b/src/cpu/intel/fsp_model_406dx/Makefile.inc @@ -19,8 +19,4 @@ ramstage-y += acpi.c -ifeq ($(CONFIG_HAVE_CPU_MICROCODE_FILE), y) -cpu_microcode_bins += $(call strip_quotes,$(CONFIG_CPU_MICROCODE_FILE)) -endif - CPPFLAGS_romstage += -I$(src)/cpu/intel/fsp_model_406dx -- To view, visit https://review.coreboot.org/c/coreboot/+/29931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331 Gerrit-Change-Number: 29931 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Fei Wang Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: cpu/x86/lapic: Link apic_timer.c into SMM
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30020 ) Change subject: cpu/x86/lapic: Link apic_timer.c into SMM ...................................................................... Patch Set 2: /cb-build/coreboot-gerrit.0/HP_PAVILION_M6_1035DX/smm/cpu/x86/lapic/apic_timer.o: In function `udelay': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/x86/lapic/apic_timer.c:118: multiple definition of `udelay' /cb-build/coreboot-gerrit.0/HP_PAVILION_M6_1035DX/smm/cpu/amd/agesa/family15tn/udelay.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/amd/agesa/family15tn/udelay.c:30: first defined here -- To view, visit https://review.coreboot.org/c/coreboot/+/30020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14919f89b226b4d5185e49ae857e7dd61bbccce Gerrit-Change-Number: 30020 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP]sb/intel/common/smihandler: Hook up smmstore
by build bot (Jenkins) (Code Review) 03 Dec '18

03 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30012 ) Change subject: [WIP]sb/intel/common/smihandler: Hook up smmstore ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/30012/4/src/southbridge/intel/common/smihan… File src/southbridge/intel/common/smihandler.c: https://review.coreboot.org/#/c/30012/4/src/southbridge/intel/common/smihan… PS4, Line 287: io_smi->rax = ret; code indent should use tabs where possible https://review.coreboot.org/#/c/30012/4/src/southbridge/intel/common/smihan… PS4, Line 287: io_smi->rax = ret; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/30012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b87f3dcb898656ad31478820dd5153e4053cb2 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP]sb/intel/common/smihandler: Hook up smmstore
by Arthur Heymans (Code Review) 03 Dec '18

03 Dec '18

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30012 to look at the new patch set (#4). Change subject: [WIP]sb/intel/common/smihandler: Hook up smmstore ...................................................................... [WIP]sb/intel/common/smihandler: Hook up smmstore TESTED on Asus P5QC Change-Id: I20b87f3dcb898656ad31478820dd5153e4053cb2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/common/Kconfig M src/southbridge/intel/common/smihandler.c 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/30012/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b87f3dcb898656ad31478820dd5153e4053cb2 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: cpu/x86/lapic: Link apic_timer.c into SMM
by Arthur Heymans (Code Review) 03 Dec '18

03 Dec '18

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30020 to look at the new patch set (#2). Change subject: cpu/x86/lapic: Link apic_timer.c into SMM ...................................................................... cpu/x86/lapic: Link apic_timer.c into SMM This provides udelay() and a monotonic timer to SMM. Also remove the custom implementation on i945. Change-Id: Ic14919f89b226b4d5185e49ae857e7dd61bbccce Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/lapic/Makefile.inc M src/northbridge/intel/i945/Makefile.inc D src/northbridge/intel/i945/udelay.c 3 files changed, 1 insertion(+), 79 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/30020/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14919f89b226b4d5185e49ae857e7dd61bbccce Gerrit-Change-Number: 30020 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018