coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: sb/intel/lynxpoint/usb_{e, x}hci.c: Don't use device_t
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29932 ) Change subject: sb/intel/lynxpoint/usb_{e,x}hci.c: Don't use device_t ...................................................................... sb/intel/lynxpoint/usb_{e,x}hci.c: Don't use device_t Use of device_t is deprecated. Change-Id: Ie75450c844e2317ded157465eb0fc6a9ec1b3ab0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/29932 Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/southbridge/intel/lynxpoint/usb_ehci.c M src/southbridge/intel/lynxpoint/usb_xhci.c 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/southbridge/intel/lynxpoint/usb_ehci.c b/src/southbridge/intel/lynxpoint/usb_ehci.c index e2486cf..7f300d6 100644 --- a/src/southbridge/intel/lynxpoint/usb_ehci.c +++ b/src/southbridge/intel/lynxpoint/usb_ehci.c @@ -25,7 +25,7 @@ #ifdef __SMM__ -void usb_ehci_disable(device_t dev) +void usb_ehci_disable(pci_devfn_t dev) { u16 reg16; u32 reg32; @@ -57,7 +57,7 @@ } /* Handler for EHCI controller on entry to S3/S4/S5 */ -void usb_ehci_sleep_prepare(device_t dev, u8 slp_typ) +void usb_ehci_sleep_prepare(pci_devfn_t dev, u8 slp_typ) { u32 reg32; u8 *bar0_base; @@ -164,7 +164,8 @@ printk(BIOS_DEBUG, "done.\n"); } -static void usb_ehci_set_subsystem(device_t dev, unsigned vendor, unsigned device) +static void usb_ehci_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { u8 access_cntl; diff --git a/src/southbridge/intel/lynxpoint/usb_xhci.c b/src/southbridge/intel/lynxpoint/usb_xhci.c index af0e56f..186e3f9 100644 --- a/src/southbridge/intel/lynxpoint/usb_xhci.c +++ b/src/southbridge/intel/lynxpoint/usb_xhci.c @@ -154,7 +154,7 @@ #ifdef __SMM__ /* Handler for XHCI controller on entry to S3/S4/S5 */ -void usb_xhci_sleep_prepare(device_t dev, u8 slp_typ) +void usb_xhci_sleep_prepare(pci_devfn_t dev, u8 slp_typ) { u16 reg16; u32 reg32; @@ -238,7 +238,7 @@ #else /* !__SMM__ */ -static void usb_xhci_clock_gating(device_t dev) +static void usb_xhci_clock_gating(struct device *dev) { u32 reg32; u16 reg16; @@ -285,7 +285,7 @@ pci_write_config32(dev, 0xa4, reg32); } -static void usb_xhci_init(device_t dev) +static void usb_xhci_init(struct device *dev) { u32 reg32; u16 reg16; @@ -359,8 +359,8 @@ } } -static void usb_xhci_set_subsystem(device_t dev, unsigned vendor, - unsigned device) +static void usb_xhci_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, -- To view, visit https://review.coreboot.org/c/coreboot/+/29932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie75450c844e2317ded157465eb0fc6a9ec1b3ab0 Gerrit-Change-Number: 29932 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Don't use device_t
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29915 ) Change subject: mb/google/dragonegg: Don't use device_t ...................................................................... mb/google/dragonegg: Don't use device_t Use of device_t is deprecated. Change-Id: Ief858f6612d1c7b4b0c286cf5938f8c29055f1b5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/29915 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/google/dragonegg/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/dragonegg/mainboard.c b/src/mainboard/google/dragonegg/mainboard.c index 3e8fd9f..c4df94b 100644 --- a/src/mainboard/google/dragonegg/mainboard.c +++ b/src/mainboard/google/dragonegg/mainboard.c @@ -26,7 +26,7 @@ mainboard_ec_init(); } -static void mainboard_enable(device_t dev) +static void mainboard_enable(struct device *dev) { dev->ops->write_acpi_tables = NULL; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; -- To view, visit https://review.coreboot.org/c/coreboot/+/29915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief858f6612d1c7b4b0c286cf5938f8c29055f1b5 Gerrit-Change-Number: 29915 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: cpu/intel/fsp_model_406dx: Drop dead microcode reference
by David Guckian (Code Review) 03 Dec '18

03 Dec '18

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29931 ) Change subject: cpu/intel/fsp_model_406dx: Drop dead microcode reference ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Code-Review+1 > > Thanks. > > David, may I assume that you'd given +2 if your account allowed > it? Do you need help to get access to your account registered > as <david.guckian(a)intel.com>? > > Fei, we have Gerrit set up to automatically add people to reviews > that are mentioned in the MAINTAINERS file. I assume that doesn't > work in your case yet, because your email address in that file is > not associated to your account. Hi Nico, You can assume +2 from me. I emailed Stefan Reinauer for assistance with this account, I didn't get a reply. I would appreciate your help with this. -- To view, visit https://review.coreboot.org/c/coreboot/+/29931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331 Gerrit-Change-Number: 29931 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Fei Wang Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:01:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: include/device/smbus.h: Don't use device_t
by Patrick Georgi (Code Review) 03 Dec '18

03 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29914 ) Change subject: include/device/smbus.h: Don't use device_t ...................................................................... include/device/smbus.h: Don't use device_t Use of device_t is deprecated. Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/29914 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/include/device/smbus.h 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 50857fe..639e938 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -8,12 +8,13 @@ /* Common SMBus bus operations */ struct smbus_bus_operations { - int (*recv_byte)(device_t dev); - int (*send_byte)(device_t dev, u8 value); - int (*read_byte)(device_t dev, u8 addr); - int (*write_byte)(device_t dev, u8 addr, u8 value); - int (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer); - int (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer); + int (*recv_byte)(struct device *dev); + int (*send_byte)(struct device *dev, u8 value); + int (*read_byte)(struct device *dev, u8 addr); + int (*write_byte)(struct device *dev, u8 addr, u8 value); + int (*block_read)(struct device *dev, u8 cmd, u8 bytes, u8 *buffer); + int (*block_write)(struct device *dev, u8 cmd, u8 bytes, + const u8 *buffer); }; static inline const struct smbus_bus_operations *ops_smbus_bus(struct bus *bus) @@ -27,8 +28,8 @@ return bops; } -struct bus *get_pbus_smbus(device_t dev); -int smbus_set_link(device_t dev); +struct bus *get_pbus_smbus(struct device *dev); +int smbus_set_link(struct device *dev); static inline int smbus_recv_byte(struct device *const dev) { -- To view, visit https://review.coreboot.org/c/coreboot/+/29914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6 Gerrit-Change-Number: 29914 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s
by build bot (Jenkins) (Code Review) 03 Dec '18

03 Dec '18

1 0

Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s
by Bill XIE (Code Review) 03 Dec '18

03 Dec '18

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30021 to look at the new patch set (#5). Change subject: mainboard/lenovo: Add ThinkPad T431s ...................................................................... mainboard/lenovo: Add ThinkPad T431s The code is based on autoport and that for T430s Tested: - CPU i5-3337U - Slotted DIMM 2GiB - Soldered RAM 4GiB from samsung (There may be more models here) - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - TPM1 on LPC - EHCI debug on SSP2 (USB3 port on the left) - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from Linux payload (Heads), Seabios may also work. Not tested: - Fingerprint reader on USB2 (not present on mine) - Keyboard backlight (not present on mine) - "sticky_fn" flag in nvram Not implemented yet: - Fn locking in nvram (may not be identical to "sticky_fn") - Detecting the model of Soldered RAM at runtime, and loading the corresponding SPD datum (3 observed) from CBFS (the mechanism may be similar to that on x1_carbon_gen1 and s230u, but I do not know how to find gpio ports for that, and SPD data stored in vendor firmware.) Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/lenovo/t431s.md A Documentation/mainboard/lenovo/t431s_bc_removed.jpg A Documentation/mainboard/lenovo/t431s_flash_chip.jpg A Documentation/mainboard/lenovo/t431s_programming.jpg A src/mainboard/lenovo/t431s/Kconfig A src/mainboard/lenovo/t431s/Kconfig.name A src/mainboard/lenovo/t431s/Makefile.inc A src/mainboard/lenovo/t431s/acpi/ec.asl A src/mainboard/lenovo/t431s/acpi/platform.asl A src/mainboard/lenovo/t431s/acpi/superio.asl A src/mainboard/lenovo/t431s/acpi_tables.c A src/mainboard/lenovo/t431s/board_info.txt A src/mainboard/lenovo/t431s/cmos.default A src/mainboard/lenovo/t431s/cmos.layout A src/mainboard/lenovo/t431s/data.vbt A src/mainboard/lenovo/t431s/devicetree.cb A src/mainboard/lenovo/t431s/dsdt.asl A src/mainboard/lenovo/t431s/gma-mainboard.ads A src/mainboard/lenovo/t431s/gpio.c A src/mainboard/lenovo/t431s/hda_verb.c A src/mainboard/lenovo/t431s/mainboard.c A src/mainboard/lenovo/t431s/romstage.c A src/mainboard/lenovo/t431s/smihandler.c A src/mainboard/lenovo/t431s/spd/Makefile.inc A src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex A src/mainboard/lenovo/t431s/thermal.h 27 files changed, 1,267 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/30021/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/30021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Gerrit-Change-Number: 30021 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: cpu/intel/fsp_model_406dx: Drop dead microcode reference
by HAOUAS Elyes (Code Review) 03 Dec '18

03 Dec '18

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29931 ) Change subject: cpu/intel/fsp_model_406dx: Drop dead microcode reference ...................................................................... Patch Set 1: ./util/lint/kconfig_lint |grep -i HAVE_CPU_MICROCODE_FILE can not see it. -- To view, visit https://review.coreboot.org/c/coreboot/+/29931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331 Gerrit-Change-Number: 29931 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Fei Wang Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Dec 2018 12:55:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src: Remove unused variables
by Angel Pons (Code Review) 03 Dec '18

03 Dec '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 ) Change subject: src: Remove unused variables ...................................................................... Patch Set 15: (4 comments) https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/… File src/cpu/amd/family_10h-family_15h/init_cpus.c: https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/… PS15, Line 1062: !! > It transforms nvram (any integer value, where 0 is meant to be false, and everything else is true) i […] Yup, I've done this before. I would remove it then. https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstag… File src/soc/intel/fsp_baytrail/romstage/romstage.c: https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstag… PS15, Line 253: cbmem_was_initted > You are right, but that will be some "crowded" […] Makes sense to not clutter this one, but for the other two cbmem_was_initted cases, the function call is roughly as long as the variable. https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/rom… File src/soc/intel/fsp_broadwell_de/romstage/romstage.c: https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/rom… PS15, Line 119: cbmem_was_initted > Oops, it shoild be '!cbmem_was_initted' And this one too. https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley… File src/southbridge/intel/fsp_rangeley/romstage.c: https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley… PS15, Line 122: cbmem_was_initted > sould be "!cbmem_was_initted" In this one, I think replacing cbmem_was_initted with the function call is not going to clutter the code. -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 15 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 12:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s
by build bot (Jenkins) (Code Review) 03 Dec '18

03 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 ) Change subject: mainboard/lenovo: Add ThinkPad T431s ...................................................................... Patch Set 4: (5 comments) https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… File src/mainboard/lenovo/t431s/smihandler.c: https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… PS4, Line 52: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0) do not use assignment in if condition https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… PS4, Line 60: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10) do not use assignment in if condition https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… PS4, Line 76: switch (event) { switch and case should be at the same indent https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… PS4, Line 98: switch (data) { switch and case should be at the same indent https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandl… PS4, Line 108: /* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Gerrit-Change-Number: 30021 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 12:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s
by Bill XIE (Code Review) 03 Dec '18

03 Dec '18

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30021 to look at the new patch set (#4). Change subject: mainboard/lenovo: Add ThinkPad T431s ...................................................................... mainboard/lenovo: Add ThinkPad T431s The code is based on autoport and that for T430s Tested: - CPU i5-3337U - Slotted DIMM 2GiB - Soldered RAM 4GiB from samsung (There may be more models here) - Camera - pci-e and usb2 on M.2 slot with A key for wlan - sata and usb2 (no superspeed components) on M.2 slot with B key for wwan - On board SDHCI connected to pci-e - USB3 ports - NVRAM options for North and South bridges - Sound - Thinkpad EC - S3 - TPM1 on LPC - EHCI debug on SSP2 (USB3 port on the left) - Linux 4.9.110-3 within Debian GNU/Linux stable, loaded from Linux payload (Heads), Seabios may also work. Not tested: - Fingerprint reader on USB2 (not present on mine) - Keyboard backlight (not present on mine) - "sticky_fn" flag in nvram Not implemented yet: - Fn locking in nvram (may not be identical to "sticky_fn") - Detecting the model of Soldered RAM at runtime, and loading the corresponding SPD datum (3 observed) from CBFS (the mechanism may be similar to that on x1_carbon_gen1 and s230u, but I do not know how to find gpio ports for that, and SPD data stored in vendor firmware.) Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/lenovo/t431s.md A Documentation/mainboard/lenovo/t431s_bc_removed.jpg A Documentation/mainboard/lenovo/t431s_flash_chip.jpg A Documentation/mainboard/lenovo/t431s_programming.jpg A src/mainboard/lenovo/t431s/Kconfig A src/mainboard/lenovo/t431s/Kconfig.name A src/mainboard/lenovo/t431s/Makefile.inc A src/mainboard/lenovo/t431s/acpi/ec.asl A src/mainboard/lenovo/t431s/acpi/platform.asl A src/mainboard/lenovo/t431s/acpi/superio.asl A src/mainboard/lenovo/t431s/acpi_tables.c A src/mainboard/lenovo/t431s/board_info.txt A src/mainboard/lenovo/t431s/cmos.default A src/mainboard/lenovo/t431s/cmos.layout A src/mainboard/lenovo/t431s/data.vbt A src/mainboard/lenovo/t431s/devicetree.cb A src/mainboard/lenovo/t431s/dsdt.asl A src/mainboard/lenovo/t431s/gma-mainboard.ads A src/mainboard/lenovo/t431s/gpio.c A src/mainboard/lenovo/t431s/hda_verb.c A src/mainboard/lenovo/t431s/mainboard.c A src/mainboard/lenovo/t431s/romstage.c A src/mainboard/lenovo/t431s/smihandler.c A src/mainboard/lenovo/t431s/spd/Makefile.inc A src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex A src/mainboard/lenovo/t431s/thermal.h 27 files changed, 1,268 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/30021/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a Gerrit-Change-Number: 30021 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018