Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30024 )
Change subject: Documentation: Clarify minor detail on preparing a layout file
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877
Gerrit-Change-Number: 30024
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 20:11:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30024
to look at the new patch set (#2).
Change subject: Documentation: Clarify minor detail on preparing a layout file
......................................................................
Documentation: Clarify minor detail on preparing a layout file
The user needs to pass the original firmware image to create
a layout file, not the newly compiled coreboot image.
Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com>
Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877
---
M Documentation/flash_tutorial/index.md
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/30024/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877
Gerrit-Change-Number: 30024
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30025
to look at the new patch set (#2).
Change subject: Documentation: Clarify workflow for cloning coreboot from Gerrit.
......................................................................
Documentation: Clarify workflow for cloning coreboot from Gerrit.
Documentation that was there seems to reference and older version.
Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com>
Change-Id: I3709613ae065153123d00801ea1b4ff86b100264
---
M Documentation/lessons/lesson2.md
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/30025/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3709613ae065153123d00801ea1b4ff86b100264
Gerrit-Change-Number: 30025
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30026
to look at the new patch set (#4).
Change subject: Documentation: s/My/Your/ in getting started with Gerrit docs
......................................................................
Documentation: s/My/Your/ in getting started with Gerrit docs
Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com>
Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce
Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com>
---
M Documentation/lessons/lesson2.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30026/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/30026
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce
Gerrit-Change-Number: 30026
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset