coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: Documentation: s/My/Your/ in getting started with Gerrit docs
by Angel Pons (Code Review) 03 Dec '18

03 Dec '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30026 ) Change subject: Documentation: s/My/Your/ in getting started with Gerrit docs ...................................................................... Patch Set 3: Code-Review+2 Thanks! The old Gerrit UI used to say "My", but it is deprecated. -- To view, visit https://review.coreboot.org/c/coreboot/+/30026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce Gerrit-Change-Number: 30026 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 19:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation: s/My/Your/ in getting started with Gerrit docs
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30026 to look at the new patch set (#3). Change subject: Documentation: s/My/Your/ in getting started with Gerrit docs ...................................................................... Documentation: s/My/Your/ in getting started with Gerrit docs Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce --- M Documentation/lessons/lesson2.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30026/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce Gerrit-Change-Number: 30026 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: doc: s/My/Your/ in getting started with Gerrit docs
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30026 to look at the new patch set (#2). Change subject: doc: s/My/Your/ in getting started with Gerrit docs ...................................................................... doc: s/My/Your/ in getting started with Gerrit docs Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce --- M Documentation/lessons/lesson2.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30026/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce Gerrit-Change-Number: 30026 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: s/My/Your/ in getting started with Gerrit docs
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30026 Change subject: s/My/Your/ in getting started with Gerrit docs ...................................................................... s/My/Your/ in getting started with Gerrit docs Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce --- M Documentation/lessons/lesson2.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30026/1 diff --git a/Documentation/lessons/lesson2.md b/Documentation/lessons/lesson2.md index a52fff0..a95dd80 100644 --- a/Documentation/lessons/lesson2.md +++ b/Documentation/lessons/lesson2.md @@ -210,7 +210,7 @@ ## Part 5: Getting your commit reviewed -Your commits can now be seen on review.coreboot.org if you select “My” +Your commits can now be seen on review.coreboot.org if you select “Your” and click on “Changes” and can be reviewed by others. Your code will first be reviewed by build bot (Jenkins), which will either give you a warning or verify a successful build; if so, your commit will receive a +1. Other -- To view, visit https://review.coreboot.org/c/coreboot/+/30026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I781e2d78c0525da74dd77f572839d746d3eeb3ce Gerrit-Change-Number: 30026 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Clarify workflow for cloning coreboot from Gerrit.
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30025 Change subject: Clarify workflow for cloning coreboot from Gerrit. ...................................................................... Clarify workflow for cloning coreboot from Gerrit. Documentation that was there seems to reference and older version. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I3709613ae065153123d00801ea1b4ff86b100264 --- M Documentation/lessons/lesson2.md 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/30025/1 diff --git a/Documentation/lessons/lesson2.md b/Documentation/lessons/lesson2.md index ec929c8..a52fff0 100644 --- a/Documentation/lessons/lesson2.md +++ b/Documentation/lessons/lesson2.md @@ -60,12 +60,13 @@ ## Part 3: Clone coreboot and configure it for submitting patches -Go to the **Projects** tab in the upper left corner and select **List**. -From the dropdown menu that appears, select "coreboot". +On Gerrit, click on the **Browse** tab in the upper left corner and select +**Repositories**. From the listing, select the "coreboot" repo. You may have +to click the next page arrow at the bottom a few times to find it. -If you are using SSH keys, select **ssh** from the tabs under "Project coreboot" -and run the command that appears. This should prompt you for your id_rsa passphrase, -if you previously set one. +If you are using SSH keys, select **ssh** from the tabs under "Project +coreboot" and run the clone with commit-msg hook command that's provided. This +should prompt you for your id_rsa passphrase, if you previously set one. If you are using HTTP, instead, select **http** from the tabs under "Project coreboot" and run the command that appears @@ -278,4 +279,4 @@ command in your coreboot repository. Now, the last commit should be the most recent commit to that patch; to update it, make your desired changes, stage the files, then amend and push the commit using the instructions in the above -paragraph. \ No newline at end of file +paragraph. -- To view, visit https://review.coreboot.org/c/coreboot/+/30025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3709613ae065153123d00801ea1b4ff86b100264 Gerrit-Change-Number: 30025 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Clarify minor detail on preparing a layout file
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30024 Change subject: Clarify minor detail on preparing a layout file ...................................................................... Clarify minor detail on preparing a layout file The user needs to pass the original firmware image to create a layout file, not the newly compiled coreboot image. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877 --- M Documentation/flash_tutorial/index.md 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/30024/1 diff --git a/Documentation/flash_tutorial/index.md b/Documentation/flash_tutorial/index.md index 1a29137..eb74ad0 100644 --- a/Documentation/flash_tutorial/index.md +++ b/Documentation/flash_tutorial/index.md @@ -68,10 +68,11 @@ to write only a part of the flash IC. On Intel for example there are IFD, ME and GBE which don't need to be updated to install coreboot. To make [flashrom] only write the *bios* region, leaving Intel ME and Intel IFD -untouched, you can use a layout file, which can be created using ifdtool +untouched, you can use a layout file, which can be created with ifdtool and a backup +of the original firmware. ```bash -ifdtool -f rom.layout coreboot.rom +ifdtool -f rom.layout backup.rom ``` and looks similar to: -- To view, visit https://review.coreboot.org/c/coreboot/+/30024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877 Gerrit-Change-Number: 30024 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: cpu/intel/fit: Make FIT microcode updates selectable
by Philipp Deppenwiese (Code Review) 03 Dec '18

03 Dec '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29863 ) Change subject: cpu/intel/fit: Make FIT microcode updates selectable ...................................................................... Abandoned Not necessary -- To view, visit https://review.coreboot.org/c/coreboot/+/29863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7da926943aef89e49e98d0b990ab46f5f8200e6e Gerrit-Change-Number: 29863 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: ec/google/wilco/acpi: Add DPTF support
by Duncan Laurie (Code Review) 03 Dec '18

03 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29761 ) Change subject: ec/google/wilco/acpi: Add DPTF support ...................................................................... Patch Set 2: Needs to rebase after cannonlake dptf patches land. -- To view, visit https://review.coreboot.org/c/coreboot/+/29761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d8570d176c0896fa709a6c782b319f58d3c1e52 Gerrit-Change-Number: 29761 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 16:10:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Add DPTF ACPI code
by Duncan Laurie (Code Review) 03 Dec '18

03 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29759 ) Change subject: soc/intel/cannonlake: Add DPTF ACPI code ...................................................................... Patch Set 2: -Code-Review Oops wrong action. -- To view, visit https://review.coreboot.org/c/coreboot/+/29759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43c2f8dd7281d3e9f791ab01478ee7823fd6b128 Gerrit-Change-Number: 29759 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 16:10:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/wilco/acpi: Fix issues and clean up
by Duncan Laurie (Code Review) 03 Dec '18

03 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29760 ) Change subject: ec/google/wilco/acpi: Fix issues and clean up ...................................................................... Patch Set 2: -Code-Review Oops, working on autopilot. -- To view, visit https://review.coreboot.org/c/coreboot/+/29760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic65ebbb6a6151444c47b4aeff7429e186856c49a Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 16:09:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018