coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: libpayload: Remove purin/cygnus
by Julius Werner (Code Review) 03 Dec '18

03 Dec '18

Hello HAOUAS Elyes, Philipp Deppenwiese, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/30029 to review the following change. Change subject: libpayload: Remove purin/cygnus ...................................................................... libpayload: Remove purin/cygnus The Purin mainboard and Cygnus SoC have been removed from coreboot, so also remove the corresponding libpayload Kconfigs. Change-Id: I589ca7f1a3b479f1c2b1b668a175a71583441ac9 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- D payloads/libpayload/configs/config.purin M payloads/libpayload/drivers/timer/Kconfig 2 files changed, 0 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/30029/1 diff --git a/payloads/libpayload/configs/config.purin b/payloads/libpayload/configs/config.purin deleted file mode 100644 index afcc199..0000000 --- a/payloads/libpayload/configs/config.purin +++ /dev/null @@ -1,11 +0,0 @@ -CONFIG_LP_GPL=y -CONFIG_LP_ARCH_ARM=y -# CONFIG_LP_CURSES is not set -CONFIG_LP_SKIP_CONSOLE_INIT=y -# CONFIG_LP_VIDEO_CONSOLE is not set -# CONFIG_LP_STORAGE is not set -CONFIG_LP_TIMER_CYGNUS=y -CONFIG_LP_USB=y -# CONFIG_LP_USB_HID is not set -# CONFIG_LP_USB_HUB is not set -# CONFIG_LP_USB_MSC is not set diff --git a/payloads/libpayload/drivers/timer/Kconfig b/payloads/libpayload/drivers/timer/Kconfig index 54cbe4a..d0d3494 100644 --- a/payloads/libpayload/drivers/timer/Kconfig +++ b/payloads/libpayload/drivers/timer/Kconfig @@ -56,9 +56,6 @@ config TIMER_RK3399 bool "Timer for Rockchip RK3399" -config TIMER_CYGNUS - bool "Timer for Cygnus" - config TIMER_IMG_PISTACHIO bool "Timer for IMG Pistachio" @@ -92,7 +89,6 @@ config TIMER_GENERIC_HZ int "Generic Timer Frequency" - default 500000000 if TIMER_CYGNUS default 48000000 if TIMER_IPQ40XX default 6250000 if TIMER_IPQ806X default 24000000 if TIMER_MCT @@ -107,7 +103,6 @@ config TIMER_GENERIC_REG hex "Generic Timer Register Address" - default 0x19020200 if TIMER_CYGNUS default 0x004A2000 if TIMER_IPQ40XX default 0x0200A028 if TIMER_IPQ806X default 0x101C0100 if TIMER_MCT @@ -121,7 +116,6 @@ config TIMER_GENERIC_HIGH_REG hex "Generic Timer High Register Address" - default 0x19020204 if TIMER_CYGNUS default 0x004A2004 if TIMER_IPQ40XX default 0x101C0104 if TIMER_MCT default 0xff81002C if TIMER_RK3288 -- To view, visit https://review.coreboot.org/c/coreboot/+/30029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I589ca7f1a3b479f1c2b1b668a175a71583441ac9 Gerrit-Change-Number: 30029 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/common/dptf: Make CPU address a define
by Furquan Shaikh (Code Review) 03 Dec '18

03 Dec '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29757 ) Change subject: soc/intel/common/dptf: Make CPU address a define ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I638f2387330bbc42f64eb0fb676ee32c5df6572e Gerrit-Change-Number: 29757 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 23:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/wilco: Fix extended event handling
by Furquan Shaikh (Code Review) 03 Dec '18

03 Dec '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29674 ) Change subject: ec/google/wilco: Fix extended event handling ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8510e38d777a5dd31a5237867313efefeb2b48e Gerrit-Change-Number: 29674 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 22:35:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/wilco: Enable WiFi radio
by Furquan Shaikh (Code Review) 03 Dec '18

03 Dec '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29673 ) Change subject: ec/google/wilco: Enable WiFi radio ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac46895c7118567e1eb55ea33051a1662103b563 Gerrit-Change-Number: 29673 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 22:26:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/google/wilco: Enable COM1 ACPI device
by Furquan Shaikh (Code Review) 03 Dec '18

03 Dec '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29672 ) Change subject: ec/google/wilco: Enable COM1 ACPI device ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69361cc2c245cfcad3e4f57567bf56d5a26f0b06 Gerrit-Change-Number: 29672 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 22:20:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/flash_tutorial/index.md: warn about dots painted on ICs
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30028 Change subject: Documentation/flash_tutorial/index.md: warn about dots painted on ICs ...................................................................... Documentation/flash_tutorial/index.md: warn about dots painted on ICs I fried my mainboard because I tried to orient my chip by lining a blue dot on the corner of my chip with a dot depicted on the chip datasheet. They apparently have nothing to do with each other, and this is normal. Add warning about this to the docs to hopefully spare others from a similar fate. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: Ib634589aaa11f75bde2ef2e13d2cacc4cae19a3f --- M Documentation/flash_tutorial/index.md 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/30028/1 diff --git a/Documentation/flash_tutorial/index.md b/Documentation/flash_tutorial/index.md index eb74ad0..342f55b 100644 --- a/Documentation/flash_tutorial/index.md +++ b/Documentation/flash_tutorial/index.md @@ -63,6 +63,8 @@ **WARNING:** Using the wrong method or accidentally using the wrong pinout might permanently damage your hardware! +**WARNING:** Do not rely on any dots painted on flash ICs to orient the pins! Although you may find dots on data sheet diagrams, they often do not correspond to dots painted on the flash IC. + ## Using a layout file On platforms where the flash IC is shared with other components you might want to write only a part of the flash IC. On Intel for example there are IFD, ME and -- To view, visit https://review.coreboot.org/c/coreboot/+/30028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib634589aaa11f75bde2ef2e13d2cacc4cae19a3f Gerrit-Change-Number: 30028 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Documentation/mainboard/lenovo/t420.md: add pic of chip
by Michael Bacarella (Code Review) 03 Dec '18

03 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30027 Change subject: Documentation/mainboard/lenovo/t420.md: add pic of chip ...................................................................... Documentation/mainboard/lenovo/t420.md: add pic of chip Provide pic of the flash IC with pinouts labeled, as well as additional text about the chip. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I9046fa63dcd4d192836417efac68ca7587ac1c91 --- M Documentation/mainboard/lenovo/t420.md A Documentation/mainboard/lenovo/t420_chip_location.png 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/30027/1 diff --git a/Documentation/mainboard/lenovo/t420.md b/Documentation/mainboard/lenovo/t420.md index ff7a0a9..9516a4c 100644 --- a/Documentation/mainboard/lenovo/t420.md +++ b/Documentation/mainboard/lenovo/t420.md @@ -1,8 +1,17 @@ # Lenovo T420 ## Flashing instructions -You have to disassemble the whole device, as the flash IC is on the bottom -of the mainboard. +The flash IC is located at the bottom center of the mainboard. Sadly, +access to the IC is blocked by the magnesum frame, so you need to disassemble +the entire laptop and remove the mainboard. + +Below is a picture of IC on the mainboard, with the pinouts labeled. + +[t420_chip_location]: t420_chip_location.png + +The chip will either be a Macronix MX25L6404E (shown above) or a Winbond +W25Q64CVSIG. Do not rely on dots painted in the corner of the chip (such as +the blue dot pictured) to orient the pins! For more details have a look at [T420 / T520 / X220 / T420s / W520 common] and diff --git a/Documentation/mainboard/lenovo/t420_chip_location.png b/Documentation/mainboard/lenovo/t420_chip_location.png new file mode 100644 index 0000000..b9172ac --- /dev/null +++ b/Documentation/mainboard/lenovo/t420_chip_location.png Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/30027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9046fa63dcd4d192836417efac68ca7587ac1c91 Gerrit-Change-Number: 30027 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: src: Don't use device_t
by build bot (Jenkins) (Code Review) 03 Dec '18

03 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30004 ) Change subject: src: Don't use device_t ...................................................................... Patch Set 5: (6 comments) https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h File src/southbridge/amd/sr5650/cmn.h: https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@185 PS5, Line 185: if (reg != reg_old) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@217 PS5, Line 217: if (reg != reg_old) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@229 PS5, Line 229: if (reg != reg_old) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@241 PS5, Line 241: if (reg != reg_old) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@253 PS5, Line 253: if (reg != reg_old) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@265 PS5, Line 265: if (reg != reg_old) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/30004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic29891d78514db3b7eed48414a14e4ff579436c0 Gerrit-Change-Number: 30004 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Dec 2018 21:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src: Don't use device_t
by HAOUAS Elyes (Code Review) 03 Dec '18

03 Dec '18

Hello Patrick Rudolph, David Guckian, Vanessa Eusebio, build bot (Jenkins), David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30004 to look at the new patch set (#5). Change subject: src: Don't use device_t ...................................................................... src: Don't use device_t Use of device_t is deprecated. Change-Id: Ic29891d78514db3b7eed48414a14e4ff579436c0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/device/pci_ops.h M src/include/device/smbus.h M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c M src/soc/intel/common/block/pcr/pcr.c M src/soc/intel/denverton_ns/include/soc/soc_util.h M src/soc/intel/denverton_ns/soc_util.c M src/southbridge/amd/sr5650/cmn.h M src/southbridge/intel/lynxpoint/pch.c 9 files changed, 333 insertions(+), 75 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/30004/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/30004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic29891d78514db3b7eed48414a14e4ff579436c0 Gerrit-Change-Number: 30004 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: include/device/smbus.h: Don't use device_t
by HAOUAS Elyes (Code Review) 03 Dec '18

03 Dec '18

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30010 ) Change subject: include/device/smbus.h: Don't use device_t ...................................................................... Abandoned please see Change 30004 -- To view, visit https://review.coreboot.org/c/coreboot/+/30010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76088d9ebfa0bb1edcb73c29e0e8023d489bb5a9 Gerrit-Change-Number: 30010 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018