coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command
by Marshall Dawson (Code Review) 05 Dec '18

05 Dec '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30054 ) Change subject: Documentation/lessons/lesson2.md: fix the git push command ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/30054/4//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30054/4//COMMIT_MSG@13 PS4, Line 13: Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> You can delete this one. https://review.coreboot.org/#/c/30054/4/Documentation/lessons/lesson2.md File Documentation/lessons/lesson2.md: https://review.coreboot.org/#/c/30054/4/Documentation/lessons/lesson2.md@146 PS4, Line 146: git push origin HEAD:refs/for/master' Does make gitconfig (in Part 3 above) not still run "git config remote.origin.push HEAD:refs/for/master"? I don't see why this is necessary. -- To view, visit https://review.coreboot.org/c/coreboot/+/30054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Gerrit-Change-Number: 30054 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 19:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation: Add arch x86
by Patrick Rudolph (Code Review) 05 Dec '18

05 Dec '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30056 Change subject: Documentation: Add arch x86 ...................................................................... Documentation: Add arch x86 Describe state and assuptions made about x86_64 support. Change-Id: I308a09b0eac269afd30df95ed3ea195238a6cfbe Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/index.md A Documentation/arch/x86/index.md 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/30056/1 diff --git a/Documentation/arch/index.md b/Documentation/arch/index.md index c3b080e..a0f1050 100644 --- a/Documentation/arch/index.md +++ b/Documentation/arch/index.md @@ -6,3 +6,6 @@ ## RISC-V - [RISC-V documentation](riscv/index.md) + +## x86 +- [x86 documentation](x86/index.md) diff --git a/Documentation/arch/x86/index.md b/Documentation/arch/x86/index.md new file mode 100644 index 0000000..b77a34b --- /dev/null +++ b/Documentation/arch/x86/index.md @@ -0,0 +1,30 @@ +# x86 architecture documentation + +This section contains documentation about coreboot on x86 architecture. + +## State of x86_64 support +At the moment there's no single board that supports x86_64 or to be exact +`ARCH_RAMSTAGE_X86_64` and `ARCH_ROMSTAGE_X86_64`. + +In order to add support for x86_64 the following assumptions are made: +* All memory returned by malloc must be below 4GiB in physical memory +* All code that is to be run must be below 4GiB in physical memory +* The high dword of pointers is always zero +* The reference implementation is qemu + +## Steps to add basic support for x86_64 +* Add x86_64 toolchain support - *DONE* +* Fix compilation errors - *DONE* +* Fix linker errors - *TODO* +* Add x86_64 rmodule support - *ONGERRIT* +* Add x86_64 exception handlers - *TODO* +* Setup page tables for long mode - *TODO* +* Add assembly code for long mode - *TODO* +* Add assembly code to return to protected mode - *TODO* +* Implement reference code for mainboard `emulation/qemu-q35` - *TODO* + +## Porting other boards +* Fix compilation errors +* Test how well CAR works with x86_64 and paging +* Improve mode switches +* Test libgfxinit / VGA Option ROMs / FSP -- To view, visit https://review.coreboot.org/c/coreboot/+/30056 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I308a09b0eac269afd30df95ed3ea195238a6cfbe Gerrit-Change-Number: 30056 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/apl: Warn if CBFS is outside the memory mapped area
by Nico Huber (Code Review) 05 Dec '18

05 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30055 Change subject: soc/intel/apl: Warn if CBFS is outside the memory mapped area ...................................................................... soc/intel/apl: Warn if CBFS is outside the memory mapped area As part of the memory mapped BIOS region is covered by SRAM, check that CBFS always fits the effectively mapped region of flash. This is usually taken care of by reserving the SRAM range in the FMAP (e.g. as BIOS_UNUSABLE), but can be missed. Change-Id: If5a5b553ad4853723bf13349c809c4f6154aa5f2 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/soc/intel/apollolake/mmap_boot.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/30055/1 diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c index db13cba..1c3077e 100644 --- a/src/soc/intel/apollolake/mmap_boot.c +++ b/src/soc/intel/apollolake/mmap_boot.c @@ -110,6 +110,8 @@ static int iafw_boot_region_properties(struct cbfs_props *props) { + struct xlate_region_device *real_dev_ptr; + struct region *real_dev_reg; struct region regn; /* use fmap to locate CBFS area */ @@ -119,7 +121,19 @@ props->offset = region_offset(&regn); props->size = region_sz(&regn); - printk(BIOS_DEBUG, "CBFS @ %zx size %zx\n", props->offset, props->size); + /* Check that we are within the memory mapped area. It's too + easy to forget the SRAM mapping when crafting an FMAP file. */ + real_dev_ptr = car_get_var_ptr(&real_dev); + real_dev_reg = &real_dev_ptr->sub_region; + if (region_is_subregion(real_dev_reg, &regn)) { + printk(BIOS_DEBUG, "CBFS @ %zx size %zx\n", + props->offset, props->size); + } else { + printk(BIOS_CRIT, + "ERROR: CBFS @ %zx size %zx exceeds mem-mapped area @ %zx size %zx\n", + props->offset, props->size, + region_offset(real_dev_reg), region_sz(real_dev_reg)); + } return 0; } -- To view, visit https://review.coreboot.org/c/coreboot/+/30055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5a5b553ad4853723bf13349c809c4f6154aa5f2 Gerrit-Change-Number: 30055 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/sarien: Enable ISH
by Duncan Laurie (Code Review) 05 Dec '18

05 Dec '18

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30034 ) Change subject: mb/google/sarien: Enable ISH ...................................................................... mb/google/sarien: Enable ISH Turn on the ISH in the device tree. BUG=b:120295222 Change-Id: I0ba08c245d050aebc6eb06055690c422ab9b51c6 Signed-off-by: Jett Rink <jettrink(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/30034 Reviewed-by: Duncan Laurie <dlaurie(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Jett Rink: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 4696d7f..991e9640 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -109,6 +109,7 @@ device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2 + device pci 13.0 on end # Integrated Sensor Hub device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub"" -- To view, visit https://review.coreboot.org/c/coreboot/+/30034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ba08c245d050aebc6eb06055690c422ab9b51c6 Gerrit-Change-Number: 30034 Gerrit-PatchSet: 3 Gerrit-Owner: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: mb/google/sarien: Enable ISH
by Duncan Laurie (Code Review) 05 Dec '18

05 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30034 ) Change subject: mb/google/sarien: Enable ISH ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ba08c245d050aebc6eb06055690c422ab9b51c6 Gerrit-Change-Number: 30034 Gerrit-PatchSet: 2 Gerrit-Owner: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 17:06:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command
by Michael Bacarella (Code Review) 05 Dec '18

05 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30054 to look at the new patch set (#4). Change subject: Documentation/lessons/lesson2.md: fix the git push command ...................................................................... Documentation/lessons/lesson2.md: fix the git push command The current git push will fail because it tries to push to master directly. Also provide a blurb explaining how to make better use of Gerrit. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> --- M Documentation/lessons/lesson2.md 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/30054/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Gerrit-Change-Number: 30054 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command
by Michael Bacarella (Code Review) 05 Dec '18

05 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30054 to look at the new patch set (#3). Change subject: Documentation/lessons/lesson2.md: fix the git push command ...................................................................... Documentation/lessons/lesson2.md: fix the git push command The current git push will fail because it tries to push to master directly. Also provide a blurb explaining how to make better use of Gerrit. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> --- M Documentation/lessons/lesson2.md 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/30054/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Gerrit-Change-Number: 30054 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command
by Michael Bacarella (Code Review) 05 Dec '18

05 Dec '18

Michael Bacarella has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/30054 ) Change subject: Documentation/lessons/lesson2.md: fix the git push command ...................................................................... Documentation/lessons/lesson2.md: fix the git push command The current git push will fail because it tries to push to master directly. Also provide a blurb explaining how to make better use of Gerrit. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> --- M Documentation/lessons/lesson2.md 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/30054/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Gerrit-Change-Number: 30054 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command
by Michael Bacarella (Code Review) 05 Dec '18

05 Dec '18

Michael Bacarella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30054 Change subject: Documentation/lessons/lesson2.md: fix the git push command ...................................................................... Documentation/lessons/lesson2.md: fix the git push command The current git push will fail because it tries to push to master directly. Also provide a blurb explaining how to make better use of Gerrit. Signed-off-by: Michael Bacarella <michael.bacarella(a)gmail.com> Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 --- M Documentation/lessons/lesson2.md 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/30054/1 diff --git a/Documentation/lessons/lesson2.md b/Documentation/lessons/lesson2.md index a95dd80..052599d 100644 --- a/Documentation/lessons/lesson2.md +++ b/Documentation/lessons/lesson2.md @@ -143,11 +143,16 @@ commit, you wish to make changes to it, running "git commit --amend" allows you to take back your commit and amend it. -When you are done with your commit, run 'git push' to push your commit to -coreboot.org. **Note:** To submit as a draft, use -'git push origin HEAD:refs/drafts/master' Submitting as a draft means that -your commit will be on coreboot.org, but is only visible to those you add -as reviewers. +When you are done with your commit, run 'git push HEAD:refs/for/master' to push +your commit to coreboot.org. **Note:** To submit as a draft, use 'git push +origin HEAD:refs/drafts/master' Submitting as a draft means that your commit +will be on coreboot.org, but is only visible to those you add as reviewers. + +This has been a quick primer on how to submit a change to Gerrit for review +using git. You may wish to review the Gerrit code review workflow +documentation, especially if you plan to work on multiple changes at the same +time. See +https://gerrit-review.googlesource.com/Documentation/intro-user.html#code-review ## Part 4b: Using git cola to stage and submit a commit -- To view, visit https://review.coreboot.org/c/coreboot/+/30054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58 Gerrit-Change-Number: 30054 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/sarien: Enable ISH
by Jett Rink (Code Review) 05 Dec '18

05 Dec '18

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30034 ) Change subject: mb/google/sarien: Enable ISH ...................................................................... Patch Set 2: Code-Review+1 > Patch Set 1: > > I think you'll have to rebase this as I just submitted some changes that affected devicetree.cb Just rebased -- To view, visit https://review.coreboot.org/c/coreboot/+/30034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ba08c245d050aebc6eb06055690c422ab9b51c6 Gerrit-Change-Number: 30034 Gerrit-PatchSet: 2 Gerrit-Owner: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Jett Rink <jettrink(a)chromium.org> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 16:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018