coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: Fix typos involving "the the"
by Jonathan Neuschäfer (Code Review) 11 Dec '18

11 Dec '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30160 ) Change subject: Fix typos involving "the the" ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30160/1/src/vendorcode/cavium/bdk/libbdk-dr… File src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c: https://review.coreboot.org/#/c/30160/1/src/vendorcode/cavium/bdk/libbdk-dr… PS1, Line 153: Pointer the > maybe "Pointer to the"? Good catch, thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/30160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I179264ee6681a7ba4488b9f1c6bce1a19b4e1772 Gerrit-Change-Number: 30160 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 21:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Fix typos involving "the the"
by build bot (Jenkins) (Code Review) 11 Dec '18

11 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30160 ) Change subject: Fix typos involving "the the" ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/30160/2/src/device/oprom/x86emu/ops.c File src/device/oprom/x86emu/ops.c: https://review.coreboot.org/#/c/30160/2/src/device/oprom/x86emu/ops.c@61 PS2, Line 61: * subroutines fall into the latter category. The decode_* fall space prohibited after that '*' (ctx:ExW) https://review.coreboot.org/#/c/30160/2/src/device/oprom/x86emu/ops.c@61 PS2, Line 61: * subroutines fall into the latter category. The decode_* fall need consistent spacing around '*' (ctx:VxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/30160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I179264ee6681a7ba4488b9f1c6bce1a19b4e1772 Gerrit-Change-Number: 30160 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 21:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Fix typos involving "the the"
by Jonathan Neuschäfer (Code Review) 11 Dec '18

11 Dec '18

Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30160 to look at the new patch set (#2). Change subject: Fix typos involving "the the" ...................................................................... Fix typos involving "the the" Change-Id: I179264ee6681a7ba4488b9f1c6bce1a19b4e1772 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/Intel/development.html M Documentation/cbfs.txt M Documentation/getting_started/gerrit_guidelines.md M Makefile.inc M payloads/libpayload/curses/PDCurses/pdcurses/clear.c M src/device/oprom/x86emu/ops.c M src/drivers/intel/fsp2_0/hob_verify.c M src/include/cpu/intel/microcode.h M src/northbridge/intel/haswell/gma.c M src/soc/amd/common/block/include/amdblocks/dimm_spd.h M src/soc/amd/stoneyridge/Kconfig M src/southbridge/amd/agesa/hudson/Kconfig M src/southbridge/amd/pi/hudson/Kconfig M src/vendorcode/amd/agesa/f12/Proc/Mem/mfs3.h M src/vendorcode/amd/agesa/f14/Proc/Mem/mfs3.h M src/vendorcode/amd/agesa/f15tn/Proc/Mem/mfs3.h M src/vendorcode/amd/agesa/f16kb/Proc/Mem/mfs3.h M src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c M src/vendorcode/cavium/include/bdk/libbdk-arch/bdk-csrs-gsern.h M src/vendorcode/cavium/include/bdk/libbdk-arch/bdk-csrs-rvu.h M src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiMultiPhase.h M src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/Library/DxeServicesLib.h M src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/Library/ExtractGuidedSectionLib.h M src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/Library/UefiLib.h M src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/Protocol/Smbios.h M src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/Uefi/UefiMultiPhase.h M src/vendorcode/intel/edk2/uefi_2.4/MdePkg/Include/Uefi/UefiMultiPhase.h 27 files changed, 51 insertions(+), 51 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/30160/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I179264ee6681a7ba4488b9f1c6bce1a19b4e1772 Gerrit-Change-Number: 30160 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/sarien: Use meaningful Satamode
by Patrick Rudolph (Code Review) 11 Dec '18

11 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30095 ) Change subject: mb/google/sarien: Use meaningful Satamode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I903545d9487c1409f9008407fe5bee6aa4959b98 Gerrit-Change-Number: 30095 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 19:11:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Declare SATA Mode clear
by Patrick Rudolph (Code Review) 11 Dec '18

11 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30093 ) Change subject: soc/intel/cannonlake: Declare SATA Mode clear ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1edcadc0048df839da145260b60f9f7720d981fe Gerrit-Change-Number: 30093 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 19:10:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP]mb/google/octopus: Override emmc DLL values for Phaser
by Justin TerAvest (Code Review) 11 Dec '18

11 Dec '18

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30144 ) Change subject: [WIP]mb/google/octopus: Override emmc DLL values for Phaser ...................................................................... Patch Set 1: Please let us know what the validation results are. Is there an estimated time for getting the result? -- To view, visit https://review.coreboot.org/c/coreboot/+/30144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8d56e0faf5c96d980c0614a61fbc6eacf582943 Gerrit-Change-Number: 30144 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin TerAvest <teravest(a)chromium.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 19:09:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86: Support x86_64 exceptions
by Patrick Rudolph (Code Review) 11 Dec '18

11 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 ) Change subject: arch/x86: Support x86_64 exceptions ...................................................................... Patch Set 4: Fixed assembly code to match "System V ABI". Exceptions handling on x86_64 now works fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/30117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Gerrit-Change-Number: 30117 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 19:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86: Support x86_64 exceptions
by build bot (Jenkins) (Code Review) 11 Dec '18

11 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 ) Change subject: arch/x86: Support x86_64 exceptions ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/30117/4/src/arch/x86/include/arch/registers… File src/arch/x86/include/arch/registers.h: https://review.coreboot.org/#/c/30117/4/src/arch/x86/include/arch/registers… PS4, Line 46: #define QUAD_DOWNTO8(A) \ macros should not use a trailing semicolon https://review.coreboot.org/#/c/30117/4/src/arch/x86/include/arch/registers… PS4, Line 52: #define QUAD_DOWNTO16(A) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/30117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Gerrit-Change-Number: 30117 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 19:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86: Support x86_64 exceptions
by Patrick Rudolph (Code Review) 11 Dec '18

11 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30117 to look at the new patch set (#4). Change subject: arch/x86: Support x86_64 exceptions ...................................................................... arch/x86: Support x86_64 exceptions Tested on qemu using division by zero. Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 --- M src/arch/x86/exception.c M src/arch/x86/idt.S M src/arch/x86/include/arch/registers.h 3 files changed, 84 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30117/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Gerrit-Change-Number: 30117 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/kahlee/liara: Document why IOMMU is disabled
by Angel Pons (Code Review) 11 Dec '18

11 Dec '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30166 ) Change subject: mb/google/kahlee/liara: Document why IOMMU is disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I564013a16217445003467e2a0579abd50597b205 Gerrit-Change-Number: 30166 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 18:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018