coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Patch Set 2: Bard/Ekko is going to build the EVT on 12/24(Fri) the problem will cause the gatting of EVT build Please help to approve it and push it in nami firmware branch. -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 07:17:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 07:11:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko According to bard/ekko cpu types, PL2 need to set the values 1. KBL_U PL2 is 25w. 2. KBL_R PL2 is 29w. BUG=b:120874861 TEST=power on and check the DUT can boot up well Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30178/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: google/grunt: Add lost charactor hynix-H5ANAG6NAMR-UH.spd.hex SPD fil...
by Lucas Chen (Code Review) 12 Dec '18

12 Dec '18

Lucas Chen has removed Tim Chen from this change. ( https://review.coreboot.org/c/coreboot/+/30177 ) Change subject: google/grunt: Add lost charactor hynix-H5ANAG6NAMR-UH.spd.hex SPD file Module Part Number ...................................................................... Removed reviewer Tim Chen. -- To view, visit https://review.coreboot.org/c/coreboot/+/30177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d320b2e10c4865456a9a9ccb400db5dd9256b3e Gerrit-Change-Number: 30177 Gerrit-PatchSet: 1 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by build bot (Jenkins) (Code Review) 12 Dec '18

12 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Patch Set 1: (18 comments) https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 250: case SKU_0_EKKO: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 250: case SKU_0_EKKO: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 251: case SKU_1_EKKO: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 251: case SKU_1_EKKO: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 252: case SKU_2_EKKO: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 252: case SKU_2_EKKO: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 253: case SKU_3_EKKO: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 253: case SKU_3_EKKO: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 254: case SKU_0_BARD: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 254: case SKU_0_BARD: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 255: case SKU_1_BARD: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 255: case SKU_1_BARD: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 256: case SKU_2_BARD: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 256: case SKU_2_BARD: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 257: case SKU_3_BARD: code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 257: case SKU_3_BARD: please, no spaces at the start of a line https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 258: pl2_id = PL2_ID_BARD_EKKO; code indent should use tabs where possible https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants… PS1, Line 258: pl2_id = PL2_ID_BARD_EKKO; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 07:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30178 Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko According to bard/ekko cpu types, PL2 need to set the values 1. KBL_U PL2 is 25w. 2. KBL_R PL2 is 29w. BUG=b:120874861 TEST=power on and check the DUT can boot up well Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30178/1 diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index ba994c2..be85f0e 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -35,6 +35,7 @@ /* PL2 ID define*/ #define PL2_ID_DEFAULT 0 #define PL2_ID_SONA_SYNDRA 1 +#define PL2_ID_BARD_EKKO 2 static const struct pl2_config { uint32_t cpuid_y0_pl2; @@ -42,6 +43,7 @@ } pl2_config_table[] = { [PL2_ID_DEFAULT] = { PL2_I7_SKU, PL2_DEFAULT }, [PL2_ID_SONA_SYNDRA] = { PL2_DEFAULT, PL2_KBL_U }, + [PL2_ID_BARD_EKKO] = { PL2_DEFAULT, PL2_KBL_U }, }; /* Variant for AKALI */ @@ -245,6 +247,15 @@ case SKU_2_PANTHEON: cfg->usb2_ports[5].enable = 0; break; + case SKU_0_EKKO: + case SKU_1_EKKO: + case SKU_2_EKKO: + case SKU_3_EKKO: + case SKU_0_BARD: + case SKU_1_BARD: + case SKU_2_BARD: + case SKU_3_BARD: + pl2_id = PL2_ID_BARD_EKKO; default: break; } -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: google/grunt: Add lost charactor hynix-H5ANAG6NAMR-UH.spd.hex SPD fil...
by Lucas Chen (Code Review) 12 Dec '18

12 Dec '18

Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30177 Change subject: google/grunt: Add lost charactor hynix-H5ANAG6NAMR-UH.spd.hex SPD file Module Part Number ...................................................................... google/grunt: Add lost charactor hynix-H5ANAG6NAMR-UH.spd.hex SPD file Module Part Number Correct to add Ram_ID=0b0001 SPD Module Part Number lost last alphabet 'C' to "H5ANAG6NAMR-UHC". BUG=b:120000816 BRANCH=master TEST=mosys memory spd print all Change-Id: I4d320b2e10c4865456a9a9ccb400db5dd9256b3e Signed-off-by: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/30177/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex index 0071c88..390940f 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex @@ -20,7 +20,7 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 AD 01 00 00 00 00 00 00 48 35 41 4E 41 47 36 -4E 41 4D 52 2D 55 48 20 20 20 20 20 20 00 80 AD +4E 41 4D 52 2D 55 48 43 20 20 20 20 20 00 80 AD FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/c/coreboot/+/30177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d320b2e10c4865456a9a9ccb400db5dd9256b3e Gerrit-Change-Number: 30177 Gerrit-PatchSet: 1 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
by build bot (Jenkins) (Code Review) 12 Dec '18

12 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 ) Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ...................................................................... Patch Set 39: (7 comments) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… File src/soc/intel/common/block/cpu/mp_service_ppi.c: https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 47: EFI_PEI_SERVICES **ignored1, EFI_PEI_MP_SERVICES_PPI *ignored2, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 60: static EFI_STATUS mp_get_processor_info(CONST EFI_PEI_SERVICE **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 85: static EFI_STATUS mp_startup_all_aps(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 104: static EFI_STATUS mp_startup_this_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 130: static EFI_STATUS mp_switch_bsp(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 138: static EFI_STATUS mp_enable_disable_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_… PS39, Line 145: static EFI_STATUS mp_identify_processor(CONST EFI_PEI_SERVICES **PeiServices, need consistent spacing around '*' (ctx:WxO) -- To view, visit https://review.coreboot.org/c/coreboot/+/25634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956 Gerrit-Change-Number: 25634 Gerrit-PatchSet: 39 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Comment-Date: Wed, 12 Dec 2018 06:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: lib/fit: Normalize spaces in board names to dashes
by Julius Werner (Code Review) 12 Dec '18

12 Dec '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30173 ) Change subject: lib/fit: Normalize spaces in board names to dashes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46f2b2d7091782e04df5476e50698001511f664b Gerrit-Change-Number: 30173 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 06:27:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Fix potential NULL pointer dereferences and memory leak.
by Patrick Rudolph (Code Review) 12 Dec '18

12 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 ) Change subject: Fix potential NULL pointer dereferences and memory leak. ...................................................................... Patch Set 1: Code-Review-1 No. You have to rebase and send a valid patch that gets +1 from Jenkins. -- To view, visit https://review.coreboot.org/c/coreboot/+/30098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 1 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 05:43:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018