coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: Documentation/*/fit.md: Fix reference to arm64 FIT implementation file
by Tristan Corrick (Code Review) 12 Dec '18

12 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30174 ) Change subject: Documentation/*/fit.md: Fix reference to arm64 FIT implementation file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5844642e25f4c9fe114f621446b4df1075500441 Gerrit-Change-Number: 30174 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 04:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/soc/intel/icelake: Fix references between documents
by Tristan Corrick (Code Review) 12 Dec '18

12 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30157 ) Change subject: Documentation/soc/intel/icelake: Fix references between documents ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbdab15b1183998712f92d1f2f5340d2ad1451dc Gerrit-Change-Number: 30157 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 04:37:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/soc/intel/icelake: Fix indentation in numbered list
by Tristan Corrick (Code Review) 12 Dec '18

12 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30156 ) Change subject: Documentation/soc/intel/icelake: Fix indentation in numbered list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3634775ed9f993b1181785c58d72834183336e1 Gerrit-Change-Number: 30156 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 04:34:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/mainboard/lenovo/t420.md: fix typo
by Tristan Corrick (Code Review) 12 Dec '18

12 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30170 ) Change subject: Documentation/mainboard/lenovo/t420.md: fix typo ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/30170/2/Documentation/mainboard/lenovo/t420… File Documentation/mainboard/lenovo/t420.md: https://review.coreboot.org/#/c/30170/2/Documentation/mainboard/lenovo/t420… PS2, Line 10: ![t420_chip_location]: t420_chip_location.jpg Needs to be ![t420_chip_location](t420_chip_location.jpg) -- To view, visit https://review.coreboot.org/c/coreboot/+/30170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia70f5d5ad2fdf4c0e811ab92a817375a89694122 Gerrit-Change-Number: 30170 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Bacarella <michael.bacarella(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Comment-Date: Wed, 12 Dec 2018 04:26:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Enable touchpad and touchscreen
by Duncan Laurie (Code Review) 12 Dec '18

12 Dec '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30146 ) Change subject: mb/google/sarien/variants/arcada: Enable touchpad and touchscreen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3dcdb4eeeb32766e64553d9e69e6b7e2b5ba85aa Gerrit-Change-Number: 30146 Gerrit-PatchSet: 2 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Assignee: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 01:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP]mb/google/octopus: Override emmc DLL values for Bobba
by Bora Guvendik (Code Review) 12 Dec '18

12 Dec '18

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30176 Change subject: [WIP]mb/google/octopus: Override emmc DLL values for Bobba ...................................................................... [WIP]mb/google/octopus: Override emmc DLL values for Bobba New emmc DLL values for Bobba. BUG=b:120561055 TEST=Boot to OS, chromeos-install, mmc_test Change-Id: I5a0d9587a91b3c71c042cd8ea360c816ea29fb91 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/mainboard/google/octopus/variants/bobba/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/30176/1 diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb index c0f37e2..17686f6 100644 --- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb @@ -1,5 +1,46 @@ chip soc/intel/apollolake + # EMMC Tx CMD Delay + # Refer to EDS-Vol2-16.32. + # [14:8] steps of delay for DDR mode, each 125ps. + # [6:0] steps of delay for SDR mode, each 125ps. + register "emmc_tx_cmd_cntl" = "0x505" + + # EMMC TX DATA Delay 1 + # Refer to EDS-Vol2-16.33. + # [14:8] steps of delay for HS400, each 125ps. + # [6:0] steps of delay for SDR104/HS200, each 125ps. + register "emmc_tx_data_cntl1" = "0x0a0b" + + # EMMC TX DATA Delay 2 + # Refer to EDS-Vol2-16.34. + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_tx_data_cntl2" = "0x1c272828" + + # EMMC RX CMD/DATA Delay 1 + # Refer to EDS-Vol2-16.35. + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_rx_cmd_data_cntl1" = "0x00181b1a" + + # EMMC RX CMD/DATA Delay 2 + # Refer to EDS-Vol2-16.37. + # [17:16] stands for Rx Clock before Output Buffer + # [14:8] steps of delay for Auto Tuning Mode, each 125ps. + # [6:0] steps of delay for HS200, each 125ps. + register "emmc_rx_cmd_data_cntl2" = "0x10021" + + # EMMC Rx Strobe Delay + # Refer to EDS-Vol2-16.36. + # [14:8] Rx Strobe Delay DLL 1(HS400 Mode), each 125ps. + # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps. + register "emmc_rx_strobe_cntl" = "0x0a0a" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | -- To view, visit https://review.coreboot.org/c/coreboot/+/30176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0d9587a91b3c71c042cd8ea360c816ea29fb91 Gerrit-Change-Number: 30176 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: arch/riscv: Define and use SBI_ENOSYS
by Jonathan Neuschäfer (Code Review) 12 Dec '18

12 Dec '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30175 Change subject: arch/riscv: Define and use SBI_ENOSYS ...................................................................... arch/riscv: Define and use SBI_ENOSYS Change-Id: Ia7f409ebc7e50383a7e445ef8806953347501dab Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/include/sbi.h M src/arch/riscv/sbi.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/30175/1 diff --git a/src/arch/riscv/include/sbi.h b/src/arch/riscv/include/sbi.h index e9301f6..2943704 100644 --- a/src/arch/riscv/include/sbi.h +++ b/src/arch/riscv/include/sbi.h @@ -26,6 +26,8 @@ #define SBI_REMOTE_SFENCE_VMA_ASID 7 #define SBI_SHUTDOWN 8 +#define SBI_ENOSYS 38 + #define IPI_SOFT 1 #define IPI_FENCE_I 2 #define IPI_SFENCE_VMA 4 diff --git a/src/arch/riscv/sbi.c b/src/arch/riscv/sbi.c index 832d4d3..e540828 100644 --- a/src/arch/riscv/sbi.c +++ b/src/arch/riscv/sbi.c @@ -113,7 +113,7 @@ ret = send_ipi((uintptr_t *)arg0, IPI_SHUTDOWN); break; default: - ret = -38; + ret = -SBI_ENOSYS; break; } tf->gpr[10] = ret; -- To view, visit https://review.coreboot.org/c/coreboot/+/30175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7f409ebc7e50383a7e445ef8806953347501dab Gerrit-Change-Number: 30175 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Documentation/*/fit.md: Fix reference to arm64 FIT implementation file
by Jonathan Neuschäfer (Code Review) 12 Dec '18

12 Dec '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30174 Change subject: Documentation/*/fit.md: Fix reference to arm64 FIT implementation file ...................................................................... Documentation/*/fit.md: Fix reference to arm64 FIT implementation file Change-Id: I5844642e25f4c9fe114f621446b4df1075500441 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/lib/payloads/fit.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/30174/1 diff --git a/Documentation/lib/payloads/fit.md b/Documentation/lib/payloads/fit.md index 53be92e..24807bf 100644 --- a/Documentation/lib/payloads/fit.md +++ b/Documentation/lib/payloads/fit.md @@ -25,7 +25,7 @@ The FIT parser needs architecure support. ### aarch64 -The source code can be found in `src/arch/arm64/fit.c`. +The source code can be found in `src/arch/arm64/fit_payload.c`. On aarch64 the kernel (a section named 'kernel') must be in **Image** format and it needs a devicetree (a section named 'fdt') to boot. -- To view, visit https://review.coreboot.org/c/coreboot/+/30174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5844642e25f4c9fe114f621446b4df1075500441 Gerrit-Change-Number: 30174 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: lib/fit: Normalize spaces in board names to dashes
by Jonathan Neuschäfer (Code Review) 12 Dec '18

12 Dec '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30173 Change subject: lib/fit: Normalize spaces in board names to dashes ...................................................................... lib/fit: Normalize spaces in board names to dashes CONFIG_MAINBOARD_PART_NUMBER sometimes contains spaces, but spaces inside compat strings aren't nice, so let's convert all spaces to dashes. Change-Id: I46f2b2d7091782e04df5476e50698001511f664b Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/lib/fit.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/30173/1 diff --git a/src/lib/fit.c b/src/lib/fit.c index da55072..090d34a 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -38,12 +38,12 @@ struct list_node list_node; }; -/* Convert string to lowercase and replace '_' with '-'. */ +/* Convert string to lowercase and replace '_' and spaces with '-'. */ static char *clean_compat_string(char *str) { for (size_t i = 0; i < strlen(str); i++) { str[i] = tolower(str[i]); - if (str[i] == '_') + if (str[i] == '_' || str[i] == ' ') str[i] = '-'; } -- To view, visit https://review.coreboot.org/c/coreboot/+/30173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46f2b2d7091782e04df5476e50698001511f664b Gerrit-Change-Number: 30173 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Fix potential NULL pointer dereferences and memory leak.
by Francois Toguo Fotso (Code Review) 11 Dec '18

11 Dec '18

Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30098 ) Change subject: Fix potential NULL pointer dereferences and memory leak. ...................................................................... Patch Set 1: Could you please merge the files in this patch except for the following conflicting one? I will push it in a different patch later on. src/arch/x86/acpigen.c Regards, Francois -- To view, visit https://review.coreboot.org/c/coreboot/+/30098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 1 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 22:22:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018