Ivy Jian has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/30183 )
Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
......................................................................
Removed reviewer Martin Roth.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1
Gerrit-Change-Number: 30183
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-MessageType: deleteReviewer
Ivy Jian has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/30183 )
Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
......................................................................
Removed reviewer Patrick Georgi.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1
Gerrit-Change-Number: 30183
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: deleteReviewer
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants…
PS2, Line 250: case SKU_0_EKKO:
: case SKU_1_EKKO:
: case SKU_2_EKKO:
: case SKU_3_EKKO:
: case SKU_0_BARD:
: case SKU_1_BARD:
: case SKU_2_BARD:
: case SKU_3_BARD:
: pl2_id = PL2_ID_BARD_EKKO;
> Okay. So, the port 5 needs to be kept enabled. […]
Ok ! updated !
add "break;"
--
To view, visit https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 09:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30181 )
Change subject: mb/google/cheza/chromeos.c: Add recovery mode and WP staus functions
......................................................................
Abandoned
Functions are available in ec/google/chromeec/switches.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/30181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b532474e442153913cf031fb03cf1d661416ef7
Gerrit-Change-Number: 30181
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30178
to look at the new patch set (#3).
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................
mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
According to bard/ekko cpu types, PL2 need to set the values
1. KBL_U PL2 is 25w.
2. KBL_R PL2 is 29w.
BUG=b:120874861
TEST=power on and check the DUT can boot up well
Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/mainboard.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30178/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30181
to look at the new patch set (#2).
Change subject: mb/google/cheza/chromeos.c: Add recovery mode and WP staus functions
......................................................................
mb/google/cheza/chromeos.c: Add recovery mode and WP staus functions
In commit 303a4bfd4a0df01c329683322466da46129313b1 the config
VBOOT_NO_BOARD_SUPPORT is removed. This disables weak
get_recovery_mode_switch() and get_write_protect_state(), without
having strong functions avaiilable.
Add get_recovery_mode_switch() and get_write_protect_state() .
BUG=N/A
TEST=N/A
Change-Id: I8b532474e442153913cf031fb03cf1d661416ef7
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/mainboard/google/cheza/chromeos.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/30181/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b532474e442153913cf031fb03cf1d661416ef7
Gerrit-Change-Number: 30181
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset